Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  closed
Component:  File |  Version:  master
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  callable storage | Triage Stage:  Ready for
  filefield  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson ):

 In [changeset:"94b32a20ef798768029651f0e8fcc07731a62a64" 94b32a2]:
 {{{
 #!CommitTicketReference repository=""
 revision="94b32a20ef798768029651f0e8fcc07731a62a64"
 Refs #28184 -- Added test for FileField storage default.

 Co-authored-by: miigotu 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f9cb2b8b6d00c19aa751609e923ec24a%40djangoproject.com.

Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  master
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Ready for
  filefield  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.bd4a20cc1d6366397b47bf2e1f8bf557%40djangoproject.com.

Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  master
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Accepted
  filefield  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.573c79fe2728ba126929a9a8e48942e1%40djangoproject.com.

Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  master
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Accepted
  filefield  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.cb395d8ffb6bdeef6f785d47a32255af%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  master
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Accepted
  filefield  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by miigotu):

 * version:  1.11 => master


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.01294c6673be08a12c155187e517c14f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  1.11
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Accepted
  filefield  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by miigotu):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.609cb73eb00bce8a10b3b117feaf278f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  1.11
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Accepted
  filefield  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by miigotu):

 Replying to [comment:4 Carlton Gibson]:
 > Left some comments on PR.

 PR Updated, please review

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9149a7926c88c547fdae2d8f005588db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  1.11
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Accepted
  filefield  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Left some comments on PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3cf1fbdf95065533dc49dd4efdc975d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  1.11
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Accepted
  filefield  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c3611c59f4a60293077d24a3d7601826%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28184: FileField storage param should allow a callable

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  1.11
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Accepted
  filefield  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by miigotu):

 * needs_better_patch:  1 => 0


Comment:

 Improved patch, passes all tests now.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f14cbde5a3dd2218afc419d7f4d2ca8f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28184: FileField storage param should allow a callable (was: FileField storages param should allow a callable)

[Django]

#28184: FileField storage param should allow a callable
-+-
 Reporter:  miigotu  |Owner:  miigotu
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  1.11
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:  callable storage | Triage Stage:  Accepted
  filefield  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 Tentatively accepting. This idea also came up in #24648. The PR has test
 failures and documentation changes are also required. See the
 PatchReviewChecklist.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.18a4b318c6e39542a4d786f812792743%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.