subject:"\[Django\] #28198\: Model attributes shouldn't override deferred fields"

Re: [Django] #28198: Model attributes shouldn't override deferred fields

2020-03-26 Thread Django

#28198: Model attributes shouldn't override deferred fields
-+-
 Reporter:  Ryan Hiebert |Owner:
 |  Denis.Tarykin
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  assigned => closed
 * resolution:   => duplicate


Comment:

 Whilst this was earlier, closing as a duplicate of #30427.

 (Thanks all.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.46c98954f1c5c04a2667f4d3126a972f%40djangoproject.com.

Re: [Django] #28198: Model attributes shouldn't override deferred fields

2018-01-31 Thread Django

* needs_better_patch: 0 => 1

Comment:

Feedback on patch:

* At the least, please break out the logic adjusting attributes on parent
models and add tests for those.
* Can we not do this without actually altering the parent models? (e.g.
one possibility, by noting duplicates and checking against that in
`Field.contribute_to_class`)
* This should be helped by extracting the helper methods but, it wasn't
clear what the code was doing and why. The comments should be clarified if
necessary.

Please uncheck "Patch needs improvement" after updating.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.56b0d6898de21fa23387d0b87d69cf4f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28198: Model attributes shouldn't override deferred fields

2017-11-09 Thread Django

#28198: Model attributes shouldn't override deferred fields
-+-
 Reporter:  Ryan Hiebert |Owner:
 |  Denis.Tarykin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Denis.Tarykin):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.d0365fb85ba3901129fd1c6b4d06f868%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28198: Model attributes shouldn't override deferred fields

2017-11-04 Thread Django

#28198: Model attributes shouldn't override deferred fields
-+-
 Reporter:  Ryan Hiebert |Owner:
 |  Denis.Tarykin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 I left some comments for improvement on the pull request. Please uncheck
 "Patch needs improvement" after updating.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.f7f671038bda9a0308dc50466ac6a0fb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28198: Model attributes shouldn't override deferred fields

2017-10-18 Thread Django

#28198: Model attributes shouldn't override deferred fields
-+-
 Reporter:  Ryan Hiebert |Owner:
 |  Denis.Tarykin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ryan Hiebert):

 * stage:  Accepted => Ready for checkin


Comment:

 I've tested the patch against the {{{auth.User}}} issue mentioned
 initially, and have reviewed the patch. It looks good to me, so I hope
 it's acceptable for me to mark it as Ready for Checkin, despite being the
 one who opened the issue. I anticipate that it would be appropriate to
 backport to supported versions of Django.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.b555329a79a6f6ac888a7e10b0133c3b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28198: Model attributes shouldn't override deferred fields

2017-09-25 Thread Django

#28198: Model attributes shouldn't override deferred fields
-+-
 Reporter:  Ryan Hiebert |Owner:
 |  Denis.Tarykin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Denis.Tarykin):

 * has_patch:  0 => 1


Comment:

 Pull Request:[https://github.com/django/django/pull/9126]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.1d74cb6dbe3e148671cc2abb7a5a9abf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28198: Model attributes shouldn't override deferred fields

2017-09-08 Thread Django

#28198: Model attributes shouldn't override deferred fields
-+-
 Reporter:  Ryan Hiebert |Owner:
 |  Denis.Tarykin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Denis.Tarykin):

 * owner:  nobody => Denis.Tarykin
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.4075a94670a6e636d47338e8c9919bdb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28198: Model attributes shouldn't override deferred fields

2017-05-15 Thread Django

#28198: Model attributes shouldn't override deferred fields
-+-
 Reporter:  Ryan Hiebert |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Adam (Chainz) Johnson):

 * cc: me@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.33915626116eb00cd4cf94ee6e80da01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28198: Model attributes shouldn't override deferred fields (was: Doesn't override existing class attributes with a deferred instance attribute)

2017-05-15 Thread Django

#28198: Model attributes shouldn't override deferred fields
-+-
 Reporter:  Ryan Hiebert |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted
 * component:  Uncategorized => Database layer (models, ORM)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.5a0ff825e3e8d242585f726739727842%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28198: Model attributes shouldn't override deferred fields

Re: [Django] #28198: Model attributes shouldn't override deferred fields

Re: [Django] #28198: Model attributes shouldn't override deferred fields

Re: [Django] #28198: Model attributes shouldn't override deferred fields

Re: [Django] #28198: Model attributes shouldn't override deferred fields

Re: [Django] #28198: Model attributes shouldn't override deferred fields

Re: [Django] #28198: Model attributes shouldn't override deferred fields

Re: [Django] #28198: Model attributes shouldn't override deferred fields

Re: [Django] #28198: Model attributes shouldn't override deferred fields (was: Doesn't override existing class attributes with a deferred instance attribute)

9 matches

Site Navigation

Mail list logo

Footer information