Re: [Django] #28416: Doc improvement: "divisibleby" DTL filter

2017-07-20 Thread Django
#28416: Doc improvement: "divisibleby" DTL filter
-+-
 Reporter:  Mike Morris  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.11
 Severity:  Normal   |   Resolution:
 |  worksforme
 Keywords:  divisibleby, | Triage Stage:
  template, filter   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-

Comment (by Marten Kenbeek):

 As a former math major, I can confirm that "divisible by" always refers to
 the non-trivial case of integer division (or similar non-trivial cases). I
 also don't think changing the wording to "integrally" necessary makes it
 any clearer.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.ca22ade76de0103ef1f1152849104e07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28416: Doc improvement: "divisibleby" DTL filter

2017-07-20 Thread Django
#28416: Doc improvement: "divisibleby" DTL filter
-+-
 Reporter:  Mike Morris  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.11
 Severity:  Normal   |   Resolution:
 |  worksforme
 Keywords:  divisibleby, | Triage Stage:
  template, filter   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 I don't see much advantage to changing the wording. I'm not a
 mathematician but my understanding after doing a quick search is that
 "divisible by" is short for "divisible equally and integrally". `{{
 3|divisibleby:'0' }}` raises a `ZeroDivisionError` exception anyway.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.662aac6d2ed28fc72a2b249a2382a15f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #28416: Doc improvement: "divisibleby" DTL filter

2017-07-19 Thread Django
#28416: Doc improvement: "divisibleby" DTL filter
-+-
   Reporter:  Mike   |  Owner:  nobody
  Morris |
   Type: | Status:  new
  Cleanup/optimization   |
  Component: |Version:  1.11
  Documentation  |   Keywords:  divisibleby,
   Severity:  Normal |  template, filter
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  1  |
-+-
 This is trivial, but the docs are so excellent, I thought I'd chime in

 https://docs.djangoproject.com/en/1.11/ref/templates/builtins/#divisibleby
 states that, ''"Returns True if the value is divisible by the argument."''

 Technically of course, the above is always true unless the argument is 0.

 You meant "...if the value is **integrally** divisible by the argument."

 Thanks for great docs to a great product!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.637b24d7c849b9c3f8c947eaa5e7c2ae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.