Re: [Django] #28692: QuerySet.bulk_create() combine with select/prefetch_related()

[Django]

#28692: QuerySet.bulk_create() combine with select/prefetch_related()
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  bulk_create  | Triage Stage:  Accepted
  select_related prefetch_related|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 No patch was provided and I agree that this will be very hard to implement
 `select_related` in a backend agnostic way. Now that
 
[https://docs.djangoproject.com/en/4.1/ref/models/querysets/#django.db.models.prefetch_related_objects
 prefetch_related_objects] is a documented public API it can be used it to
 achieve the same results as what `prefetch_related` would have done.

 Closing as ''wontfix'' for now, I wouldn't be opposed to reopening once we
 get better support for `RETURNING` handling at the `sql.Query` level if a
 patch is provided.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182ce052ac1-cec9d386-2625-4a23-8022-812af26e23f1-00%40eu-central-1.amazonses.com.

Re: [Django] #28692: QuerySet.bulk_create() combine with select/prefetch_related()

[Django]

#28692: QuerySet.bulk_create() combine with select/prefetch_related()
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  bulk_create  | Triage Stage:  Accepted
  select_related prefetch_related|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Дилян Палаузов):

 I guess a patch will be provided for prefetch_related() once #28600 gets
 integrated, as stated in the fourth comment of that ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.f9ed4e36c231a1793e8f6bd1b1c596d8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28692: QuerySet.bulk_create() combine with select/prefetch_related()

[Django]

#28692: QuerySet.bulk_create() combine with select/prefetch_related()
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  bulk_create  | Triage Stage:  Accepted
  select_related prefetch_related|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 I guess a patch could be evaluated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.71366420ae1992e76282b731200c88fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28692: QuerySet.bulk_create() combine with select/prefetch_related()

[Django]

#28692: QuerySet.bulk_create() combine with select/prefetch_related()
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  bulk_create  | Triage Stage:
  select_related prefetch_related|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tomer Chachamu):

 I think it will be impossible to implement on backends other than
 postgres, as you would want to do {{{SELECT b.* FROM modela JOIN modelb ON
 modela.b_id = modelb.id WHERE modela.id IN (...)}}}, however the value of
 {{{(...)}}} is only available in postgres.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b383050dbcde24ed587324721ba18537%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28692: QuerySet.bulk_create() combine with select/prefetch_related()

[Django]

#28692: QuerySet.bulk_create() combine with select/prefetch_related()
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  bulk_create  | Triage Stage:
  select_related prefetch_related|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Дилян Палаузов):

 * status:  closed => new
 * resolution:  needsinfo =>


Comment:

 #28600 asks for adding .prefetch_related() support to RawQuerySet .  I
 don't see why that ticket is clear, but this one, asking for adding
 prefetch_related() support to bulk_create() is anyhow different and hence
 unclear.

 Despite there are already two other ways to reduce  the number of queries,
 prefetch_related() is more coherent, as this what users are used to in
 other circumstances.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.94c6fb39e1758e1b13c42189ee087e2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28692: QuerySet.bulk_create() combine with select/prefetch_related()

[Django]

#28692: QuerySet.bulk_create() combine with select/prefetch_related()
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  bulk_create  | Triage Stage:
  select_related prefetch_related|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tomer Chachamu):

 * status:  new => closed
 * resolution:   => needsinfo


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.edb9a60ce46f88d35c4c035ecaab060f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28692: QuerySet.bulk_create() combine with select/prefetch_related()

[Django]

#28692: QuerySet.bulk_create() combine with select/prefetch_related()
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  bulk_create  | Triage Stage:
  select_related prefetch_related|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tomer Chachamu):

 https://docs.djangoproject.com/en/dev/internals/contributing/bugs-and-
 features/

 > First request the feature on the django-developers list, not in the
 ticket tracker. It’ll get read more closely if it’s on the mailing list.
 This is even more important for large-scale feature requests. We like to
 discuss any big changes to Django’s core on the mailing list before
 actually working on them.

 Please send the feature request again to the mailing list. However, here's
 my opinion:

 I don't think it will be possible to implement `select_related` as the
 behaviour of `INSERT .. RETURNING ..` varies a lot between databases. It
 would be possible to implement `prefetch_related`.

 There are already two ways to reduce the number of queries, is either good
 for you? One is:

 {{{#!python
 from django.db.models import prefetch_related_objects
 new_objects = [ModelA(..., b_id=3), ModelA(..., b_id=4), ModelA(...,
 b_id=5)]
 ModelA.objects.bulk_create(new_objects)
 prefetch_related_objects(new_objects, 'b')
 for m in new_objects:
 print m.b.description
 }}}

 Another is setting the `b` attribute on your models, instead of `b_id`

 {{{#!python
 bs_by_id = ModelB.objects.in_bulk(relevant_b_ids)
 new_objects = [ModelA(..., b=bs_by_id[3]), ModelA(..., b=bs_by_id[4]),
 ModelA(..., b=bs_by_id[5])]
 ModelA.objects.bulk_create(new_objects)
 for m in new_objects:
 print m.b.description
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.2781cf739ca9b41625e1ad89536b5316%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28692: QuerySet.bulk_create() combine with select/prefetch_related()

[Django]

#28692: QuerySet.bulk_create() combine with select/prefetch_related()
-+-
   Reporter:  Дилян  |  Owner:  nobody
  Палаузов   |
   Type: | Status:  new
  Uncategorized  |
  Component:  Database   |Version:  1.11
  layer (models, ORM)|   Keywords:  bulk_create
   Severity:  Normal |  select_related prefetch_related
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 When several objects are created with Models.objects.bulk_create() the
 called might want to prefetch/JOIN some related models to the new objects,
 so that additional SELECTs are avoided.

 {{{
 for m in ModelA.objects.select_related('b').bulk_create([ModelA(...),
 ModelA(...), ModelA(...)]):
   print(m.b.description) # this line shall now cause a new SELECT on each
 iteration
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.1876612ac6824f475dcd43422108f782%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.