Re: [Django] #28718: Resetting your password shouldn't depend on your current password being hashed with a supported hasher

2017-10-17 Thread Django
#28718: Resetting your password shouldn't depend on your current password being
hashed with a supported hasher
-+-
 Reporter:  Josh Harwood |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Josh Harwood):

 Replying to [comment:1 Tim Graham]:
 > Where's that restriction implemented?

 This line with "has_usable_password":
 https://github.com/django/django/blob/master/django/contrib/auth/forms.py#L264

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.3f3fde1f7dfd52f8b3111424ba79b529%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28718: Resetting your password shouldn't depend on your current password being hashed with a supported hasher

2017-10-17 Thread Django
#28718: Resetting your password shouldn't depend on your current password being
hashed with a supported hasher
-+-
 Reporter:  Josh Harwood |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  Bug => Cleanup/optimization


Comment:

 Where's that restriction implemented?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.2004c5476a9dfb4f7b8edf28eb0a27a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #28718: Resetting your password shouldn't depend on your current password being hashed with a supported hasher

2017-10-17 Thread Django
#28718: Resetting your password shouldn't depend on your current password being
hashed with a supported hasher
-+
   Reporter:  mr-bo-jangles  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  contrib.auth   |Version:  1.11
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Currently the built in django password reset system requires that you have
 an active account and that your password can be compared to by an enabled
 hasher.

 I think that this is in error, as you are about to reset the password to
 something new (hence resetting it) and the standard process of password
 resetting requires an email confirmation. I can see no way in which this
 is able to be abused by a malicious 3rd party. If I'm mistaken here then
 feel free to correct me.

 I propose that the system is changed to just require that the user is
 active and that their password is not marked disabled as per the
 UNUSABLE_PASSWORD_PREFIX.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.b556015ac55901bafbb52e3b2c8d0ffa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.