#28889: Use JavaScript to prevent double submission of admin forms --------------------------------------+------------------------------------ Reporter: Manuel Saelices | Owner: nobody Type: Cleanup/optimization | Status: new Component: contrib.admin | Version: 1.11 Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 1 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 --------------------------------------+------------------------------------ Changes (by Tim Graham):
* has_patch: 0 => 1 * type: Bug => Cleanup/optimization * needs_tests: 0 => 1 Comment: I found an article titled [http://www.the-art-of- web.com/javascript/doublesubmit/ JavaScript: Preventing Double Form Submission] which might be worth reviewing. In particular, it points out "Rather than simply disabling the button, we can also change the text so that people don't get confused." Did you consider trying to add some tests for the patch? I share Nick's concern on the pull request that this may have a good chance of causing some regression in unconsidered edge cases. I'm not sure if it's considered a best practice these days. The article suggests that some browsers (e.g. IE11) treat a double click as a single click. It seems unfortunate if every project has to add something like this. -- Ticket URL: <https://code.djangoproject.com/ticket/28889#comment:3> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.322bf1c01024d1883de2c58d5da7f27f%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.