Re: [Django] #29048: Add **extra_context arg to as_vendor methods in database functions

[Django]

#29048: Add **extra_context arg to as_vendor methods in database functions
-+-
 Reporter:  Matthew Pava |Owner:  Priyansh
 Type:   |  Saxena
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"83b04d4f88dd65ae630a45385de34e275899dc41" 83b04d4]:
 {{{
 #!CommitTicketReference repository=""
 revision="83b04d4f88dd65ae630a45385de34e275899dc41"
 Fixed #29048 -- Added **extra_context to database function as_vendor()
 methods.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f82bd8a952e643c870df39d37d3fde50%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29048: Add **extra_context arg to as_vendor methods in database functions

[Django]

#29048: Add **extra_context arg to as_vendor methods in database functions
-+-
 Reporter:  Matthew Pava |Owner:  Priyansh
 Type:   |  Saxena
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e450fb7c619696b2fb3bbc786f54bc01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29048: Add **extra_context arg to as_vendor methods in database functions

[Django]

#29048: Add **extra_context arg to as_vendor methods in database functions
-+-
 Reporter:  Matthew Pava |Owner:  Priyansh
 Type:   |  Saxena
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Priyansh Saxena):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/9673 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2e48660775acb5fe66689ca322cbd8fb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29048: Add **extra_context arg to as_vendor methods in database functions

[Django]

#29048: Add **extra_context arg to as_vendor methods in database functions
-+-
 Reporter:  Matthew Pava |Owner:  Priyansh
 Type:   |  Saxena
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Priyansh Saxena):

 * owner:  nobody => Priyansh Saxena
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.932ef4d4c271f652be7fdcab3d10f3bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29048: Add **extra_context arg to as_vendor methods in database functions

[Django]

#29048: Add **extra_context arg to as_vendor methods in database functions
-+-
 Reporter:  Matthew Pava |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Matthew Pava):

 Correct, Tim.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3d4810c6b8aa782e716a561e2ebb0330%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29048: Add **extra_context arg to as_vendor methods in database functions

[Django]

#29048: Add **extra_context arg to as_vendor methods in database functions
-+-
 Reporter:  Matthew Pava |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 But there's no concrete issue, correct? I suppose we can change those
 signatures, even if it's just fix the PyCharm warnings.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d4c4cbc44bcc229dbb64ac4622f86d97%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29048: Add **extra_context arg to as_vendor methods in database functions

[Django]

#29048: Add **extra_context arg to as_vendor methods in database functions
-+-
 Reporter:  Matthew Pava |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Old description:

> `Func` inherits from `SQLiteNumericMixin`, which added an extra argument
> to `as_sqlite`: `**extra_context`.  Based on feedback from other
> developers, it seems we should add this argument to each `as_vendor`
> method.

New description:

 `Func` inherits from `SQLiteNumericMixin`, which added an extra argument
 to `as_sqlite`: `**extra_context`.  PyCharm flags the database functions
 that inherit from `Func` because their `as_sqlite` methods do not have
 that extra argument.

--

Comment (by Matthew Pava):

 I updated the description to describe the problem in better detail.

 When I was working on
 
[https://github.com/django/django/pull/9583/files/4b61d2bc73641edbe303ecdbcc8f810db795f1b3
 #diff-bda8c5979f2cb4b5bf2d3f87f507363f PR 9583], a contributor made this
 comment when I had unintentionally made the changes to other classes not
 related to that PR:
 > I've also noticed a warning in Pycharm that the signature of as_sqlite
 and as_oracle doesn't match the superclass. I'd guess it's better to deal
 with this in a different PR.

 I assumed that the contributor was speaking on behalf of "other
 developers."

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.aaf7c91113c2f317568afaef8f848e9b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29048: Add **extra_context arg to as_vendor methods in database functions

[Django]

#29048: Add **extra_context arg to as_vendor methods in database functions
-+-
 Reporter:  Matthew Pava |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * easy:  1 => 0


Comment:

 Is there a concrete problem? It's unclear what "Based on feedback from
 other developers" refers to.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.36c47c96c610b2b89ea7fe6f9a0b6e9a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29048: Add **extra_context arg to as_vendor methods in database functions

[Django]

#29048: Add **extra_context arg to as_vendor methods in database functions
-+-
   Reporter:  Matthew|  Owner:  nobody
  Pava   |
   Type: | Status:  new
  Cleanup/optimization   |
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
 `Func` inherits from `SQLiteNumericMixin`, which added an extra argument
 to `as_sqlite`: `**extra_context`.  Based on feedback from other
 developers, it seems we should add this argument to each `as_vendor`
 method.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.25f2d49f0074540a0a8da8edae5ed2b3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.