Re: [Django] #29063: Replacement Migrations not being executed because of unapplied migrations should raise a warning.

[Django]

#29063: Replacement Migrations not being executed because of unapplied 
migrations
should raise a warning.
+---
 Reporter:  Julian  |Owner:  Jacob Walls
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.9
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---
Changes (by Jacob Walls):

 * type:  Cleanup/optimization => Bug


Comment:

 After Mariusz helpfully enumerated scenarios where the current messaging
 is sufficient, we found really only a single case with an improvable
 `NodeNotFoundError`, and I agree it would be better to just fix the
 failure point than invest energy in a patch changing the exception
 message:

 [https://github.com/django/django/pull/14727 New PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.a02bb14d31f4a2218d27632722a708ef%40djangoproject.com.

Re: [Django] #29063: Replacement Migrations not being executed because of unapplied migrations should raise a warning.

[Django]

#29063: Replacement Migrations not being executed because of unapplied 
migrations
should raise a warning.
-+-
 Reporter:  Julian   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


Comment:

 On the PR Mariusz demonstrated several examples having to do with this
 ticket's description where the error messages are sufficiently
 informative. However, I think my test case is related to the original
 poster's scenario (although it is hard to be certain), and shows Django
 raising an improvable `NodeNotFoundError`.

 Glad to give it another look, though, if you think I'm misreading the
 original poster's use case.  (To that end, Julian, I would be grateful if
 you would be able to take a look at my suggested patch.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.fa769929938c4893ff3f6930c655a979%40djangoproject.com.

Re: [Django] #29063: Replacement Migrations not being executed because of unapplied migrations should raise a warning.

[Django]

#29063: Replacement Migrations not being executed because of unapplied 
migrations
should raise a warning.
-+-
 Reporter:  Julian   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.67c95d49734a496e0d09b7176d51b8a2%40djangoproject.com.

Re: [Django] #29063: Replacement Migrations not being executed because of unapplied migrations should raise a warning.

[Django]

#29063: Replacement Migrations not being executed because of unapplied 
migrations
should raise a warning.
-+-
 Reporter:  Julian   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/14643 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.81b60da5962c68f7b6c5362f3300103b%40djangoproject.com.

Re: [Django] #29063: Replacement Migrations not being executed because of unapplied migrations should raise a warning.

[Django]

#29063: Replacement Migrations not being executed because of unapplied 
migrations
should raise a warning.
-+-
 Reporter:  Julian   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * owner:  nobody => Jacob Walls
 * status:  new => assigned


Comment:

 Somewhat similar to #23556, I think we can raise a more informative
 `NodeNotFoundError`. Should have a patch soon, just need to toy with
 whether backward migrations are also a problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.6302837ce9f8d6f3cab537f82a108b68%40djangoproject.com.

Re: [Django] #29063: Replacement Migrations not being executed because of unapplied migrations should raise a warning.

[Django]

#29063: Replacement Migrations not being executed because of unapplied 
migrations
should raise a warning.
--+
 Reporter:  Julian|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.b2604ccac77090e82d0922c944d67ace%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29063: Replacement Migrations not being executed because of unapplied migrations should raise a warning.

[Django]

#29063: Replacement Migrations not being executed because of unapplied 
migrations
should raise a warning.
+
   Reporter:  Julian Schneider  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Migrations|Version:  1.9
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 In Line 205-208 in django/db/migrations/loader.py replacement migrations
 (created with squash) are checked if they can be applied. If any of the to
 be replaced migrations isn't already applied the replacement migration is
 not added to the nodes list.

 This leads to the fact that if some of the migrations are removed or not
 completely applied before the squash is added and there is a dependency on
 the replacement migration, the user gets a 'NodeNotFoundError' where the
 replacement migration that is not being applied because of line 206 is the
 missing one.

 This is very confusing to the user, raising a warning in line 208 would
 inform the user that the squashed migration can not be applied because not
 all the 'child' migrations are applied.

 Had to debug into that to figure that out.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/058.888a0d0f84c2a197c67c6bc9bcb4dd19%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.