Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"c903e905b3c5d66477f8d04717650644afc04e1f" c903e905]:
 {{{
 #!CommitTicketReference repository=""
 revision="c903e905b3c5d66477f8d04717650644afc04e1f"
 [2.1.x] Refs #29449 -- Removed release note for "Allowed using
 contrib.auth forms without installing contrib.auth."

 The code was reverted in f3fa86a89b3b85242f49b2b9acf58b5ea35acc1f.
 Backport of d3449faaa915a08c275b35de01e66a7ef6bdb2dc from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.2a7a6a7d41c0db43d767a33aed75c691%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"d3449faaa915a08c275b35de01e66a7ef6bdb2dc" d3449fa]:
 {{{
 #!CommitTicketReference repository=""
 revision="d3449faaa915a08c275b35de01e66a7ef6bdb2dc"
 Refs #29449 -- Removed release note for "Allowed using contrib.auth forms
 without installing contrib.auth."

 The code was reverted in f3fa86a89b3b85242f49b2b9acf58b5ea35acc1f.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7ee8c4d650a25d711694438533a07830%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"78f502cd0bc834422c3f189e852564fe4b6459f2" 78f502c]:
 {{{
 #!CommitTicketReference repository=""
 revision="78f502cd0bc834422c3f189e852564fe4b6459f2"
 [2.1.x] Fixed #29449 -- Reverted "Fixed #28757 -- Allowed using
 contrib.auth forms without installing contrib.auth."

 This reverts commit d935d2914cd80cf31f4803821ad5c0e2a51d due to
 a crash if USERNAME_FIELD isn't a CharField.

 Backport of f3fa86a89b3b85242f49b2b9acf58b5ea35acc1f from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e4557fd50aaeeae151bad596719e0f0e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f3fa86a89b3b85242f49b2b9acf58b5ea35acc1f" f3fa86a]:
 {{{
 #!CommitTicketReference repository=""
 revision="f3fa86a89b3b85242f49b2b9acf58b5ea35acc1f"
 Fixed #29449 -- Reverted "Fixed #28757 -- Allowed using contrib.auth forms
 without installing contrib.auth."

 This reverts commit d935d2914cd80cf31f4803821ad5c0e2a51d due to
 a crash if USERNAME_FIELD isn't a CharField.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.b11f2dbd491ed3db81b102357346aa18%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * cc: felixxm (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.cc61371f79f8c916dc500565d3572cdd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sławek Ehlert):

 @Carlton I've opened https://github.com/django/django/pull/10068

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.dbd14ab58c078f58da56ad88e15674ce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * has_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d5d25323a23ba9d3096de8f01cd70b77%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * cc: Carlton Gibson (added)


Comment:

 @Sławek: Can you push your progress somewhere? I can have a look and see
 if I can help.

 > ...we should either fix it or ditch it completely.

 Yes. OK.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6ee9889ad9a5167a28cc67c2f1b6b465%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sławek Ehlert):

 So I think, regarding this feature - we should either fix it or ditch it
 completely.

 I made some substantial progress on #29467 lately. I'd like to try and
 tackle this ticket next (although I have some time constraints and the
 progress may be slow on this).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.4143a69eed1200f50b65072679867bc7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sławek Ehlert):

 Well, I think the more pressing problem is not the feature set Django
 supports and the docs, but the fact that the change mentioned here breaks
 the test suite and can break people's projects.

 Also by having a {{{auth_tests.CustomUserWithFK}}} model in the test
 suite, one would think that this kind of model is supported by Django,
 which is not true at this point.

 Moreover, having a similar user model in a project means that a developer
 can't even import from {{{django.contrib.auth.forms}}} module. And what if
 something imports that module that's not in developer's control? E.g.
 currently {{{django/contrib/admin/forms.py}}},
 {{{django/contrib/auth/admin.py}}} and {{{django/contrib/auth/views.py}}}
 are importing something from that module, so that means on fresh project
 with admin enabled with that kind of a user model, developer can't even
 run {{{./manage.py --help}}}.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6a216be5f8310b8ba33881610a561a97%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * has_patch:  0 => 1


Comment:

 I've opened [https://github.com/django/django/pull/10062 PR] to adjust the
 docs here.

 > I think we could deescalate from a release blocker by documenting this
 limitation.

 Hopefully that lets us move forward.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.4ff6736a5ab8f79f99cd8ae27bf7340d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sławek Ehlert):

 I'd like to submit a patch for that, but currently I was focusing more on
 solving #29467 first.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.b1f64bfbe6b5a5d37b0958e1b45bb4ea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29449: UserCreationForm and UserChangeForm don't work if username isn't a CharField (was: Regression in UserCreationForm (and UserChangeForm) for custom user models)

[Django]

#29449: UserCreationForm and UserChangeForm don't work if username isn't a
CharField
-+-
 Reporter:  Sławek Ehlert|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Release blocker  |   Resolution:
 Keywords:  auth forms   | Triage Stage:  Accepted
  UserCreationForm UserChangeForm|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 If a patch isn't forthcoming (the best way to avoid the issue that Markus
 pointed out in comment 1 isn't obvious to me), I think we could deescalate
 from a release blocker by documenting this limitation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.1dc8f9fabaf69ba78a92b37e1667e2cf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.