Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

[Django]

#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b0fbfae09334554124e1dccb7559d10f36e2f84c" b0fbfae0]:
 {{{
 #!CommitTicketReference repository=""
 revision="b0fbfae09334554124e1dccb7559d10f36e2f84c"
 Fixed #29503 -- Made __in lookup keep order of values in query.

 Regression in 86eccdc8b67728d84440a46e5bf62c78f2eddf6d.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3b44de15d3dc86c92034ca1190357c54%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

[Django]

#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"16e691d568a06873445171025ba44b5f00920e7e" 16e691d]:
 {{{
 #!CommitTicketReference repository=""
 revision="16e691d568a06873445171025ba44b5f00920e7e"
 [2.1.x] Fixed #29503 -- Made __in lookup keep order of values in query.

 Regression in 86eccdc8b67728d84440a46e5bf62c78f2eddf6d.

 Backport of b0fbfae09334554124e1dccb7559d10f36e2f84c from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b88161b736e550945da9917621d9761a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

[Django]

#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * cc: Carlton Gibson (added)
 * stage:  Unreviewed => Ready for checkin


Comment:

 I'd be happy with the use of `OrderedSet` here. Semantically `in` uses a
 set but we (always/mostly?) pass it a list, which is ordered, and it's
 reasonable enough to maintain that. (Beyond Nick's usage, it could be
 handy somewhere.)

 Is this a regression? Was it always part of the contract? Not sure. Pass.
 :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.19c62f224578a26ce1f5cae8120ee90e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

[Django]

#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ian Foote):

 * cc: Ian Foote (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f0ad9ec6a43473743819d2a77fe74e71%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

[Django]

#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Nick Pope):

 Replying to [comment:2 Tim Graham]:
 > What practical problem did you encounter? I'm surprised that the order
 of items in an `IN` clause would matter much.

 Heh. I get the feeling that I'm going to get shot down here (and I know
 and understand the reasons why).

 I've inherited some code that currently and for the foreseeable future
 depends on the output of the query generated by `Query.sql_with_params()`.
 It executes it via `pandas.DataFrame.read_sql_query()` and also uses this
 to generate a cache key. Because the parameter ordering is unstable, this
 affects the key generation.

 Regardless of the horrors of this, the issue looks like a regression to me
 - the previous behaviour changed unexpectedly. I can understand if you'd
 like to only apply this to master, however.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.17f92072fa1c6a358273b86310bac614%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

[Django]

#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 What practical problem did you encounter? I'm surprised that the order of
 items in an `IN` clause would matter much.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.670c4dedc07d5432a73c5f6bb86321b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

[Django]

#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Nick Pope):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/10060 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.207d3030e3176019e5e2d1c44aba0207%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29503: Order of parameters pass to __in lookup affected by de-duplication.

[Django]

#29503: Order of parameters pass to __in lookup affected by de-duplication.
-+-
   Reporter:  Nick Pope  |  Owner:  Nick Pope
   Type:  Bug| Status:  assigned
  Component:  Database   |Version:  1.11
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 After the fix for ticket #25544, the order of parameters passed to the
 `__in` lookup is affected by the de-duplication using `set()`.

 This results in the generated query being unstable between different runs
 of the python interpreter due to hash seed randomisation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.cd96c9a27019aade8510efcdd8982503%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.