Re: [Django] #29729: Update "Writing your first patch for Django" tutorial

[Django]

#29729: Update "Writing your first patch for Django" tutorial
-+-
 Reporter:  Adam (Chainz)|Owner:  Adam
  Johnson|  (Chainz) Johnson
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Yes, as you say. 🙂

 * Happy for you to suggest what you think is best.
 * Not sure ‘'anything’’ would survive without maintanence indefinitely.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.485191d8d0173b6fc76bb3c6904750bc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29729: Update "Writing your first patch for Django" tutorial

[Django]

#29729: Update "Writing your first patch for Django" tutorial
-+-
 Reporter:  Adam (Chainz)|Owner:  Adam
  Johnson|  (Chainz) Johnson
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Adam (Chainz) Johnson):

 Sure. It would be a lot of requirements though, and other bitrot can still
 take place like Python and Pip versions incompatibilities.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3dc9ff83035883af2e2e4cfb8cdfca47%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29729: Update "Writing your first patch for Django" tutorial

[Django]

#29729: Update "Writing your first patch for Django" tutorial
-+-
 Reporter:  Adam (Chainz)|Owner:  Adam
  Johnson|  (Chainz) Johnson
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 The tutorial: [Writing your first patch for Django
 https://docs.djangoproject.com/en/2.1/intro/contributing/]

 One option would be to provide a pinned set of requirements, so that users
 create a virtualenv in a a known state, compatible with the ticket/Django
 commit picked.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.430573b48451c04ad3ea679c4eb6ebf6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29729: Update "Writing your first patch for Django" tutorial

[Django]

#29729: Update "Writing your first patch for Django" tutorial
-+-
 Reporter:  Adam (Chainz)|Owner:  Adam
  Johnson|  (Chainz) Johnson
 Type:  Uncategorized|   Status:  assigned
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Adam (Chainz) Johnson):

 * cc: Adam (Chainz) Johnson (added)
 * owner:  nobody => Adam (Chainz) Johnson
 * status:  new => assigned


Comment:

 I suspect moving to a later commit isn't a great idea as it'll just be a
 moving target. I suggest instead some kind of "fake feature" in the
 tutorial to implement, such as adding a new function to django.__init__.
 This would also require less knowledge of the specifics of whatever real
 tickets are touching, e.g. the current one is a fairly niche forms
 feature. Thoughts anyone?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.192dc3b7a58f82965ce9d7d3fb9451c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29729: Update "Writing your first patch for Django" tutorial

[Django]

#29729: Update "Writing your first patch for Django" tutorial
-+
   Reporter:  Adam (Chainz) Johnson  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  2.1
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 As discussed recently on the django-core-mentorship list (link for those
 who can see it: https://groups.google.com/d/msg/django-core-
 mentorship/SawVLIt2ntk/MvuwLUaUAwAJ ), there are some test failures now
 when following the "Rolling back to a previous revision of Django" section
 of this tutorial. The reporter found failures with a new GEOS version (for
 an issue fixed on django master a year ago), and I found test failures
 with Python 3.7 because the given commit is from Django 1.9.

 I suggest two changes:

 * Encourage running the test suite on master before hitting this section -
 any commit we pick to 'roll back to' is going
 * Update to a recent commit and ticket

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.30556ef828a46509bb10db0a7cee2421%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.