Re: [Django] #29997: Allow combining SearchQuerys with different configs

[Django]

#29997: Allow combining SearchQuerys with different configs
-+-
 Reporter:  Jaap Roes|Owner:  Jaap Roes
 Type:  Bug  |   Status:  closed
Component:  contrib.postgres |  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8a1a9194686881e32d0e3aed52d7f4150238530c" 8a1a9194]:
 {{{
 #!CommitTicketReference repository=""
 revision="8a1a9194686881e32d0e3aed52d7f4150238530c"
 Fixed #29997 -- Allowed combining SearchQuerys with different configs.

 Seems to be a needless restriction in
 978a00e39fee25cfa99065285b0de88366710fad.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0a20653aa749cf280ab51ad9075be76a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29997: Allow combining SearchQuerys with different configs

[Django]

#29997: Allow combining SearchQuerys with different configs
-+-
 Reporter:  Jaap Roes|Owner:  Jaap Roes
 Type:  Bug  |   Status:  assigned
Component:  contrib.postgres |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jaap Roes):

 fwiw, I think the `config` equality check was copied from the
 implementation of `SearchVectorCombinable`. The validity of that check
 there is also questioned by at least one person (see ticket #28528)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.b46018b64aaa0bb15d97f7a5ce02f080%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29997: Allow combining SearchQuerys with different configs

[Django]

#29997: Allow combining SearchQuerys with different configs
-+-
 Reporter:  Jaap Roes|Owner:  Jaap Roes
 Type:  Bug  |   Status:  assigned
Component:  contrib.postgres |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


Comment:

 Before merging, I'll give the original author some time to respond to the
 question about why the restriction was added. The patch looks fine.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.866613ec8c9c50d7e7ef3c317b3f62d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29997: Allow combining SearchQuerys with different configs

[Django]

#29997: Allow combining SearchQuerys with different configs
--+-
 Reporter:  Jaap Roes |Owner:  Jaap Roes
 Type:  Bug   |   Status:  assigned
Component:  contrib.postgres  |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+-
Changes (by Simon Charette):

 * version:  master => 1.11
 * component:  Database layer (models, ORM) => contrib.postgres


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.cedc8466d17ff9e8d6d4da6e2e57fce9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29997: Allow combining SearchQuerys with different configs

[Django]

#29997: Allow combining SearchQuerys with different configs
-+-
 Reporter:  Jaap Roes|Owner:  Jaap Roes
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the bisect sleuthing here. Given this is a regression in 1.11
 I'm not sure this qualifies for a backport for 2.1 at this point.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0e7f162e4002d0419b585fc9ebd1b421%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29997: Allow combining SearchQuerys with different configs

[Django]

#29997: Allow combining SearchQuerys with different configs
-+-
 Reporter:  Jaap Roes|Owner:  Jaap Roes
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jaap Roes):

 * type:  Cleanup/optimization => Bug


Comment:

 I ran `git bisect` and technically this is a regression from commit
 978a00e39fee25cfa99065285b0de88366710fad

 Before that commit this works:

 `search.SearchQuery("foo", config="simple") | search.SearchQuery("bar",
 config="english")`

 Afterwards it doesn't

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0b2d46d04288e87f5cb5a4da65473186%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29997: Allow combining SearchQuerys with different configs

[Django]

#29997: Allow combining SearchQuerys with different configs
-+-
 Reporter:  Jaap Roes|Owner:  Jaap Roes
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jaap Roes):

 * owner:  nobody => Jaap Roes


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ba7e502d7b6330cdf9c97aae1c12e733%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29997: Allow combining SearchQuerys with different configs

[Django]

#29997: Allow combining SearchQuerys with different configs
-+-
   Reporter:  Jaap Roes  |  Owner:  nobody
   Type: | Status:  assigned
  Cleanup/optimization   |
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 The fix for ticket #27143 (SearchQuery is not combinable using more than
 one `&` or `|` operators) introduced some code that raises a `TypeError`
 when trying to combine `SearchQuery` objects that do not share the same
 `config`.

 I'm not sure if this restriction makes sense. In SQL it seems to be
 allowed e.g.:

 `SELECT to_tsquery('simple', 'working') || to_tsquery('english',
 'working');`
 `'working' | 'work'`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.0329cd973699ade02ac90d9612bb2759%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.