Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
-+-
 Reporter:  Joshua Cannon|Owner:  Joshua
 |  Cannon
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  RemoteUserBackend| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"d17be88afd5f5e1059491e10408ba239e2e99fe2" d17be88a]:
 {{{
 #!CommitTicketReference repository=""
 revision="d17be88afd5f5e1059491e10408ba239e2e99fe2"
 Refs #30037 -- Required the RemoteUserBackend.configure_user() to have
 request as the first positional argument.

 Per deprecation timeline.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f429cfb1a9ea8b982c4e60b2bb88ad31%40djangoproject.com.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
-+-
 Reporter:  Joshua Cannon|Owner:  Joshua
 |  Cannon
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  RemoteUserBackend| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"db1b10ef0dcab2b8bacbea4adc681a57bd70b462" db1b10ef]:
 {{{
 #!CommitTicketReference repository=""
 revision="db1b10ef0dcab2b8bacbea4adc681a57bd70b462"
 Fixed #30037 -- Added request arg to RemoteUserBackend.configure_user().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2a8c2f88eabaf318f288344d70011327%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
-+-
 Reporter:  Joshua Cannon|Owner:  Joshua
 |  Cannon
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  RemoteUserBackend| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette):

 Hello Joshua, your
 
[https://code.djangoproject.com/query?status=!closed&needs_better_patch=0&needs_tests=0&needs_docs=0&has_patch=1&stage=Accepted&desc=1&order=changetime
 patch is currently in the review list] but it might take a few days before
 fellows get to it because of holidays.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ea3758b04639973ed6d22790efe6ab27%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
-+-
 Reporter:  Joshua Cannon|Owner:  Joshua
 |  Cannon
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  RemoteUserBackend| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Joshua Cannon):

 What's the protocol for "bump"-ing a review? Is there a reviewer or
 reviewers I should add? Or should I comment on the PR?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.da8b3fa89e0571fdd4933d40e2237939%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
-+-
 Reporter:  Joshua Cannon|Owner:  Joshua
 |  Cannon
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  RemoteUserBackend| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Greg W):

 Thanks for the explanation Simon!

 Joshua - sure thing, have at it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e1e54459056b9fa6c82b4147268ff6d2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
-+-
 Reporter:  Joshua Cannon|Owner:  Joshua
 |  Cannon
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  RemoteUserBackend| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Joshua Cannon):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/10751 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.490aadf6791f37851d28cf00868488a4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
-+-
 Reporter:  Joshua Cannon|Owner:  Joshua
 |  Cannon
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  RemoteUserBackend| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Joshua Cannon):

 * owner:  nobody => Joshua Cannon
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1db9e5f0a6812406e9dafad36da14621%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
---+
 Reporter:  Joshua Cannon  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.auth   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  RemoteUserBackend  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Joshua Cannon):

 Actually, if you don't mind, I'd love to take a stab at it. It seems easy
 enough as a first PR, and it's something I'm needing anyways :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ca83e3daec9562819bf204d42e71c49d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
---+
 Reporter:  Joshua Cannon  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.auth   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  RemoteUserBackend  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Simon Charette):

 Hello Greg!

 The idea is to follow the usual approach used when a function signature is
 changed in a backward incompatible way. That is:

 1. Before calling the function inspect it to determine whether or not it
 uses the new or old signature. This can be done using
 `inspect.getcallargs(self.configure_user, request, user)` in this case.
 2. If a `TypeError` is raised that means the function still uses the old
 signature. That means a `RemovedInDjango31Warning` warning should be
 emitted and the function should be called with the old signature, that is
 without passing `request`.
 3. In no exceptions are raised that means the function was either not
 overridden or switched to the new signature so it can be directly called
 with the new request argument.

 Have a look at 4b9330ccc04575f9e5126529ec355a450d12e77c as an example.

 This will also require documentation updates and tests as demonstrated in
 the above example as well.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.56b507c8ffd4b8e71d02e0440694fccd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
---+
 Reporter:  Joshua Cannon  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.auth   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  RemoteUserBackend  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Greg W):

 Is this as simple as adding {{{request}}} to {{{configure_user(user)}}}
 and updating the documentation regarding the change?  If so, I can take
 it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f0f5429f3eba0e6f7e7ce8ec6e6b1f88%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
---+
 Reporter:  Joshua Cannon  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.auth   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  RemoteUserBackend  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Simon Charette):

 * version:  2.1 => master
 * stage:  Unreviewed => Accepted


Comment:

 Now that `authenticate` gets passed `request` I don't see a reason why
 this can't be done for `configure_user`.

 I guess we could reuse `configure_user(request, user)` with a deprecation
 shim that warns about a `configure_user(user)` signature through `inspect`
 reflection just like when the `request` argument was introduced to
 `authenticate` in #25187.

 Here's an example:

 
https://github.com/django/django/commit/4b9330ccc04575f9e5126529ec355a450d12e77c
 #diff-82ec6fd74a1cab41408fbf5bf0998f58R73

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2b32ba09d498d59b857926c464f18121%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30037: RemoteUserBackend should pass request into configure_user()

[Django]

#30037: RemoteUserBackend should pass request into configure_user()
-+-
   Reporter:  Joshua |  Owner:  nobody
  Cannon |
   Type:  New| Status:  new
  feature|
  Component: |Version:  2.1
  contrib.auth   |
   Severity:  Normal |   Keywords:  RemoteUserBackend
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Clients that wish to populate a user's information by subclassing
 {{{RemoteUserBackend}}} and overriding {{{configure_user}}} find
 themselves a bit restricted on what they can configure. If a client wants
 to fill out the user's first name and last name using HTTP headers, there
 is no easy solution for them.

 Instead, the request should also be sent to {{{configure_user}}} (or
 something similar that wouldn't break compatibility).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.0f499510feedba3cafae4028dbe2c6a8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.