Re: [Django] #30234: Disallow non-uppercase settings in settings.configure()

[Django]

#30234: Disallow non-uppercase settings in settings.configure()
--+
 Reporter:  orlnub123 |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Core (Other)  |  Version:  dev
 Severity:  Normal|   Resolution:  fixed
 Keywords:  settings  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Mariusz Felisiak):

 Replying to [comment:7 k4ml]:
 > Btw the fix is simple actually, add:-
 >
 >
 > del _
 >
 > at the end of settings.py. The localization docs should add this in
 notes.

 It's not an issue in Django or its docs. It's an issue in
 `pytest_djangoapp`. `_` is not a setting name and should not be passed to
 the `.configure()`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c75b896a20d4f52e655d1001678b2515%40djangoproject.com.

Re: [Django] #30234: Disallow non-uppercase settings in settings.configure()

[Django]

#30234: Disallow non-uppercase settings in settings.configure()
--+
 Reporter:  orlnub123 |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Core (Other)  |  Version:  dev
 Severity:  Normal|   Resolution:  fixed
 Keywords:  settings  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by k4ml):

 Replying to [comment:6 Mariusz Felisiak]:

 > This ticket has nothing to do with using `_` in `settings.py`, it's
 about non-uppercase setting names.

 `_` failed `isupper()` check.

 Btw the fix is simple actually, add:-

 ```
 del _
 ```

 at the end of settings.py. The localization docs should add this in notes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.81440667f232784c66b81fd29ab1a5c1%40djangoproject.com.

Re: [Django] #30234: Disallow non-uppercase settings in settings.configure()

[Django]

#30234: Disallow non-uppercase settings in settings.configure()
--+
 Reporter:  orlnub123 |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Core (Other)  |  Version:  dev
 Severity:  Normal|   Resolution:  fixed
 Keywords:  settings  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Mariusz Felisiak):

 Replying to [comment:5 k4ml]:
 > The docs still showing example that using `_` in settings.py -
 
https://github.com/django/django/blob/7f33c1e22dbc34a7afae7967783725b10f1f13b1/docs/ref/settings.txt#L1951
 >
 > And this check cause issue when third party app is calling
 settings.configure():-
 >
 > https://github.com/idlesign/pytest-
 djangoapp/blob/master/pytest_djangoapp/plugin.py#L42
 >
 > If this is no longer recommended practice, the docs above should be
 fixed not to use `_` anymore in settings.py.

 This ticket has nothing to do with using `_` in `settings.py`, it's about
 non-uppercase setting names.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.20e7c8341aa68ffa620f53922dabfccb%40djangoproject.com.

Re: [Django] #30234: Disallow non-uppercase settings in settings.configure()

[Django]

#30234: Disallow non-uppercase settings in settings.configure()
--+
 Reporter:  orlnub123 |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Core (Other)  |  Version:  dev
 Severity:  Normal|   Resolution:  fixed
 Keywords:  settings  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by k4ml):

 The docs still showing example that using `_` in settings.py -
 
https://github.com/django/django/blob/7f33c1e22dbc34a7afae7967783725b10f1f13b1/docs/ref/settings.txt#L1951

 And this check cause issue when third party app is calling
 settings.configure():-

 https://github.com/idlesign/pytest-
 djangoapp/blob/master/pytest_djangoapp/plugin.py#L42

 If this is no longer recommended practice, the docs above should be fixed
 not to use `_` anymore in settings.py.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6d5568be9e9f4bf151e755acfdedb9bb%40djangoproject.com.

Re: [Django] #30234: Disallow non-uppercase settings in settings.configure()

[Django]

#30234: Disallow non-uppercase settings in settings.configure()
--+
 Reporter:  orlnub123 |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:  settings  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"163236ea0e5df1a301371e79ec35fc67b7a1b7a6" 163236e]:
 {{{
 #!CommitTicketReference repository=""
 revision="163236ea0e5df1a301371e79ec35fc67b7a1b7a6"
 Fixed #30234 -- Disallowed non-upper settings in settings.configure().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d6a2bd1a1ff3d5b371b24ae96616f687%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30234: Disallow non-uppercase settings in settings.configure() (was: Disallow non-upper settings)

[Django]

#30234: Disallow non-uppercase settings in settings.configure()
--+
 Reporter:  orlnub123 |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  settings  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7cb652b2241bbc4d78a6bd83fea18d64%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.