Re: [Django] #30980: admin.E130 (duplicate __name__ attributes of actions) should specify which were duplicated.

[Django]

#30980: admin.E130 (duplicate __name__ attributes of actions) should specify 
which
were duplicated.
-+-
 Reporter:  Keryn Knight |Owner:  AdamDonna
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8b3e714ecf409ed6c9628c3f2a4e033cbfa4253b" 8b3e714e]:
 {{{
 #!CommitTicketReference repository=""
 revision="8b3e714ecf409ed6c9628c3f2a4e033cbfa4253b"
 Fixed #30980 -- Improved error message when checking uniqueness of admin
 actions' __name__.

 Thanks Keshav Kumar for the initial patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f1b394b844cb40ca299a535dc6db7d4e%40djangoproject.com.

Re: [Django] #30980: admin.E130 (duplicate __name__ attributes of actions) should specify which were duplicated.

[Django]

#30980: admin.E130 (duplicate __name__ attributes of actions) should specify 
which
were duplicated.
-+-
 Reporter:  Keryn Knight |Owner:  AdamDonna
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * owner:  KESHAV KUMAR => AdamDonna
 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin
 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.29ecda2a686c4aad0dc1e237473f9fd8%40djangoproject.com.

Re: [Django] #30980: admin.E130 (duplicate __name__ attributes of actions) should specify which were duplicated.

[Django]

#30980: admin.E130 (duplicate __name__ attributes of actions) should specify 
which
were duplicated.
-+-
 Reporter:  Keryn Knight |Owner:  KESHAV
 Type:   |  KUMAR
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by felixxm):

 [https://github.com/django/django/pull/12281 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e8f7ae972c288f9818314a0114d1d490%40djangoproject.com.

Re: [Django] #30980: admin.E130 (duplicate __name__ attributes of actions) should specify which were duplicated.

[Django]

#30980: admin.E130 (duplicate __name__ attributes of actions) should specify 
which
were duplicated.
-+-
 Reporter:  Keryn Knight |Owner:  KESHAV
 Type:   |  KUMAR
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Parth Patil):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f44d7431059dbbfcb066a674fd0c62ad%40djangoproject.com.

Re: [Django] #30980: admin.E130 (duplicate __name__ attributes of actions) should specify which were duplicated.

[Django]

#30980: admin.E130 (duplicate __name__ attributes of actions) should specify 
which
were duplicated.
-+-
 Reporter:  Keryn Knight |Owner:  KESHAV
 Type:   |  KUMAR
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by KESHAV KUMAR):

 Hey! I am new to django contribution and I want to solve this issue. I
 want to know that error message of duplicates should write after the error
 of unique name in the same function ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.012ad922c0f9bb6037071cce929f303e%40djangoproject.com.

Re: [Django] #30980: admin.E130 (duplicate __name__ attributes of actions) should specify which were duplicated.

[Django]

#30980: admin.E130 (duplicate __name__ attributes of actions) should specify 
which
were duplicated.
-+-
 Reporter:  Keryn Knight |Owner:  KESHAV
 Type:   |  KUMAR
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by KESHAV KUMAR):

 * status:  new => assigned
 * owner:  nobody => KESHAV KUMAR


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.39d0a632a0baf9b133b0861040c7b686%40djangoproject.com.

Re: [Django] #30980: admin.E130 (duplicate __name__ attributes of actions) should specify which were duplicated. (was: admin.E130 (duplicate __name__ attributes of actions) should specify which were d

[Django]

#30980: admin.E130 (duplicate __name__ attributes of actions) should specify 
which
were duplicated.
--+
 Reporter:  Keryn Knight  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by felixxm):

 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Agreed, we can add names of duplicated actions to this message.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.41d2201275e6d5649b80369f402c3baf%40djangoproject.com.

[Django] #30980: admin.E130 (duplicate __name__ attributes of actions) should specify which were duplicated

[Django]

#30980: admin.E130 (duplicate __name__ attributes of actions) should specify 
which
were duplicated
+
   Reporter:  Keryn Knight  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 The fact that the `__name__` is used is somewhat an implementation detail,
 and there's no guarantee the user has enough of an understanding of python
 to know what that attribute is, let alone how to fix it.

 This just came up on IRC because a user had defined `actions =
 [delete_selected]` where `delete_selected` was a reference to their own
 callable, but shares the name of the base one (and by specifying the
 `actions = ` they were assuming that they were wholesale replacing the
 actions list, where that may not be true for site-wide actions) so errored
 ... but they only had define a list of `len(...) == 1` so how can there be
 a duplicate (is their thought process)?

 The error message should specify those names that occur 2> (rather than
 just check `len(...)` vs `len(set(...))`), and ought ideally to explain
 where the duplicate comes from (ie: AdminSite-wide).

 Related ticket about E130: #30311 (+ those it references) but is about the
 replacement strategy rather than the error message itself.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.53c41c9bf551ed0d125006d377e9481d%40djangoproject.com.