Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
--+
 Reporter:  Jon Dufresne  |Owner:  Jon Dufresne
 Type:  New feature   |   Status:  closed
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"67ea35df52f2e29bafca8881e4f356934061644e" 67ea35df]:
 {{{
 #!CommitTicketReference repository=""
 revision="67ea35df52f2e29bafca8881e4f356934061644e"
 Fixed #30998 -- Added ModelChoiceIteratorValue to pass the model instance
 to ChoiceWidget.create_option().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ec81972b36f71a6b36005f58cae69dee%40djangoproject.com.

Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
--+
 Reporter:  Jon Dufresne  |Owner:  Jon Dufresne
 Type:  New feature   |   Status:  assigned
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Mariusz Felisiak ):

 In [changeset:"5da85ea73724d75e609c5ee4316e7e5be8f17810" 5da85ea7]:
 {{{
 #!CommitTicketReference repository=""
 revision="5da85ea73724d75e609c5ee4316e7e5be8f17810"
 Refs #30998 -- Doc'd ModelChoiceField/ModelMultipleChoiceField.iterator
 attributes and ModelChoiceIterator.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.482c3c2500a3fe18eb889d8a7993e9ee%40djangoproject.com.

Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
--+
 Reporter:  Jon Dufresne  |Owner:  Jon Dufresne
 Type:  New feature   |   Status:  assigned
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by felixxm):

 * status:  new => assigned
 * owner:  nobody => Jon Dufresne
 * stage:  Ready for checkin => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.129b1ad4ae8ba6ef70026d00035c3f3a%40djangoproject.com.

Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
-+-
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.613f89c28fbef95c702fafe666927f64%40djangoproject.com.

Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
--+
 Reporter:  Jon Dufresne  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Jon Dufresne):

 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cacb9773943ad33086c83ffd3e7cce3f%40djangoproject.com.

Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
--+
 Reporter:  Jon Dufresne  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.de2e8f0f7484a80c2ac3eba5d0a58c51%40djangoproject.com.

Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
--+
 Reporter:  Jon Dufresne  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Jon Dufresne):

 * needs_docs:  1 => 0


Comment:

 Sounds good. I've documented the attribute and classes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c70e3d77d0d2564887013f69e439a217%40djangoproject.com.

Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
--+
 Reporter:  Jon Dufresne  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * needs_docs:  0 => 1
 * stage:  Unreviewed => Accepted


Old description:

> I often find myself needing to add extra attributes to subwdiget HTML
> elements that depend on the model instance object. For example, HTML
> `data-*` attributes.
>
> Others have had similar needs and created their own solutions. For
> example:  field/>.
>
> As this isn't built-in, there have been some backward incompatible
> changes on some releases: #27758.
>
> This ticket proposes to make this feature built-in to remove the need for
> third party applications to copy this boilerplate.
>
> ---
>
> Right now, the `ModelChoiceField.iterator` and `ModelChoiceIterator
> aren't documented. We could take this opportunity to do so if desired.

New description:

 I often find myself needing to add extra attributes to subwdiget HTML
 elements that depend on the model instance object. For example, HTML
 `data-*` attributes.

 Others have had similar needs and created their own solutions. For
 example: .

 As this isn't built-in, there have been some backward incompatible changes
 on some releases: #27758.

 This ticket proposes to make this feature built-in to remove the need for
 third party applications to copy this boilerplate.

 ---

 Right now, the `ModelChoiceField.iterator` and `ModelChoiceIterator`
 aren't documented. We could take this opportunity to do so if desired.

--

Comment:

 Hi Jon. Yes, super.

 ([https://github.com/carltongibson/django-
 
filter/blob/9a11b0bb8c3aaf8275b586458ec7acffcaaea104/django_filters/fields.py#L214-L275
 We have this exact kind of thing in Django Filter].) I think it should be
 a documented pattern. The `data-*` attribute is a nice example.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9366a31f1e8ee5268f39d4ed9871abb2%40djangoproject.com.

Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
--+--
 Reporter:  Jon Dufresne  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Jon Dufresne):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/12088

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5c1d5c8d6f0f57a6c4d71fe1c298c83f%40djangoproject.com.

[Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
+
   Reporter:  Jon Dufresne  |  Owner:  nobody
   Type:  New feature   | Status:  new
  Component:  Forms |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 I often find myself needing to add extra attributes to subwdiget HTML
 elements that depend on the model instance object. For example, HTML
 `data-*` attributes.

 Others have had similar needs and created their own solutions. For
 example: .

 As this isn't built-in, there have been some backward incompatible changes
 on some releases: #27758.

 This ticket proposes to make this feature built-in to remove the need for
 third party applications to copy this boilerplate.

 ---

 Right now, the `ModelChoiceField.iterator` and `ModelChoiceIterator aren't
 documented. We could take this opportunity to do so if desired.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.fc4317b12809ec7975a58ef5f022c030%40djangoproject.com.