Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
-+-
 Reporter:  thenewguy|Owner:  thenewguy
 Type:  New feature  |   Status:  closed
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"adb96617897690b3a01e39e8297ae7d67825d2bc" adb9661]:
 {{{
 #!CommitTicketReference repository=""
 revision="adb96617897690b3a01e39e8297ae7d67825d2bc"
 Fixed #31010 -- Allowed subdomains of localhost in the Host header by
 default when DEBUG=True.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3153e412f79c4d91f1eb1a4cfd502382%40djangoproject.com.

Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
-+-
 Reporter:  thenewguy|Owner:  thenewguy
 Type:  New feature  |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  1 => 0
 * version:  2.2 => master
 * component:  Uncategorized => HTTP handling
 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.36572cd757fa913b8c68c3dbba5fce58%40djangoproject.com.

Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
---+-
 Reporter:  thenewguy  |Owner:  thenewguy
 Type:  New feature|   Status:  assigned
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by felixxm):

 * type:  Uncategorized => New feature


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a4731919315dae4df2e4d7ffde2fc0dd%40djangoproject.com.

Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
---+-
 Reporter:  thenewguy  |Owner:  thenewguy
 Type:  Uncategorized  |   Status:  assigned
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by Simon Charette):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Hey there, thanks for your PR! Please don't mark your own patch ''Ready
 for Checking'', someone else has to review it and mark it accordingly. I
 left come comments for improvements on the PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.468faebcd453ad2757a941388154d47e%40djangoproject.com.

Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
-+-
 Reporter:  thenewguy|Owner:  thenewguy
 Type:  Uncategorized|   Status:  assigned
Component:  Uncategorized|  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by thenewguy):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c5821d1c4f07d2b8ae1399bbd2938ab6%40djangoproject.com.

Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
---+-
 Reporter:  thenewguy  |Owner:  thenewguy
 Type:  Uncategorized  |   Status:  assigned
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by thenewguy):

 * owner:  nobody => thenewguy
 * status:  new => assigned
 * has_patch:  0 => 1


Comment:

 PR submitted https://github.com/django/django/pull/12132

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fda526b1f98d7b0499d56d5974d2ac58%40djangoproject.com.

Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
---+
 Reporter:  thenewguy  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by thenewguy):

 * status:  closed => new
 * resolution:  needsinfo =>
 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


Old description:

> It would minimize configuration for new projects if ALLOWED_HOSTS +=
> ['.localhost'] when DEBUG=True
>
> Chrome resolves *.localhost to localhost without modifying any host files
> or DNS
>
> Referencing the project this way makes it easy to test subdomains ->
> static.localhost, uploads.localhost, www.localhost, etc

New description:

 It would minimize configuration for new projects if ALLOWED_HOSTS +=
 ['.localhost'] when DEBUG=True

 Chrome resolves *.localhost to localhost without modifying any host files
 or DNS

 Referencing the project this way makes it easy to test subdomains ->
 static.localhost, uploads.localhost, www.localhost, etc

 ---
 Updated
 ---

 Conversation on developer mailing list resulted in decision to reopen and
 accept ticket.  The conversation turned up that this behavior is spec
 compliant per https://tools.ietf.org/html/rfc6761#section-6.3

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0ecb4b53def6bde26266653d317b089c%40djangoproject.com.

Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
---+--
 Reporter:  thenewguy  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by thenewguy):

 For reference, the conversation chain has been started:
 https://groups.google.com/forum/#!topic/django-developers/xcoAF9Gm_dI

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a03ace606e1b2775134fe2e25fa60f9e%40djangoproject.com.

Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
---+--
 Reporter:  thenewguy  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Interesting. Currently we have, in HttpRequest.get_host():

 {{{
 # Allow variants of localhost if ALLOWED_HOSTS is empty and
 DEBUG=True.
 allowed_hosts = settings.ALLOWED_HOSTS
 if settings.DEBUG and not allowed_hosts:
 allowed_hosts = ['localhost', '127.0.0.1', '[::1]']
 }}}

 Can I ask you to post to the DevelopersMailingList to canvas opinion?
 Assuming no blockers are raised it seems reasonable enough... (Reopen if
 accepted there.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1e0bc7f71bade123aa00ba095567a4b4%40djangoproject.com.

[Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
-+
   Reporter:  thenewguy  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  2.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 It would minimize configuration for new projects if ALLOWED_HOSTS +=
 ['.localhost'] when DEBUG=True

 Chrome resolves *.localhost to localhost without modifying any host files
 or DNS

 Referencing the project this way makes it easy to test subdomains ->
 static.localhost, uploads.localhost, www.localhost, etc

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.9d5c962682ed8d3dcc4183ea959b5e11%40djangoproject.com.