Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+-
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  closed
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9756c334294ad573d887b449e2fe1cc87387af40" 9756c334]:
 {{{
 #!CommitTicketReference repository=""
 revision="9756c334294ad573d887b449e2fe1cc87387af40"
 Fixed #31504 -- Allowed calling makemigrations without an active database
 connection.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.4430089e015d758e8d8a6fdd79ebb1ad%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+-
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.93b90eaa4b484c22f6578f6b4f0b268a%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by wtkm11):

 I just updated the PR again so that a warning describing the error that
 was encountered in check_consistent_history will be issued (and the
 command will be able to continue).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.66342c9bdadc2b2ee96e52029f1302c4%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by wtkm11):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.71d17fbdfbebb76d0bc831dfb6895d85%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+

Comment (by wtkm11):

 I updated the PR so that a CommandError describing the error that was
 encountered in check_consistent_history will be raised.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.c9c4e459cec74241f14c58e33294b699%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+
Changes (by felixxm):

 * needs_better_patch:  0 => 1


Comment:

 I agree with Tom, this is quite niche so I would also prefer to fail
 gracefully. IMO we don't need a new option.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.e4dd3b7d3bf384b97f4b87310e4b109a%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by Tom Forbes):

 I've been thinking more about this - wouldn't it be preferable to
 gracefully fail if the `check_consistent_history()` method fails due to a
 connection error? Not sure what anyone else thinks, but your MR looks
 simple enough. Just make sure you add something to the release notes +
 documentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.baec0e4595623b679ca5370f80f71c29%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by wtkm11):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/12796

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.e2b9107824b9e9c6a6e023ef8c893b3d%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by wtkm11):

 I added the --skip-consistency-check flag to allow skipping the
 inconsistent migration history check in the makemigrations command along
 with a unit test in tests.migrations.test_commands::MakeMigrationsTests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.81351daf38eb0005da43794a627b4187%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by wtkm11):

 * owner:  nobody => wtkm11
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.34bd095c870b832c4c83ea1b4d6cb62c%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 OK, this seems reasonable to me. (Others can shout if I missed something.
 :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.88920d70c2de10385ff60f2a4664eb5d%40djangoproject.com.

Re: [Django] #31504: Allow makemigrations to skip database consistency checks

[Django]

#31504: Allow makemigrations to skip database consistency checks
-+--
 Reporter:  Tom Forbes   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Changes (by Ian Bottomley):

 * cc: Ian Bottomley (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.5269fed884193546951e26392b92e7df%40djangoproject.com.