Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  closed => new
 * has_patch:  1 => 0
 * resolution:  fixed =>
 * stage:  Ready for checkin => Accepted


Comment:

 Reverted in 2ee01747c32a7275a7a1a5f7862acba7db764921.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701884720ad56-75b47710-844d-4387-9687-1b2581035a99-00%40eu-central-1.amazonses.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"57f499e412c7c28b4a1f1b740468bf6eabbdb695" 57f499e4]:
 {{{
 #!CommitTicketReference repository=""
 revision="57f499e412c7c28b4a1f1b740468bf6eabbdb695"
 [4.2.x] Refs #34551 -- Fixed QuerySet.aggregate() crash on precending
 aggregation reference.

 Regression in 1297c0d0d76a708017fe196b61a0ab324df76954.

 Refs #31679.

 Backport of 2ee01747c32a7275a7a1a5f7862acba7db764921 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188471fc0a6-d4e46f47-44b7-4d50-a1b7-f605d15c8450-00%40eu-central-1.amazonses.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"2ee01747c32a7275a7a1a5f7862acba7db764921" 2ee0174]:
 {{{
 #!CommitTicketReference repository=""
 revision="2ee01747c32a7275a7a1a5f7862acba7db764921"
 Refs #34551 -- Fixed QuerySet.aggregate() crash on precending aggregation
 reference.

 Regression in 1297c0d0d76a708017fe196b61a0ab324df76954.

 Refs #31679.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188471ee2ea-fd9e1130-af80-421a-a63a-f537ff1de2b0-00%40eu-central-1.amazonses.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"1297c0d0d76a708017fe196b61a0ab324df76954" 1297c0d]:
 {{{
 #!CommitTicketReference repository=""
 revision="1297c0d0d76a708017fe196b61a0ab324df76954"
 Fixed #31679 -- Delayed annotating aggregations.

 By avoiding to annotate aggregations meant to be possibly pushed to an
 outer query until their references are resolved it is possible to
 aggregate over a query with the same alias.

 Even if #34176 is a convoluted case to support, this refactor seems
 worth it given the reduction in complexity it brings with regards to
 annotation removal when performing a subquery pushdown.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a5a5e45b-0804ef13-e758-4a44-9464-41cf556fcbd7-00%40eu-central-1.amazonses.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a471e6c3-ce92c007-98c1-4863-a04d-1db6c4331c64-00%40eu-central-1.amazonses.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * owner:  (none) => Simon Charette
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a2bb78ea-74b3bd92-fd11-4095-a4a2-481eac313821-00%40eu-central-1.amazonses.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a29ecb43-c7c69e38-dc70-4866-b6f2-22ff52771804-00%40eu-central-1.amazonses.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jonny Park):

 * owner:  Jonny Park => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.6403a10e6b93a92d71785199d92fd2a2%40djangoproject.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  Jonny
 |  Park
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jonny Park):

 * owner:  (none) => Jonny Park
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.c4a38ae23ce6892eb6ba649a380da8ed%40djangoproject.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.295e9adf8be3703671b6f23e466b018a%40djangoproject.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Kristijan Mitrovic):

 > {{{#!python
 >   Model.objects.annotate(foo=F('column')).aggregate(foo=Sum(F('foo')))
 >   }}}

 So in the example above, where both annotated and aggregated kwargs are
 named `foo`, the output should actually contain just the last one, right?
 The first annotated `foo` column can just be renamed and then removed from
 the final result (to avoid confusion). That would be accesptable solution
 without large rewriting of the code I hope.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.f285c6e948a9ed47e26a50cdc6265f58%40djangoproject.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Herbert Poul):

 Is this the same as https://code.djangoproject.com/ticket/31880 (which was
 fixed by https://github.com/django/django/pull/13431 )?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.64bc0cdbaa342e34bf1da7f1994b8cfe%40djangoproject.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * owner:  Jacob Walls => (none)
 * status:  assigned => new
 * has_patch:  1 => 0


Comment:

 Unassigning myself because the attached patch was too restrictive.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.84964710104954e15e6b0344c6b98beb%40djangoproject.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  Jacob
 |  Walls
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1
 * easy:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.8e252fb267b4b1976b62b73719023581%40djangoproject.com.

Re: [Django] #31679: Django subtly produces incorrect query when the same keyword appears in both aggregate() and annotate()

[Django]

#31679: Django subtly produces incorrect query when the same keyword appears in
both aggregate() and annotate()
-+-
 Reporter:  StefanosChaliasos|Owner:  Jacob
 |  Walls
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/13273 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.7e3e34fa1687d69028fac5696fa94fc3%40djangoproject.com.