Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
-+-
 Reporter:  Antoine Humbert  |Owner:  Antoine
 |  Humbert
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  admin hidden field   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"de95c826673be9ea519acc86fd898631d1a11356" de95c826]:
 {{{
 #!CommitTicketReference repository=""
 revision="de95c826673be9ea519acc86fd898631d1a11356"
 Fixed #31867 -- Made TabularInline handling of hidden fields with view-
 only permissions consistent with StackedInline.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.d48fb5406403aecffe14a5bcb9828824%40djangoproject.com.

Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
-+-
 Reporter:  Antoine Humbert  |Owner:  Antoine
 |  Humbert
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  admin hidden field   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.4cf66b289f464f2c08d826ce859da296%40djangoproject.com.

Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
-+-
 Reporter:  Antoine Humbert  |Owner:  Antoine
 |  Humbert
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  admin hidden field   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0


Comment:

 Author made requested updates.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.4c9290a954fd826579550f9e6d663142%40djangoproject.com.

Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
-+-
 Reporter:  Antoine Humbert  |Owner:  Antoine
 |  Humbert
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  admin hidden field   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


Comment:

 I've asked for a bit of tidy-up on the PR, but looks OK otherwise. Marking
 with ''Patch needs improvement'' — please uncheck that when adjustments
 are made so we can take another look. Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bbb3195ef845a1503e3d4acf294510c6%40djangoproject.com.

Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
-+-
 Reporter:  Antoine Humbert  |Owner:  Antoine
 |  Humbert
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  admin hidden field   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson):

 * needs_tests:  1 => 0


Comment:

 Updates on the PR, unchecking needs tests for another review.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bc17a267407c3c18b4198b255a37f1c3%40djangoproject.com.

Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
-+-
 Reporter:  Antoine Humbert  |Owner:  Antoine
 |  Humbert
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  admin hidden field   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.31a63190651856a23e1242ada3adec58%40djangoproject.com.

Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
-+-
 Reporter:  Antoine Humbert  |Owner:  Antoine
 |  Humbert
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  admin hidden field   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Antoine Humbert):

 * has_patch:  0 => 1


Comment:

 See [https://github.com/django/django/pull/13299 PR] for master branch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.6b90732238cb0141ff8d871cc46a8513%40djangoproject.com.

Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
-+-
 Reporter:  Antoine Humbert  |Owner:  Antoine
 |  Humbert
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  admin hidden field   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Antoine Humbert):

 * owner:  nobody => Antoine Humbert
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.7ae97bfce7449eaba9021ee90ec0b87c%40djangoproject.com.

Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
+
 Reporter:  Antoine Humbert |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  2.1
 Severity:  Normal  |   Resolution:
 Keywords:  admin hidden field  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+

Comment (by Antoine Humbert):

 I'll try to provide a PR solving this issue. What should be the starting
 commit for the patch ? May I start from the least 2.1 branch or from
 develop branch ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.e1ff708f615b1802f3b999c14e9c2660%40djangoproject.com.

Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin (was: Inconsistency in rendering hidden fields in Django admin)

[Django]

#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
+
 Reporter:  Antoine Humbert |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  2.1
 Severity:  Normal  |   Resolution:
 Keywords:  admin hidden field  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Changes (by Carlton Gibson):

 * has_patch:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 Hi Antoine. Thanks for the report — there's certainly an inconsistency
 there. The tabular case is easiest to reproduce.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b252d0f6d665fd07d0cba0c391c5622e%40djangoproject.com.