Re: [Django] #31941: FileField with a callable storage does not deconstruct properly

[Django]

#31941: FileField with a callable storage does not deconstruct properly
-+-
 Reporter:  Brian Helba  |Owner:  Brian
 |  Helba
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  3.1
  uploads/storage|
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson ):

 In [changeset:"c69c6886def1fc81a6d96d1474b58a435a38c23b" c69c6886]:
 {{{
 #!CommitTicketReference repository=""
 revision="c69c6886def1fc81a6d96d1474b58a435a38c23b"
 [3.1.x] Fixed #31941 -- Corrected FileField.deconstruct() with a callable
 storage.

 Backport of 2d42e23b6d8fd76f93a96b2310b2c9dfd441d009 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9c28f6a10b17cb856534be8b9228c0ca%40djangoproject.com.

Re: [Django] #31941: FileField with a callable storage does not deconstruct properly

[Django]

#31941: FileField with a callable storage does not deconstruct properly
-+-
 Reporter:  Brian Helba  |Owner:  Brian
 |  Helba
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  3.1
  uploads/storage|
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2d42e23b6d8fd76f93a96b2310b2c9dfd441d009" 2d42e23b]:
 {{{
 #!CommitTicketReference repository=""
 revision="2d42e23b6d8fd76f93a96b2310b2c9dfd441d009"
 Fixed #31941 -- Corrected FileField.deconstruct() with a callable storage.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.84f86c642c9402a0be8b67b304bc3815%40djangoproject.com.

Re: [Django] #31941: FileField with a callable storage does not deconstruct properly

[Django]

#31941: FileField with a callable storage does not deconstruct properly
-+-
 Reporter:  Brian Helba  |Owner:  Brian
 |  Helba
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  3.1
  uploads/storage|
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.46cbff5c78f5e6c2671f48d955da8d2d%40djangoproject.com.

Re: [Django] #31941: FileField with a callable storage does not deconstruct properly

[Django]

#31941: FileField with a callable storage does not deconstruct properly
-+-
 Reporter:  Brian Helba  |Owner:  Brian
 |  Helba
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  3.1
  uploads/storage|
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * type:  Uncategorized => Bug
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Hi Brian. Thanks for the report.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.0cddf7bd4868f3276f4550825eff3af0%40djangoproject.com.

Re: [Django] #31941: FileField with a callable storage does not deconstruct properly

[Django]

#31941: FileField with a callable storage does not deconstruct properly
-+-
 Reporter:  Brian Helba  |Owner:  Brian
 |  Helba
 Type:  Uncategorized|   Status:  assigned
Component:  File |  Version:  3.1
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Brian Helba):

 Here is a PR fixing the issue: https://github.com/django/django/pull/13343

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e84d3b3f0b41e616003bbc4b4ff339c3%40djangoproject.com.

Re: [Django] #31941: FileField with a callable storage does not deconstruct properly

[Django]

#31941: FileField with a callable storage does not deconstruct properly
-+-
 Reporter:  Brian Helba  |Owner:  Brian
 |  Helba
 Type:  Uncategorized|   Status:  assigned
Component:  File |  Version:  3.1
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Brian Helba):

 * owner:  nobody => Brian Helba
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.29abbcdc7d554526013521d337b046fc%40djangoproject.com.

[Django] #31941: FileField with a callable storage does not deconstruct properly

[Django]

#31941: FileField with a callable storage does not deconstruct properly
+
   Reporter:  Brian Helba   |  Owner:  nobody
   Type:  Uncategorized | Status:  new
  Component:  File uploads/storage  |Version:  3.1
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 A FileField with a callable `storage` parameter should not actually
 evaluate the callable when it is being deconstructed.

 The documentation for a FileField with a callable `storage` parameter,
 states:

 > You can use a callable as the `storage` parameter for
 `django.db.models.FileField` or `django.db.models.ImageField`. This allows
 you to modify the used storage at runtime, selecting different storages
 for different environments, for example.

 However, by evaluating the callable during deconstuction, the assumption
 that the Storage may vary at runtime is broken. Instead, when the
 FileField is deconstructed (which happens during `makemigrations`), the
 actual evaluated Storage is inlined into the deconstucted FileField.

 The correct behavior should be to return a reference to the original
 callable during deconstruction. Note that a FileField with a callable
 `upload_to` parameter already behaves this way: the deconstructed value is
 simply a reference to the callable.

 ---

 This bug was introduced in the initial implementation which allowed the
 `storage` parameter to be callable:
 https://github.com/django/django/pull/8477 , which fixed the ticket
 https://code.djangoproject.com/ticket/28184

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.c1d45bfbe49cf85e1867f47f84db792a%40djangoproject.com.