Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.9f37c3e0e693568e6ff2ed515e9d3ba8%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"3828427f634e1880467689e4cf0f8ffee95f0d05" 3828427f]:
 {{{
 #!CommitTicketReference repository=""
 revision="3828427f634e1880467689e4cf0f8ffee95f0d05"
 Refs #31978 -- Fixed hint in admin's password reset confirmation form for
 custom username fields.

 Thanks Jaap Roes for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.843fc52d1f6a5b4a9b5103c3430fb4d0%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0


Comment:

 [https://github.com/django/django/pull/13730 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.5115a395cf4fe2918785cb8f0b4983f3%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  Collin Anderson => Mariusz Felisiak
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.28f6a2a3066a591b7cf5c759e54b69b0%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Collin
 |  Anderson
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Collin Anderson):

 * type:  Cleanup/optimization => Bug
 * stage:  Ready for checkin => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b9fb51255441f1d595671320c2a00e83%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Collin
 Type:   |  Anderson
  Cleanup/optimization   |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Collin Anderson):

 * status:  closed => new
 * needs_better_patch:  0 => 1
 * resolution:  fixed =>
 * severity:  Normal => Release blocker


Comment:

 My bad. That sounds right, this will break for anyone who has a custom
 USERNAME_FIELD.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.6cfa1d47a1cbcd3683c0a14cc062edc0%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Collin
 Type:   |  Anderson
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jaap Roes):

 I just came across this by chance and noticed that `` is used
 in the template. Shouldn't `form.user.get_username` be used here? In my
 custom `User` model the username field is ommited, only `email` exists,
 and `User.USERNAME_FIELD` is set to `email`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.5eb6edf046451d6552dd42aa05367216%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Collin
 Type:   |  Anderson
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"daa26acc4e7f134e064c5a6abe4d335f6fa8b249" daa26ac]:
 {{{
 #!CommitTicketReference repository=""
 revision="daa26acc4e7f134e064c5a6abe4d335f6fa8b249"
 Fixed #31978 -- Added username hint to admin's password reset confirmation
 form.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.c03f92f06570e5d3e3bdbd54b67f26d9%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Collin
 Type:   |  Anderson
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.9c6ce643878bc0372d9d958ae4149ec4%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+-
 Reporter:  Collin Anderson  |Owner:  Collin
 Type:   |  Anderson
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => assigned
 * component:  contrib.auth => contrib.admin
 * needs_tests:  0 => 1
 * owner:  nobody => Collin Anderson
 * type:  New feature => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Sounds reasonable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b758be205bd1c493dadee24b552d6de4%40djangoproject.com.

Re: [Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
-+--
 Reporter:  Collin Anderson  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by Collin Anderson):

 * cc: Collin Anderson (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.434a6f8ae77d0e57c98defd7295b%40djangoproject.com.

[Django] #31978: Include hidden username field on password reset to help password managers

[Django]

#31978: Include hidden username field on password reset to help password 
managers
---+
   Reporter:  Collin Anderson  |  Owner:  nobody
   Type:  New feature  | Status:  new
  Component:  contrib.auth |Version:  master
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  1
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 Include hidden username field on password reset to help password managers

 https://github.com/django/django/pull/13327

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.fc961da8898a8a6e336afd23509fada0%40djangoproject.com.