Re: [Django] #32139: Add check, that raise TemplateException, when argument 'only' provided more then once in tag 'include'

[Django]

#32139: Add check, that raise TemplateException, when argument 'only' provided 
more
then once in tag 'include'
-+-
 Reporter:  Mikhail Fesenko  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 |  worksforme
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Mikhail Fesenko:

Old description:

> V

New description:

 https://github.com/django/django/pull/13597

 I've added code with this fix, and test for it

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3e604669f84bd2e783710f821695485f%40djangoproject.com.

Re: [Django] #32139: Add check, that raise TemplateException, when argument 'only' provided more then once in tag 'include'

[Django]

#32139: Add check, that raise TemplateException, when argument 'only' provided 
more
then once in tag 'include'
-+-
 Reporter:  Mikhail Fesenko  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 |  worksforme
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Old description:

> https://github.com/django/django/pull/13597
>
> I've added code with this fix, and test for it

New description:

 V

--

Comment (by Mikhail Fesenko):

 Wow, I made a mistake =(
 Idk why, when I did this patch, I thought that if option in options: was
 only for 'with' param, idk why

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6d3b1259ce49a6cfedce1690a8f5%40djangoproject.com.

Re: [Django] #32139: Add check, that raise TemplateException, when argument 'only' provided more then once in tag 'include'

[Django]

#32139: Add check, that raise TemplateException, when argument 'only' provided 
more
then once in tag 'include'
-+-
 Reporter:  Mikhail Fesenko  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 |  worksforme
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 Hi Mikhail, thanks for this contribution, but the test you submitted
 passes without your patch. Further, I don't see how your patch would
 execute since `if option in options` raises an exception a few lines
 above. Finally, and for the same reason, I don't think the test you
 provided meaningfully increases coverage since there are test methods
 `test_variable_twice()` and `test_syntax_error_duplicate_option()` that
 already test this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.88c09809e8c286db1248a82e7c0ec80c%40djangoproject.com.

Re: [Django] #32139: Add check, that raise TemplateException, when argument 'only' provided more then once in tag 'include'

[Django]

#32139: Add check, that raise TemplateException, when argument 'only' provided 
more
then once in tag 'include'
-+-
 Reporter:  Mikhail Fesenko  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * type:  Uncategorized => Cleanup/optimization


Old description:

> https://github.com/django/django/pull/13492
>
> I've added code with this fix, and test for it

New description:

 https://github.com/django/django/pull/13597

 I've added code with this fix, and test for it

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1a56a5ececbaca13877837fa11e03359%40djangoproject.com.

[Django] #32139: Add check, that raise TemplateException, when argument 'only' provided more then once in tag 'include'

[Django]

#32139: Add check, that raise TemplateException, when argument 'only' provided 
more
then once in tag 'include'
---+
   Reporter:  Mikhail Fesenko  |  Owner:  nobody
   Type:  Uncategorized| Status:  new
  Component:  Template system  |Version:  master
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 https://github.com/django/django/pull/13492

 I've added code with this fix, and test for it

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.d1ac942f28dee07d041c858bdb6fa924%40djangoproject.com.