Re: [Django] #32808: DiscoverRunner.build_suite() does not restore self.test_loader.testNamePatterns

[Django]

#32808: DiscoverRunner.build_suite() does not restore
self.test_loader.testNamePatterns
-+-
 Reporter:  Chris Jerdonek   |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  3.2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"62e8f369c3bdb7dbfe76d128437c0a9c0715a067" 62e8f369]:
 {{{
 #!CommitTicketReference repository=""
 revision="62e8f369c3bdb7dbfe76d128437c0a9c0715a067"
 Fixed #32808 -- Prevented DiscoverRunner.build_suite() from mutating test
 loader patterns.

 Thanks Chris Jerdonek for the report and reviews.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.53c82f009a346cc394e75b7809e0735a%40djangoproject.com.

Re: [Django] #32808: DiscoverRunner.build_suite() does not restore self.test_loader.testNamePatterns

[Django]

#32808: DiscoverRunner.build_suite() does not restore
self.test_loader.testNamePatterns
-+-
 Reporter:  Chris Jerdonek   |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/14478 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.da5c4cef419c3e2b2a78e23c30cf298a%40djangoproject.com.

Re: [Django] #32808: DiscoverRunner.build_suite() does not restore self.test_loader.testNamePatterns

[Django]

#32808: DiscoverRunner.build_suite() does not restore
self.test_loader.testNamePatterns
-+-
 Reporter:  Chris Jerdonek   |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Mariusz Felisiak
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e38d44221ad692b57affec8995ee9b37%40djangoproject.com.

Re: [Django] #32808: DiscoverRunner.build_suite() does not restore self.test_loader.testNamePatterns

[Django]

#32808: DiscoverRunner.build_suite() does not restore
self.test_loader.testNamePatterns
---+
 Reporter:  Chris Jerdonek |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  3.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Chris Jerdonek):

 Thanks! Yes, or even smaller--

 {{{
 $ ./runtests.py
 test_runner.test_discover_runner.DiscoverRunnerTests.test_name_patterns
 test_runner.tests.TestSuiteTests.test_iter_test_cases_mixed_test_suite_classes
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f3efaa821a07a4f3901bd466ef060e3f%40djangoproject.com.

Re: [Django] #32808: DiscoverRunner.build_suite() does not restore self.test_loader.testNamePatterns

[Django]

#32808: DiscoverRunner.build_suite() does not restore
self.test_loader.testNamePatterns
---+
 Reporter:  Chris Jerdonek |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  3.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 Good catch! A minimal set of tests to reproduce:
 {{{
 ./runtests.py
 test_runner.test_discover_runner.DiscoverRunnerTests.test_name_patterns
 test_runner.tests.TestSuiteTests --parallel=1
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1ef0086af4df43fd1db97d8e83a5a640%40djangoproject.com.

[Django] #32808: DiscoverRunner.build_suite() does not restore self.test_loader.testNamePatterns

[Django]

#32808: DiscoverRunner.build_suite() does not restore
self.test_loader.testNamePatterns
-+
   Reporter:  Chris Jerdonek |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Testing framework  |Version:  3.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 `DiscoverRunner.build_suite()` does not restore
 `self.test_loader.testNamePatterns` after setting it in this line:
 
https://github.com/django/django/blob/e703b152c6148ddda1b072a4353e9a41dca87f90/django/test/runner.py#L639

 I noticed this issue when finding a test isolation issue while working on
 #24522. The test
 `test_runner.test_discover_runner.DiscoverRunnerTests.test_name_patterns`
 passes `test_name_patterns` to `DiscoverRunner`:
 
https://github.com/django/django/blob/e703b152c6148ddda1b072a4353e9a41dca87f90/tests/test_runner/test_discover_runner.py#L119-L122

 And this causes some later tests to fail.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.9ca10d55fc8369dd994f8cc25a97ba93%40djangoproject.com.