Re: [Django] #32818: Add pyproject.toml config for black formatter

[Django]

#32818: Add pyproject.toml config for black formatter
-+-
 Reporter:  Cooper Lees  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 I really don't understand why this needs to be added to Django. You should
 be able to add a black configurations to your CI.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8a1a746ad368f2696fd8f84e03de7c47%40djangoproject.com.

Re: [Django] #32818: Add pyproject.toml config for black formatter

[Django]

#32818: Add pyproject.toml config for black formatter
-+-
 Reporter:  cooperlees   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Chris Jerdonek):

 I'm not for or against the idea, but out of curiosity, why wouldn't it be
 easier for you to keep the file in your own repo? That way you wouldn't
 need to file a PR anytime you wanted to make changes to the file. Is it
 because the file could potentially be different in multiple versions of
 Django, and you wouldn't want to have to store multiple versions of the
 file?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f581eb027b163d4031c3a6f562bcd6ef%40djangoproject.com.

[Django] #32818: Add pyproject.toml config for black formatter

[Django]

#32818: Add pyproject.toml config for black formatter
+
   Reporter:  cooperlees|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Utilities |Version:  dev
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Hi,

 I'm a maintainer of black (https://github.com/psf/black), a python code
 formatter. I know Django does not use black, but we selected to add it to
 our CI to test formatting a decent amount of files (~1900) that have
 formatting changes to try and find bugs when we make changes.

 You have some test files and docs generation files that we'd like to
 exclude. The test files have syntax errors on purpose it seems. The config
 should effect nothing the Django project cares about.

 I've done the PR and it's here:
 https://github.com/django/django/pull/14488

 (sorry if this is spammy and a waste of a ticket, but it was suggested I
 do so on the PR)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.b594058aee0b4ee0316c002e97ddd201%40djangoproject.com.