Re: [Django] #32905: Add `nonform` CSS class for non form errors in FormSets

[Django]

#32905: Add `nonform` CSS class for non form errors in FormSets
-+-
 Reporter:  Ties Jan Hefting |Owner:  Ties Jan
 |  Hefting
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"84400d2e9db7c51fee4e9bb04c028f665b8e7624" 84400d2e]:
 {{{
 #!CommitTicketReference repository=""
 revision="84400d2e9db7c51fee4e9bb04c028f665b8e7624"
 Fixed #32905 -- Added CSS class for non-form errors of formsets.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6cf1aef9ff5d48590c4e2e4f52b5290f%40djangoproject.com.

Re: [Django] #32905: Add `nonform` CSS class for non form errors in FormSets

[Django]

#32905: Add `nonform` CSS class for non form errors in FormSets
-+-
 Reporter:  Ties Jan Hefting |Owner:  Ties Jan
 |  Hefting
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.10f219ae7bf60096765513b23056c874%40djangoproject.com.

Re: [Django] #32905: Add `nonform` CSS class for non form errors in FormSets

[Django]

#32905: Add `nonform` CSS class for non form errors in FormSets
-+-
 Reporter:  Ties Jan Hefting |Owner:  Ties Jan
 |  Hefting
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ties Jan Hefting):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.16dd0fc9a5b537385d76b9adc332b733%40djangoproject.com.

Re: [Django] #32905: Add `nonform` CSS class for non form errors in FormSets

[Django]

#32905: Add `nonform` CSS class for non form errors in FormSets
-+-
 Reporter:  Ties Jan Hefting |Owner:  Ties Jan
 |  Hefting
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.08236020b01eb63c68cfd3f9c8e7a9d5%40djangoproject.com.

Re: [Django] #32905: Add `nonform` CSS class for non form errors in FormSets

[Django]

#32905: Add `nonform` CSS class for non form errors in FormSets
-+-
 Reporter:  Ties Jan Hefting |Owner:  Ties Jan
 |  Hefting
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ties Jan Hefting):

 * has_patch:  0 => 1


Old description:

> Forms add the `nonfield` CSS class for non field errors in ErrorClass
> instances. This is documented in a section on
> [https://docs.djangoproject.com/en/dev/topics/forms/#rendering-form-
> error-messages rendering form error messages]. Similarly, in FormSets I'd
> expect to see the `nonform` CSS class added for non form errors. This
> would allow a custom ErrorClass to make a distinction in form field
> errors, non field errors (forms) and non form errors (FormSets) when
> rendering error messages. Therefore I'd suggest to add this `nonform` CSS
> class and document it for developers to use.

New description:

 Forms add the `nonfield` CSS class for non field errors in ErrorList
 instances. This is documented in a section on
 [https://docs.djangoproject.com/en/dev/topics/forms/#rendering-form-error-
 messages rendering form error messages]. Similarly, in FormSets I'd expect
 to see the `nonform` CSS class added for non form errors. This would allow
 a custom ErrorList to make a distinction in form field errors, non field
 errors (forms) and non form errors (FormSets) when rendering error
 messages. Therefore I'd suggest to add this `nonform` CSS class and
 document it for developers to use.

--

Comment:

 [https://github.com/django/django/pull/14608 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.787dfffc0c4b64014824b630103593fd%40djangoproject.com.

Re: [Django] #32905: Add `nonform` CSS class for non form errors in FormSets

[Django]

#32905: Add `nonform` CSS class for non form errors in FormSets
-+-
 Reporter:  Ties Jan Hefting |Owner:  Ties Jan
 |  Hefting
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * type:  Cleanup/optimization => New feature
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 Seems reasonable (similar to #11776).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.553d0a334e845c496ca3290e84694bb4%40djangoproject.com.

Re: [Django] #32905: Add `nonform` CSS class for non form errors in FormSets

[Django]

#32905: Add `nonform` CSS class for non form errors in FormSets
-+-
 Reporter:  Ties Jan Hefting |Owner:  Ties Jan
 Type:   |  Hefting
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Ties Jan Hefting):

 * owner:  nobody => Ties Jan Hefting


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3e2e44ca488fbdfc39e513d7a5a13fab%40djangoproject.com.

[Django] #32905: Add `nonform` CSS class for non form errors in FormSets

[Django]

#32905: Add `nonform` CSS class for non form errors in FormSets
+--
   Reporter:  Ties Jan Hefting  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  assigned
  Component:  Forms |Version:  dev
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+--
 Forms add the `nonfield` CSS class for non field errors in ErrorClass
 instances. This is documented in a section on
 [https://docs.djangoproject.com/en/dev/topics/forms/#rendering-form-error-
 messages rendering form error messages]. Similarly, in FormSets I'd expect
 to see the `nonform` CSS class added for non form errors. This would allow
 a custom ErrorClass to make a distinction in form field errors, non field
 errors (forms) and non form errors (FormSets) when rendering error
 messages. Therefore I'd suggest to add this `nonform` CSS class and
 document it for developers to use.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.e6065d94937dccd395dfd080c63bef78%40djangoproject.com.