Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:
 |  Hrushikesh Vaidya
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Alex Vandiver):

 Understood.  Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4a3feeb0f5ce98dc09ff5fb0fe93a38d%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:
 |  Hrushikesh Vaidya
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:11 Alex Vandiver]:
 > Thanks for the fix!  Do you intend to backport this to the 3.2 LTS
 series?

 The issue has been present since the feature was introduced. Per our
 backporting policy this means it doesn't qualify for a backport to 3.2.x
 or 4.0.x anymore. See [https://docs.djangoproject.com/en/stable/internals
 /release-process/ Django’s release process] for more details.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.30bee849f4c18ba7c23cd5470927fb01%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:
 |  Hrushikesh Vaidya
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Alex Vandiver):

 Thanks for the fix!  Do you intend to backport this to the 3.2 LTS series?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8ce128043571f76e7e22912e3226ff93%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:
 |  Hrushikesh Vaidya
 Type:  Bug  |   Status:  closed
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"3fadf141e66c8d0baaa66574fa3b63c4d3655482" 3fadf141]:
 {{{
 #!CommitTicketReference repository=""
 revision="3fadf141e66c8d0baaa66574fa3b63c4d3655482"
 Fixed #33062 -- Made MultiPartParser remove non-printable chars from file
 names.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fb898b9e458e18a39163465f0f76a323%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:
 |  Hrushikesh Vaidya
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bacb46bbc9a81dc10f2cae5a340c6cba%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:
 |  Hrushikesh Vaidya
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Hrushikesh Vaidya):

 [https://github.com/django/django/pull/15324 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.02402999bd3fc6ab53f60c6e28a278f2%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:
 |  Hrushikesh Vaidya
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Hrushikesh Vaidya):

 * owner:  Vishal Pandey => Hrushikesh Vaidya
 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ca3a9df9e13fcecf15c277683d4e561e%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:  Vishal
 |  Pandey
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Vishal Pandey):

 * owner:  (none) => Vishal Pandey
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.50f4f18cbdf8733dba2967d68d5146ce%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
--+
 Reporter:  Alex Vandiver |Owner:  (none)
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  3.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * owner:  Ased mammad => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a59fc519b93eb15fedaf804c053b9ee4%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:  Ased
 |  mammad
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/14834 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1de555dbac61f35c09f07325ad02f88e%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters.

[Django]

#33062: File upload crash when a file extension contains null characters.
-+-
 Reporter:  Alex Vandiver|Owner:  Ased
 |  mammad
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  3.2
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ased mammad):

 * owner:  nobody => Ased mammad
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4791a1626af6a25f482f84578f38dd58%40djangoproject.com.

Re: [Django] #33062: File upload crash when a file extension contains null characters. (was: Null byte in uploaded filename extension is not cleaned up, results in exception)

[Django]

#33062: File upload crash when a file extension contains null characters.
--+
 Reporter:  Alex Vandiver |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  File uploads/storage  |  Version:  3.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * cc: Florian Apolloner (added)
 * component:  Forms => File uploads/storage
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the detailed report! I'd remove null characters in
 `MultiPartParser.sanitize_file_name()`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.28e82849ceaa87c89f8a577d7eefc635%40djangoproject.com.