Re: [Django] #33114: StringAgg() should set output_field to TextField.

[Django]

#33114: StringAgg() should set output_field to TextField.
-+-
 Reporter:  Swen Kooij   |Owner:  ali
 Type:   |  sayyah
  Cleanup/optimization   |   Status:  closed
Component:  contrib.postgres |  Version:  3.2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ca583783900d98188c488add21f77702a94a7922" ca583783]:
 {{{
 #!CommitTicketReference repository=""
 revision="ca583783900d98188c488add21f77702a94a7922"
 Fixed #33114 -- Defined default output_field of StringAgg.

 Thanks Simon Charette for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f22ef2f1f89709cb719884f001a6bb08%40djangoproject.com.

Re: [Django] #33114: StringAgg() should set output_field to TextField.

[Django]

#33114: StringAgg() should set output_field to TextField.
-+-
 Reporter:  Swen Kooij   |Owner:  ali
 Type:   |  sayyah
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.postgres |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6f57c52859c2c02dc81cf33945b99ebd%40djangoproject.com.

Re: [Django] #33114: StringAgg() should set output_field to TextField.

[Django]

#33114: StringAgg() should set output_field to TextField.
-+-
 Reporter:  Swen Kooij   |Owner:  ali
 Type:   |  sayyah
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.postgres |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ali sayyah):

 PR with the fix and a unittest:
 [https://github.com/django/django/pull/14898]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.051431749e5a8b46de667a210a80770e%40djangoproject.com.

Re: [Django] #33114: StringAgg() should set output_field to TextField.

[Django]

#33114: StringAgg() should set output_field to TextField.
-+-
 Reporter:  Swen Kooij   |Owner:  ali
 Type:   |  sayyah
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.postgres |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ali sayyah):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7d833160270c88c8d819b220c89f89bc%40djangoproject.com.

Re: [Django] #33114: StringAgg() should set output_field to TextField.

[Django]

#33114: StringAgg() should set output_field to TextField.
-+-
 Reporter:  Swen Kooij   |Owner:  ali
 Type:   |  sayyah
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.postgres |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ali sayyah):

 Replying to [comment:8 Claude Paroz]:
 > main branch (which will target 4.1, now that 4.0 is feature frozen).
 Thank you.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.99a72e8baeb3521c8588b8db5098fb01%40djangoproject.com.

Re: [Django] #33114: StringAgg() should set output_field to TextField.

[Django]

#33114: StringAgg() should set output_field to TextField.
-+-
 Reporter:  Swen Kooij   |Owner:  ali
 Type:   |  sayyah
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.postgres |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 main branch (which will target 4.1, now that 4.0 is feature frozen).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.48ce83eb526b60e24dd15ca774023523%40djangoproject.com.

Re: [Django] #33114: StringAgg() should set output_field to TextField.

[Django]

#33114: StringAgg() should set output_field to TextField.
-+-
 Reporter:  Swen Kooij   |Owner:  ali
 Type:   |  sayyah
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.postgres |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ali sayyah):

 Should I make the patch for 3.2 or the main branch?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0c571ea9cb5c9423edf1894b62bcc2f1%40djangoproject.com.

Re: [Django] #33114: StringAgg() should set output_field to TextField.

[Django]

#33114: StringAgg() should set output_field to TextField.
-+-
 Reporter:  Swen Kooij   |Owner:  ali
 Type:   |  sayyah
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.postgres |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ali sayyah):

 * owner:  nobody => ali sayyah
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.731f8c8cf5a607f2d3ab1045e12d26fa%40djangoproject.com.

Re: [Django] #33114: StringAgg() should set output_field to TextField.

[Django]

#33114: StringAgg() should set output_field to TextField.
--+
 Reporter:  Swen Kooij|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.postgres  |  Version:  3.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * component:  Database layer (models, ORM) => contrib.postgres


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f72caf1f2db7f0f52fe7a2b9c3bd0804%40djangoproject.com.

Re: [Django] #33114: StringAgg() should set output_field to TextField. (was: StringAgg always fails on TextField)

[Django]

#33114: StringAgg() should set output_field to TextField.
-+-
 Reporter:  Swen Kooij   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Replying to [comment:3 Simon Charette]:
 > This will be an issue for all expressions that accept mixed string
 types.
 >
 > Since PostgreSQL [https://www.postgresql.org/docs/current/functions-
 aggregate.html documents] that `string_agg ( value text, delimiter text )
 → text` I guess we should default to `output_field = models.TextField()`
 to limit this annoyance.

 OK, agreed. Swen, would you like to prepare a patch (with tests)?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.796858cab24d670787d5911292434c74%40djangoproject.com.