Re: [Django] #33662: Choose which items are displayed per language in Sitemap

[Django]

#33662: Choose which items are displayed per language in Sitemap
-+-
 Reporter:  Roxane   |Owner:  Roxane
 Type:  New feature  |   Status:  closed
Component:  contrib.sitemaps |  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sitemap  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"88f23b6b8158d3830589dce8787677cdb7d33404" 88f23b6b]:
 {{{
 #!CommitTicketReference repository=""
 revision="88f23b6b8158d3830589dce8787677cdb7d33404"
 [4.2.x] Refs #33662 -- Corrected Sitemap.get_languages_for_item()
 signature in docs.

 Backport of 5c456a879300e5f51010d3f6aa7449302413efed from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187c3da90ba-66155693-5cbd-4a6d-a51d-110ee56aa3a3-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

[Django]

#33662: Choose which items are displayed per language in Sitemap
-+-
 Reporter:  Roxane   |Owner:  Roxane
 Type:  New feature  |   Status:  closed
Component:  contrib.sitemaps |  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sitemap  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"5c456a879300e5f51010d3f6aa7449302413efed" 5c456a8]:
 {{{
 #!CommitTicketReference repository=""
 revision="5c456a879300e5f51010d3f6aa7449302413efed"
 Refs #33662 -- Corrected Sitemap.get_languages_for_item() signature in
 docs.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187c3d9fab2-4dfa8ef3-8ad9-4b55-9bbd-d2fa6275014f-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

[Django]

#33662: Choose which items are displayed per language in Sitemap
-+-
 Reporter:  Roxane   |Owner:  Roxane
 Type:  New feature  |   Status:  closed
Component:  contrib.sitemaps |  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sitemap  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"289e9a75afb52918a3efbdaf5e72f45a54089083" 289e9a7]:
 {{{
 #!CommitTicketReference repository=""
 revision="289e9a75afb52918a3efbdaf5e72f45a54089083"
 Fixed #33662 -- Allowed Sitemap to customize languages for each item.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701852a704a3d-8886a29b-6a68-4c64-ac8c-8f9975b525f8-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

[Django]

#33662: Choose which items are displayed per language in Sitemap
-+-
 Reporter:  Roxane   |Owner:  Roxane
 Type:  New feature  |   Status:  assigned
Component:  contrib.sitemaps |  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  sitemap  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701852a282303-b4bbb3c4-87b4-4671-bdae-a5ae69267374-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

[Django]

#33662: Choose which items are displayed per language in Sitemap
--+
 Reporter:  Roxane|Owner:  Roxane
 Type:  New feature   |   Status:  assigned
Component:  contrib.sitemaps  |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:  sitemap   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018516145399-2115441e-f485-473d-ae74-0e4485eaf96a-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

[Django]

#33662: Choose which items are displayed per language in Sitemap
--+
 Reporter:  Roxane|Owner:  Roxane
 Type:  New feature   |   Status:  assigned
Component:  contrib.sitemaps  |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:  sitemap   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Roxane):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184ed2373af-71e83dc1-24e6-4808-8030-e2b8e9a01686-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

[Django]

#33662: Choose which items are displayed per language in Sitemap
--+
 Reporter:  roxanebellot  |Owner:  roxanebellot
 Type:  New feature   |   Status:  assigned
Component:  contrib.sitemaps  |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:  sitemap   | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * has_patch:  1 => 0


Comment:

 @roxanebellot Please open a PR and add it here when you've done so.
 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018460f412c5-2dbf1a2f-5f57-430d-bc58-d488fc4274bc-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

[Django]

#33662: Choose which items are displayed per language in Sitemap
--+
 Reporter:  roxanebellot  |Owner:  roxanebellot
 Type:  New feature   |   Status:  assigned
Component:  contrib.sitemaps  |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:  sitemap   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by roxanebellot):

 * owner:  nobody => roxanebellot
 * status:  new => assigned
 * has_patch:  0 => 1


Comment:

 Sorry for the delay, I did not at all see any of your comments sooner !

 I have in my project a model Article which could be summed up in four
 fields (url_en, url_fr, content_en and content_fr). Some of these article
 are only written in one language. With no content, the page is empty. Even
 if it exists, I don't want this empty page to be in my sitemap.

 My idea was to add a method in Sitemap to return a boolean indicating
 whether the item should be displayed in the sitemap given a language.
 I made a first draft for a patch
 
([https://github.com/django/django/compare/main...roxanebellot:django:ticket_33662]).
 I wait for a green light on the feature before submitting it as a PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184000747b6-048576ca-d076-490a-a95a-8a2a054c6b1d-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap (was: Choose witch items are to be display per language in Sitemap)

[Django]

#33662: Choose which items are displayed per language in Sitemap
--+
 Reporter:  roxanebellot  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.sitemaps  |  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:  sitemap   | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * component:  Uncategorized => contrib.sitemaps


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183002f150e-d1223f52-61ad-4cea-a70b-8ef1c95e49f1-00%40eu-central-1.amazonses.com.