[Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+-
   Reporter:  Horst  |  Owner:  nobody
  Schneider  |
   Type: | Status:  new
  Uncategorized  |
  Component: |Version:  4.0
  contrib.admin  |
   Severity:  Normal |   Keywords:  admin, template
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 It seems like the fix to #31536 raised a problem similar to #32681: Not
 checking whether the `disabled` attribute actually exists on the `attrs`
 of the 'clear' checkbox widget causes a `VariableDoesNotExist` exception
 to be logged every time one of the patched `clearable_file_input.html`
 templates is rendered with a checkbox that has no `disabled` atrribute
 (i.e. is enabled):

 {{{
 [2022-07-06 10:06:03,452] DEBUG django.template base: Exception while
 resolving variable 'disabled' in template
 'admin/widgets/clearable_file_input.html'.
 Traceback (most recent call last):
   File "/home/horst/some_project/venv/lib/python3.10/site-
 packages/django/template/base.py", line 875, in _resolve_lookup
 current = current[bit]
 KeyError: 'disabled'

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File "/home/horst/some_project/venv/lib/python3.10/site-
 packages/django/template/base.py", line 885, in _resolve_lookup
 current = getattr(current, bit)
 AttributeError: 'dict' object has no attribute 'disabled'

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File "/home/horst/some_project/venv/lib/python3.10/site-
 packages/django/template/base.py", line 891, in _resolve_lookup
 current = current[int(bit)]
 ValueError: invalid literal for int() with base 10: 'disabled'

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File "/home/horst/some_project/venv/lib/python3.10/site-
 packages/django/template/base.py", line 898, in _resolve_lookup
 raise VariableDoesNotExist(
 django.template.base.VariableDoesNotExist: Failed lookup for key
 [disabled] in {'id': 'id_document'}
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7967486-04ce8b4a-36f3-4f84-ad74-a2abb73b0e9c-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 OK, yes — a fix to suppress that, similar to #32681 would be welcome.
 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d79b00b2-05981337-5278-48b7-a704-3c1fdc4d0086-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Mariusz Felisiak):

 * type:  Uncategorized => Bug


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7b086c8-4253bfb8-a89a-4109-b169-7195821d87f9-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Horst Schneider):

 Although the problem is similar, the fix must be different here. We can
 not easily supply some default context from the outside here since the
 missing variable is in the `attrs` attribute of the checkbox widget.

 It is guaranteed by the base `Widget` that `attrs` will always be a `dict
 ` instance. But it is **not** guaranteed that the key `disabled` will
 always be present on the `attrs`, so we will mostly find it to be either
 missing or set to `True` (could as well be set to `False`, if the default
 is explicitly stated).

 I guess a proper fix would be something along the lines of

 {{{
 
 }}}

 (First checking if key is present, then checking its truthiness).

 Or is there a more idiomatic way to perform those checks?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7c5bbac-7427a0f2-c46a-4562-91de-d867829e20a4-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Carlton Gibson):

 Either that or we'd need a fix to #28172 maybe? See also #28526 — I wonder
 if there isn't a cluster of duplicates here? 🤔

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7f1ab01-1e595a4e-1ad5-4723-8bc9-1b7e601a9162-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Carlton Gibson):

 @Horst could you investigate setting a default (`False`) for disabled in
 ClearableFileInput for this case?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d80fc3d1-dcc15aaf-c311-4bf0-8dcc-04b2869d4287-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Horst Schneider):

 Replying to [comment:5 Carlton Gibson]:
 > @Horst could you investigate setting a default (`False`) for disabled in
 ClearableFileInput for this case?

 Setting it both to `True` or `False` explicitly in the `attrs` does not
 trigger the `VariableDoesNotExist` exception to be logged. Only the
 absence of the `disabled` attribute on the `attrs` altogether triggers it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8318dd7-35552674-bccd-4b91-819f-d0b08fe85236-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Horst Schneider):

 Replying to [comment:4 Carlton Gibson]:
 > Either that or we'd need a fix to #28172 maybe? See also #28526 — I
 wonder if there isn't a cluster of duplicates here? 🤔

 Not really duplicates, right? #28172 seems to be a very specific different
 issue with filters and #28526 addresses the whole concept of logging
 missing template variables in such a verbose fashion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8362837-c27e49ba-b870-4a74-a69f-ebb98c457270-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Neeraj Kumar):

 Replying to [comment:6 Horst Schneider]:
 > Replying to [comment:5 Carlton Gibson]:
 > > @Horst could you investigate setting a default (`False`) for disabled
 in ClearableFileInput for this case?
 >
 > Setting it both to `True` or `False` explicitly in the `attrs` does not
 trigger the `VariableDoesNotExist` exception to be logged. Only the
 absence of the `disabled` attribute on the `attrs` altogether triggers it.


 This error already handled in Exception when we do not provide "disabled"
 in attrs.


 {{{
 raise VariableDoesNotExist("Failed lookup for key "
"[%s] in %r",
 (bit, current))  # missing attribute
 }}}

 {{{
 except Exception as e:
 template_name = getattr(context, 'template_name', None) or
 'unknown'
 logger.debug(
 "Exception while resolving variable '%s' in template
 '%s'.",
 bit,
 template_name,
 exc_info=True,
 )
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182cc268d93-fed1c3ce-2bf5-4870-9022-224397d3ab1c-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Neeraj Kumar):

 {{{
 
 }}}

 This solution can work to stop the trigger for {{{disabled}}} attribute in
 attrs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182cc28c821-fa372ca4-d3a6-4f3e-9d66-3fad7340a332-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Neeraj Kumar):

 * cc: Neeraj Kumar (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182cc2b1e5e-7ef8c3dd-28a0-4f48-ad5b-a1402d5b8341-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Carlton Gibson):

 The issue with the `{% if 'disabled' in widget.attrs and
 widget.attrs.disabled %} disabled{% endif %}` approach is that it makes
 the template somewhat verbose.

 The thought is that was can avoid that by setting a default `False` for
 the disabled attribute in `ClearableFileInput` — If that works (i.e.
 doesn't trigger the `VariableDoesNotExist`, shown by a new test similar to
 those added in e.g. 0a4a5e5bacc354df3132d0fcf706839c21afb89d, and doesn't
 break any existing tests) then that would be the preferred candidate for a
 fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182ceb31c0a-4af15650-06ab-42fb-8016-b081691034ad-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Neeraj Kumar):

 * has_patch:  0 => 1


Comment:

 PR for this
 https://github.com/django/django/pull/15991

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182cf1d13a6-26ce1fba-8e51-406a-83b9-6de4abe0c4b6-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  Neeraj Kumar
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Carlton Gibson):

 * owner:  nobody => Neeraj Kumar
 * status:  new => assigned
 * needs_tests:  0 => 1


Comment:

 Thanks for the patch Neeraj.

 Can you add a test case using `assertNoLogs()` ?

 > If that works (i.e. doesn't trigger the VariableDoesNotExist, shown by a
 new test similar to those added in e.g.
 0a4a5e5bacc354df3132d0fcf706839c21afb89d,

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182cf4a1a7a-d91bd324-1c6a-4f61-a727-0d2debb26682-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  Neeraj Kumar
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Neeraj Kumar):

 Replying to [comment:13 Carlton Gibson]:
 > Thanks for the patch Neeraj.
 >
 > Can you add a test case using `assertNoLogs()` ?
 >
 > > If that works (i.e. doesn't trigger the VariableDoesNotExist, shown by
 a new test similar to those added in e.g.
 0a4a5e5bacc354df3132d0fcf706839c21afb89d,

 Added testcase using `assertNoLogs()`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182cfd3d780-7b017ff2-8d37-4ed6-b8ca-21b5c1e6f67f-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  Neeraj Kumar
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Carlton Gibson):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182d00195ac-59056063-f0e7-43ba-837f-234d47cf5f0f-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+-
 Reporter:  Horst Schneider  |Owner:  Neeraj
 |  Kumar
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182d3935199-72693598-665f-4fe7-a3bf-62149c10dcaa-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+-
 Reporter:  Horst Schneider  |Owner:  Neeraj
 |  Kumar
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  admin, template  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9942f3fb490f56bf28ee69f0a07f3eb62e7d3ab3" 9942f3fb]:
 {{{
 #!CommitTicketReference repository=""
 revision="9942f3fb490f56bf28ee69f0a07f3eb62e7d3ab3"
 Fixed #33830 -- Fixed VariableDoesNotExist when rendering
 ClearableFileInput.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070182d3bf25a7-dd0b7774-461b-409e-8981-79eb4d76e6ba-00%40eu-central-1.amazonses.com.