Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  Jerry Wan
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186016ff7ef-8c4f180c-b85c-4451-9264-6a51d9aedd81-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  Jerry Wan
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * cc: Tom Carrick (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070185e80646b6-7c9a2471-de1a-48b5-9e6e-0d6cf78ee47e-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  Jerry Wan
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Jerry Wan):

 * has_patch:  0 => 1


Comment:

 Link to PR: https://github.com/django/django/pull/16414

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070185667e4160-a9b6c993-314c-4bac-b007-e9aa44f492ca-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  Jerry Wan
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Jerry Wan):

 * owner:  (none) => Jerry Wan
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018517c556e6-c37fe6d3-45b3-46bb-98b5-64326070037f-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  (none)
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * owner:  Florian Perucki => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701848530c140-60fd1ef4-bd57-4cb5-8d9a-6fd64b28a5da-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  Florian
 Type:   |  Perucki
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  1 => 0
 * stage:  Ready for checkin => Accepted


Old description:

> There are two nice and simple accessibility improvements we could make to
> the Django admin’s breadcrumbs:
>
> 1. Wrap them in a ``
> region, so they can be identified as a navigation landmark by screen
> reader users.
> 2. Structure the links as a `` list with `` items for each crumb,
> so screen reader users know how many items there are (visually they don’t
> need any changes)
> 3. Switch the last item to also be a link, with a `aria-current="page"`
> attribute, so semantically the last item is marked as "current page"
> (again doesn’t necessarily need any visual change). Technically this
> would also work as a span but I believe switching to a link would be a
> nicer experience (consistent tabbing through all items in the breadcrumb)
>
> All three improvements are based on the
> [https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/ Breadcrumb ARIA
> authoring practices pattern]. All can technically be done separately if
> desired.

New description:

 There are two nice and simple accessibility improvements we could make to
 the Django admin’s breadcrumbs:

 1. (fixed in **872b61193b013a700ff88cf50f0eb2cf2c266ff7**) Wrap them in a
 `` region, so they can be
 identified as a navigation landmark by screen reader users.
 2. Structure the links as a `` list with `` items for each crumb,
 so screen reader users know how many items there are (visually they don’t
 need any changes)
 3. Switch the last item to also be a link, with a `aria-current="page"`
 attribute, so semantically the last item is marked as "current page"
 (again doesn’t necessarily need any visual change). Technically this would
 also work as a span but I believe switching to a link would be a nicer
 experience (consistent tabbing through all items in the breadcrumb)

 All three improvements are based on the
 [https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/ Breadcrumb ARIA
 authoring practices pattern]. All can technically be done separately if
 desired.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018379144094-8ab66dfd-540e-4ef4-b55a-035da38d47e1-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  Florian
 Type:   |  Perucki
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Ready for
  landmarks, ARIA|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"872b61193b013a700ff88cf50f0eb2cf2c266ff7" 872b6119]:
 {{{
 #!CommitTicketReference repository=""
 revision="872b61193b013a700ff88cf50f0eb2cf2c266ff7"
 Refs #34041 -- Added navigation landmark to breadcrumbs in admin.

 Thanks Thibaud Colas for pair programming.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018379132561-a7172aeb-cce6-4db3-ad77-848dd719393b-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  Florian
 Type:   |  Perucki
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Ready for
  landmarks, ARIA|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701837891778a-3850892b-0c59-4c53-be27-27ef2b6d02f3-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  Florian
 Type:   |  Perucki
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Florian Perucki):

 * has_patch:  0 => 1


Comment:

 PR: https://github.com/django/django/pull/16106

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183702cbced-6a1679df-e42b-4c8e-b730-636870307310-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  Florian
 Type:   |  Perucki
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Florian Perucki):

 * owner:  nobody => Florian Perucki
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701836ed471c9-2be6c7f9-c5b2-441e-920a-7d29819aa68a-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * type:  New feature => Cleanup/optimization


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701836e9be300-a9e241c0-6bc9-4f61-a640-43f599aa27a8-00%40eu-central-1.amazonses.com.

Re: [Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  landmarks, ARIA|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701836e9bb36b-c929e1b5-d793-47bb-ac76-d892b8128c77-00%40eu-central-1.amazonses.com.

[Django] #34041: Accessibility improvements for admin breadcrumbs

[Django]

#34041: Accessibility improvements for admin breadcrumbs
-+-
   Reporter:  Thibaud|  Owner:  nobody
  Colas  |
   Type:  New| Status:  new
  feature|
  Component: |Version:  dev
  contrib.admin  |   Keywords:  accessibility,
   Severity:  Normal |  landmarks, ARIA
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  1  |
-+-
 There are two nice and simple accessibility improvements we could make to
 the Django admin’s breadcrumbs:

 1. Wrap them in a ``
 region, so they can be identified as a navigation landmark by screen
 reader users.
 2. Structure the links as a `` list with `` items for each crumb,
 so screen reader users know how many items there are (visually they don’t
 need any changes)
 3. Switch the last item to also be a link, with a `aria-current="page"`
 attribute, so semantically the last item is marked as "current page"
 (again doesn’t necessarily need any visual change). Technically this would
 also work as a span but I believe switching to a link would be a nicer
 experience (consistent tabbing through all items in the breadcrumb)

 All three improvements are based on the
 [https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/ Breadcrumb ARIA
 authoring practices pattern]. All can technically be done separately if
 desired.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701836e742a9b-dd279df7-3170-421d-b927-23c04c1c1944-00%40eu-central-1.amazonses.com.