Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  bcail
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => fixed

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8cb1f31d-9d279613-81f5-43dd-a2ac-9001d02aa5e8-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  bcail
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"8b7ddd1b621e1396cf87c08faf11937732f09dcd" 8b7ddd1]:
 {{{#!CommitTicketReference repository=""
 revision="8b7ddd1b621e1396cf87c08faf11937732f09dcd"
 Refs #34534 -- Reduced constraint operations with Meta.constraints when
 optimizing migrations.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8cb03ff5-ddd9610c-e6ec-41a1-9d1a-92a434ad7daf-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  bcail
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8c7b18bb-e86284f7-6db6-4fcc-85cc-7cf7273456a8-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
--+
 Reporter:  David Sanders |Owner:  bcail
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Migrations|  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by bcail):

 * owner:  (none) => bcail
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d66949067-a3a3a022-9333-4ac0-b686-6b1abc27ed52-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
--+
 Reporter:  David Sanders |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by bcail):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d654e99cf-de896d0b-37e1-40f6-aeea-c0dd03cf3957-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
--+
 Reporter:  David Sanders |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Comment (by bcail):

 > A question was raised whether constraints could be reduced into create
 model though some databases do not support deferrable constraints (eg
 MySQL)
 I opened [https://github.com/django/django/pull/17805 a PR] for this part.
 Is that on the right track?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d61420ec8-2ded135d-d70e-45b5-b58d-74b5045686d1-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
--+
 Reporter:  David Sanders |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Comment (by Mariusz Felisiak):

 Replying to [comment:12 bcail]:
 > Should this ticket be closed, or is there something else that's supposed
 to be done here?

 Two points remain unresolved:

 >  - A question was raised whether constraints could be reduced into
 create model though some databases do not support deferrable constraints
 (eg MySQL)
 >  - It's worth going over the operations to see if there are any other
 potential reductions to add
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d5be5a240-94b8a141-17dc-4925-8872-242760e3dcfc-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
--+
 Reporter:  David Sanders |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by bcail):

 * cc: bcail (added)

Comment:

 Should this ticket be closed, or is there something else that's supposed
 to be done here?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d5b659d37-f38f6b73-d1be-4867-ba1a-4471883dd948-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
--+
 Reporter:  David Sanders |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Adam Johnson):

 Thank you for reporting this David, making the PR Akash, and reviewing
 Mariusz. 

 I was just looking at a migration with consecutive add + remove operations
 for the same constraints, wondering why they weren't optimized. Glad to
 see they will be in the future.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018859ecf54c-1309e530-5ee6-4e52-a1a3-601a6acf339f-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
--+
 Reporter:  David Sanders |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * owner:  Akash Kumar Sen => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018851c55249-9d330906-848d-4220-8f25-a2614c24c9a5-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  Akash
 Type:   |  Kumar Sen
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  1 => 0
 * stage:  Ready for checkin => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018801392b66-0372702c-965c-496b-8f86-34ae65b95a64-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  Akash
 Type:   |  Kumar Sen
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"92f0017133c2d31fbd527bab7b08d4d49a582143" 92f0017]:
 {{{
 #!CommitTicketReference repository=""
 revision="92f0017133c2d31fbd527bab7b08d4d49a582143"
 Refs #34534 -- Reduced Add/RemoveConstraint and Add/RenameIndex operations
 when optimizing migrations.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701880138f3f9-784943a8-2f55-40bd-add9-3e071974a44f-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  Akash
 Type:   |  Kumar Sen
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187ffe9821f-b0345586-faf2-4ac8-910f-89169756f292-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  Akash
 Type:   |  Kumar Sen
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Akash Kumar Sen):

 Thanks for the review David. Updated the patch accordingly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187fee0079d-2a73f2f0-2cb0-4700-b8ca-d57fcd96f3da-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  Akash
 Type:   |  Kumar Sen
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Sanders):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187fe2e7b5f-2c55b534-5f69-433d-859b-dbbf16894d66-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  Akash
 Type:   |  Kumar Sen
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by David Sanders):

 Hi Akash,

 Please see this PR for context & "prior art":
 https://github.com/django/django/pull/16819 

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187fafd2cdf-e500dd1d-1dad-444b-a6b5-a506ccb3400b-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
-+-
 Reporter:  David Sanders|Owner:  Akash
 Type:   |  Kumar Sen
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Akash Kumar Sen):

 * owner:  nobody => Akash Kumar Sen
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187fa4e8385-7565672b-a15b-4297-9fb2-af65c5ee4c14-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations.

[Django]

#34534: Reduce index/constraints operations.
--+
 Reporter:  David Sanders |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Description changed by Mariusz Felisiak:

Old description:

> From https://github.com/django/django/pull/16819#issuecomment-1529913703
>
>  - RenameIndex can be reduced into CreateIndex
>  - DropConstraint can be reduced into CreateConstraint
>  - A question was raised whether constraints could be reduced into create
> model though some databases do not support deferrable constraints (eg
> MySQL)
>  - It's worth going over the operations to see if there are any other
> potential reductions to add

New description:

 From https://github.com/django/django/pull/16819#issuecomment-1529913703

  - `RenameIndex` can be reduced into `AddIndex`
  - `DropConstraint` can be reduced with `AddConstraint`
  - A question was raised whether constraints could be reduced into create
 model though some databases do not support deferrable constraints (eg
 MySQL)
  - It's worth going over the operations to see if there are any other
 potential reductions to add

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187e19847d9-4885408a-2ea1-452a-8d2e-9eb3de71e52d-00%40eu-central-1.amazonses.com.

Re: [Django] #34534: Reduce index/constraints operations. (was: Migration operation optimisations)

[Django]

#34534: Reduce index/constraints operations.
--+
 Reporter:  David Sanders |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * component:  Database layer (models, ORM) => Migrations
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the ticket.

 > - It's worth going over the operations to see if there are any other
 potential reductions to add

 This point it too generic. Please open a new ticket when you will find
 something more. We don't want to keep this ticket to be open forever.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187e197792f-0b20df74-1480-459f-a3d0-e88b79fc9d66-00%40eu-central-1.amazonses.com.