Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  closed
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  HTML, assertions,| Triage Stage:  Ready for
  testing|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"1dae65dc63ae84be5002c37b4ddae0b9220e8808" 1dae65dc]:
 {{{
 #!CommitTicketReference repository=""
 revision="1dae65dc63ae84be5002c37b4ddae0b9220e8808"
 Fixed #34657 -- Made assert(Not)Contains/assertInHTML display haystacks in
 error messages.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018af4f3fb8e-71d93f9c-7a35-497d-8e72-96893c094e9e-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Ready for
  testing|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018af4b6efaa-3d2c08f3-95bc-4e10-8d29-4609bf9cb3d7-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"679212a47ac3e22a6fbb6ee3cd4c09f29aae8b5d" 679212a]:
 {{{
 #!CommitTicketReference repository=""
 revision="679212a47ac3e22a6fbb6ee3cd4c09f29aae8b5d"
 Refs #34657 -- Made msg_prefix handling in assertURLEqual()/assertInHTML
 consistent with other assertions.

 Co-authored-by: Chinmoy Chakraborty 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018af46ddf42-c73189fc-bd4b-4f26-ba54-9ce4f97155a2-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ae0228063-d10b1b42-7463-4512-bb13-56939a3abee5-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"e99c7d8847e9006f877ab3cea47f1977652af71f" e99c7d88]:
 {{{
 #!CommitTicketReference repository=""
 revision="e99c7d8847e9006f877ab3cea47f1977652af71f"
 Refs #34657 -- Made assertInHTML() use unparsed needle in error messages.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ae0218722-f1e3b74c-0b7f-4b33-8895-50619301fb5d-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chinmoy):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a596a9073-d8dd8b92-930c-4991-9596-be08e6d64763-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a506ba2d2-55c2f1cc-b57b-48e4-b778-bb6c71825126-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chinmoy):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a4a5e2c60-27275cba-9f87-48f9-a98c-47ab7f1a5b5f-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * version:   => dev
 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a3fabe760-5571679d-4989-4b43-a366-22dfbd39f947-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chinmoy):

 * has_patch:  0 => 1


Comment:

 Here is the PR [https://github.com/django/django/pull/17204].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a3796e3e3-1bb42aa0-1ede-4a25-923f-fc6e82ab354b-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Chinmoy):

 Hey, sorry I missed this in my mail. Will submit a PR soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a31aef22e-6e346207-9818-4389-b714-cf6aaa58970e-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chinmoy):

 * cc: Chinmoy (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a31a9408f-a0d3a837-5d28-4285-b076-b75117b0321a-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * needs_better_patch:  1 => 0
 * has_patch:  1 => 0
 * needs_tests:  1 => 0
 * needs_docs:  1 => 0


Comment:

 Resetting patch flags.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189f4f60c4f-e56cb77e-7e98-43b2-b134-f5bd63347f82-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Chinmoy
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * owner:  Shamil Abdulaev => Chinmoy
 * status:  new => assigned


Comment:

 Replying to [comment:11 Chinmoy]:
 > Hey, is this still being worked upon? Can I assign myself to this
 ticket?

 Hi! Thank you for your interest in contributing. I checked and both
 related PRs are closed so if you can work on this, it'll be certainly
 welcomed! Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189f4f5b9b4-0e14572a-c681-4e00-81ea-1b58a7a4e9ad-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Shamil
 |  Abdulaev
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Chinmoy):

 Hey, is this still being worked upon? Can I assign myself to this ticket?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189ef7e9599-dbc5bc7c-bdda-45b0-95fd-c6d947834b24-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Shamil
 |  Abdulaev
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Hi Shamil, we still need to review and merge in a PR before we mark a
 ticket as fixed. In general I would leave the status alone as mostly the
 fellows take care of this
 I've written a couple of comments on the PR, once they're sorted we can
 update the ticket to go into the review queue

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701898c622ca8-2001af6b-6eb9-421e-b42b-e8b753b59f18-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Shamil
 |  Abdulaev
 Type:  New feature  |   Status:  closed
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Shamil Abdulaev):

 * status:  assigned => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701898c15d861-74b2ab6c-4d3d-41c0-b0d9-bf327074ce10-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  Shamil
 |  Abdulaev
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * owner:  nobody => Shamil Abdulaev
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701895e8a0536-82231d3c-57d2-4f3b-bab5-f175e10baaa4-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * needs_tests:  0 => 1
 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701895e880653-361a4897-a244-4a87-90f0-881210d98393-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shamil Abdulaev):

 I have fixed this bug and sent a PR
 https://github.com/django/django/pull/17076 for consideration!)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701895e254386-92f956d1-dc0f-4492-86c3-d6aa9c161e64-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Thibaud Colas):

 Sorry, I didn’t realise feature requests require a forum post! I’ll know
 for next time.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188d2d1b2ac-84086167-c889-4423-8974-80dc5b38b681-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:2 Natalia Bidart]:
 > Tentatively accepting because this is related to the testing framework,
 though I'm not 100% sure on procedure whether this specific case needs a
 forum post since it's marked as a new feature. I would argue this is a
 cleanup/optimization :thinking:

 Creating a new setting is always controversial (we already have many of
 them) and users can already control it with `maxDiff`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188c8b5d5f6-2b55770c-a8f2-4137-a0c0-3daef273d1c4-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sarah Boyce):

 I can see the value of this. The react testing library we use has a
 setting `DEBUG_PRINT_LIMIT` (https://testing-library.com/docs/dom-testing-
 library/api-debugging/#automatic-logging) with a default of 7000
 characters but you can increase it if you need to see more printed. I
 recommend that we have a similar setting 👍

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188c89b35a4-8c609ac0-407d-471d-b3f4-08dce6f6e6db-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  HTML, assertions,| Triage Stage:  Accepted
  testing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * keywords:  testcases, unit tests, HTML, assertions, testing => HTML,
 assertions, testing
 * stage:  Unreviewed => Accepted


Comment:

 Tentatively accepting because this is related to the testing framework,
 though I'm not 100% sure on procedure whether this specific case needs a
 forum post since it's marked as a new feature. I would argue this is a
 cleanup/optimization :thinking:

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188c4c686bd-78b44478-147c-4d09-822a-45a1475752b6-00%40eu-central-1.amazonses.com.

Re: [Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  testcases, unit  | Triage Stage:
  tests, HTML, assertions, testing   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Thibaud Colas:

Old description:

> If I use the vanilal Python `assertIn` or `assertRegex`, when the
> assertion fails, it’s very simple to assess what went wrong from the test
> error only:
>
> {{{
> self.assertIn("hey", "Howdy!")
> AssertionError: 'hey' not found in 'Howdy!'
> }}}
>
> With Django’s `assertContains` and `assertInHTML`, this gets much harder:
>
> {{{
> self.assertInHTML("hey", "Howdy!")
>   File "/Users/thibaudcolas/Dev/django/html-testing-with-
> django/.venv/lib/python3.11/site-packages/django/test/testcases.py", line
> 1076, in assertInHTML
> self.assertTrue(
> AssertionError: False is not true : Couldn't find '
> hey
> ' in response
> }}}
>
> and:
>
> {{{
> self.assertContains(res, "hey")
>   File "/Users/thibaudcolas/Dev/django/html-testing-with-
> django/.venv/lib/python3.11/site-packages/django/test/testcases.py", line
> 660, in assertContains
> self.assertTrue(
> AssertionError: False is not true : Couldn't find 'hey' in
> response
> }}}
>
> ---
>
> In both cases, Django doesn’t display the haystack – so I have to waste a
> lot of time going back to my HTML templates to check what they might be
> outputting / or potentially load the same scenario in a browser / or
> manually add `print` statements to my test cases. This is all very time-
> consuming. Instead, it’d be much better if the haystack was just present.
>
> Additionally for `assertInHTML` – it’s annoying that `needle` as
> displayed in the failure message is the parser’s output, which is
> therefore broken up over multiple lines. It’d be much nicer if the
> example above resulted in `AssertionError: False is not true : Couldn't
> find 'hey' in response`.
>
> ---
>
> Test suite I used to compare output for reference:
> https://github.com/thibaudcolas/html-testing-with-
> django/blob/39c82c410cce4bea71ac54be27be67057f4d8dd8/testing_tests/tests.py#L5

New description:

 If I use the vanilal Python `assertIn` or `assertRegex`, when the
 assertion fails, it’s very simple to assess what went wrong from the test
 error only:

 {{{
 self.assertIn("hey", "Howdy!")
 AssertionError: 'hey' not found in 'Howdy!'
 }}}

 With Django’s `assertContains` and `assertInHTML`, this gets much harder:

 {{{
 self.assertInHTML("hey", "Howdy!")
   File "/Users/thibaudcolas/Dev/django/html-testing-with-
 django/.venv/lib/python3.11/site-packages/django/test/testcases.py", line
 1076, in assertInHTML
 self.assertTrue(
 AssertionError: False is not true : Couldn't find '
 hey
 ' in response
 }}}

 and:

 {{{
 self.assertContains(res, "hey")
   File "/Users/thibaudcolas/Dev/django/html-testing-with-
 django/.venv/lib/python3.11/site-packages/django/test/testcases.py", line
 660, in assertContains
 self.assertTrue(
 AssertionError: False is not true : Couldn't find 'hey' in response
 }}}

 ---

 In both cases, Django doesn’t display the haystack – so I have to waste a
 lot of time going back to my HTML templates to check what they might be
 outputting / or potentially load the same scenario in a browser / or
 manually add `print` statements to my test cases. This is all very time-
 consuming. Instead, it’d be much better if the haystack was just present.

 Additionally for `assertInHTML` – it’s annoying that `needle` as displayed
 in the failure message is the parser’s output, which is therefore broken
 up over multiple lines. It’d be much nicer if the example above resulted
 in `AssertionError: False is not true : Couldn't find 'hey' in
 response`.

 ---

 Test suite I used to compare output for reference:
 https://github.com/thibaudcolas/html-testing-with-
 django/blob/39c82c410cce4bea71ac54be27be67057f4d8dd8/testing_tests/tests.py#L5

 And link to Python’s `assertIn` / `assertNotIn` implementations:
 
https://github.com/python/cpython/blob/101d5ec7d7fe122fa81a377c8ab8b562d1add9ee/Lib/unittest/case.py#L1147-L1159

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups

[Django] #34657: Testing assertions `assertContains` and `assertInHTML` should output the haystack on failure

[Django]

#34657: Testing assertions `assertContains` and `assertInHTML` should output the
haystack on failure
-+-
   Reporter:  Thibaud|  Owner:  nobody
  Colas  |
   Type:  New| Status:  new
  feature|
  Component:  Testing|Version:
  framework  |   Keywords:  testcases, unit
   Severity:  Normal |  tests, HTML, assertions, testing
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 If I use the vanilal Python `assertIn` or `assertRegex`, when the
 assertion fails, it’s very simple to assess what went wrong from the test
 error only:

 {{{
 self.assertIn("hey", "Howdy!")
 AssertionError: 'hey' not found in 'Howdy!'
 }}}

 With Django’s `assertContains` and `assertInHTML`, this gets much harder:

 {{{
 self.assertInHTML("hey", "Howdy!")
   File "/Users/thibaudcolas/Dev/django/html-testing-with-
 django/.venv/lib/python3.11/site-packages/django/test/testcases.py", line
 1076, in assertInHTML
 self.assertTrue(
 AssertionError: False is not true : Couldn't find '
 hey
 ' in response
 }}}

 and:

 {{{
 self.assertContains(res, "hey")
   File "/Users/thibaudcolas/Dev/django/html-testing-with-
 django/.venv/lib/python3.11/site-packages/django/test/testcases.py", line
 660, in assertContains
 self.assertTrue(
 AssertionError: False is not true : Couldn't find 'hey' in response
 }}}

 ---

 In both cases, Django doesn’t display the haystack – so I have to waste a
 lot of time going back to my HTML templates to check what they might be
 outputting / or potentially load the same scenario in a browser / or
 manually add `print` statements to my test cases. This is all very time-
 consuming. Instead, it’d be much better if the haystack was just present.

 Additionally for `assertInHTML` – it’s annoying that `needle` as displayed
 in the failure message is the parser’s output, which is therefore broken
 up over multiple lines. It’d be much nicer if the example above resulted
 in `AssertionError: False is not true : Couldn't find 'hey' in
 response`.

 ---

 Test suite I used to compare output for reference:
 https://github.com/thibaudcolas/html-testing-with-
 django/blob/39c82c410cce4bea71ac54be27be67057f4d8dd8/testing_tests/tests.py#L5

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188c46b6dc6-45772794-a93a-45f3-9a74-6b65395a13a3-00%40eu-central-1.amazonses.com.