Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-06-14 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
-+-
 Reporter:  devin13cox   |Owner:
 |  devin13cox
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

 In [changeset:"49a3a8d9a22ebcb29fdc4bacaa204f0bd2a6abf6" 49a3a8d]:
 {{{#!CommitTicketReference repository=""
 revision="49a3a8d9a22ebcb29fdc4bacaa204f0bd2a6abf6"
 [5.1.x] Fixed #34789 -- Prevented updateRelatedSelectsOptions from
  adding entries to filter_horizontal chosen box.

 Co-authored-by: yokeshwaran1 

 Backport of 719a42b589d7551fc84708044b9e984ce723c8a2 from main.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019016b30188-f7016f8e-6d81-4986-907b-6e6e9040fec6-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-06-12 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
-+-
 Reporter:  devin13cox   |Owner:
 |  devin13cox
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"719a42b589d7551fc84708044b9e984ce723c8a2" 719a42b5]:
 {{{#!CommitTicketReference repository=""
 revision="719a42b589d7551fc84708044b9e984ce723c8a2"
 Fixed #34789 -- Prevented updateRelatedSelectsOptions from
  adding entries to filter_horizontal chosen box.

 Co-authored-by: yokeshwaran1 
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701900c2344a0-271d3683-7efd-41d2-9b83-a255a9de02bf-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-06-12 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
-+-
 Reporter:  devin13cox   |Owner:
 |  devin13cox
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Sarah Boyce):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701900bd2e03a-af0beddb-6a95-49e3-a3e3-85650a05b1a4-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-06-06 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+--
 Reporter:  devin13cox |Owner:  devin13cox
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by devin13cox):

 * needs_better_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018fefa19e3d-8e67127f-208f-4523-92a5-fcc8a24fd00a-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-05-08 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+--
 Reporter:  devin13cox |Owner:  devin13cox
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f57fa92d8-03b901ab-996a-43f4-9c56-4529efda2c45-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-04-12 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+--
 Reporter:  devin13cox |Owner:  devin13cox
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by devin13cox):

 * needs_better_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ed3a5dfc3-1968017e-65bb-47bd-b164-0fd04f3071c2-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-03-26 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+--
 Reporter:  devin13cox |Owner:  devin13cox
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Natalia Bidart):

 * easy:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e7adac9e3-7160576c-2dff-42f9-844a-7e27f8ee0829-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-03-13 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+--
 Reporter:  devin13cox |Owner:  devin13cox
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+--
Comment (by Tim Graham):

 No, the ticket flags are set correctly to put the ticket in the patch
 review queue. You can confirm this by looking at the yellow box below the
 ticket description ("According to the ticket's flags...").
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e39e9d2a0-a722c75f-665b-4a8c-b39d-be0e9eb40938-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-03-13 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+--
 Reporter:  devin13cox |Owner:  devin13cox
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+--
Comment (by devin13cox):

 Hello, just wanted to check in and see if there is anything else I need to
 do pending a review for this ticket. No rush on getting this in, I just
 wanted to make sure you guys aren't waiting on something from me. Thanks!
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e39a8b318-e7de6f88-09f4-4e8b-8883-a602716a72bd-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-02-27 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+--
 Reporter:  devin13cox |Owner:  devin13cox
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+--
Changes (by devin13cox):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ded736fd0-06f12442-d965-43ef-a7eb-fff8719ee9e0-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2024-02-21 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+--
 Reporter:  devin13cox |Owner:  devin13cox
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+--
Changes (by devin13cox):

 * owner:  yokeshwaran1 => devin13cox

Comment:

 Opened new PR on this https://github.com/django/django/pull/17897. Ran
 into small issue that still needs work, as described in the old PR. Will
 get it patched soon, but if anyone has direction on it I would appreciate
 feedback. Thanks!
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dce640949-ffe24250-0f9a-4fd5-adce-bed1cf78da7e-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-09-14 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  yokeshwaran1
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  1
---+
Changes (by Natalia Bidart):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a9417b018-3f8a0a23-e03e-4cfd-bd85-68253fbf4e07-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-09-11 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  yokeshwaran1
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by Mariusz Felisiak):

 * owner:  (none) => yokeshwaran1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a8306908c-e41fbd29-3ed8-41b3-b2df-18ec6942c302-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-09-08 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  (none)
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by Natalia Bidart):

 * has_patch:  0 => 1


Comment:

 Setting the has patch flag.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a75f067bb-2ee13856-c07c-414c-b0d0-d7d5c1954706-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-09-08 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  (none)
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by yokeshwaran1):

 Hi David,
 I have opened a PR to address this issue:
 https://github.com/django/django/pull/17219
  Replying to [comment:11 yokeshwaran1]:
 > Thanks, David. I’ll make the necessary changes and submit a PR with
 tests soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a759905cf-023a2e41-017d-4ce6-95ef-8cfb873b92af-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-08-28 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  (none)
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by yokeshwaran1):

 Thanks, David. I’ll make the necessary changes and submit a PR with tests
 soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a3b2df6ef-ef6ef2b0-6e72-4d91-b60e-dadc6c9381a5-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-08-27 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  (none)
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by David Sanders):

 Replying to [comment:9 yokeshwaran1]:
 > I think about a solution which will not continuously blacklisting
 ancestors

 Yep that's along the lines of what I was getting at 

 The question is though which approach is clearer/easier to maintain. The
 benefit of whitelisting is we can remove `not(.admin-autocomplete)` too I
 think 樂

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a39f4115a-308f1f97-fbd8-4b5f-bc76-144c8fcc5640-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-08-27 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  (none)
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by yokeshwaran1):

 Hi David,
 Im new to this repo,  so I appreciate any guidance or feedback u can
 offer.

 Regardin issue with filter_horizontal "Chosen" column.  From the
 discussion, I think about a solution which will not continuously
 blacklisting ancestors

 1. Adding a data attribute like data-context to select elements during its
 render phase in the Django admin templates. So each select will have a
 more specific context about its purpose (eg. source, target, chosen etc.).

 2. Then modifying the query in RelatedObjectLookups.js to use this new
 data-context attribute, so our selector will become:

 {{{
 const selectsRelated = document.querySelectorAll(`[data-model-
 ref="${modelName}"][data-context="source"] select:not(.admin-
 autocomplete)`);
 }}}

 This approach will provide clear context for each select element which
 makes JavaScript logic more intentional. would this be a feasible,
 acceptable solution in ur opinion? I'm eager to hear ur thoughts & make
 any necessary adjustments. Once approach is approved, I'm interested in
 working on this ticket. Please let me know if that's possible.

 Replying to [comment:8 David Sanders]:
 > Replying to [ticket:34789 devin13cox]:
 > > My initial guess is that updating the query to not include the
 "Chosen" column in filter_horizontal fields would solve this issue
 (something like
 > > {{{
 > > const selectsRelated = document.querySelectorAll(`[data-model-
 ref="${modelName}"] div:not(.selector-chosen) > select:not(.admin-
 autocomplete)`);
 > > }}}
 >
 > That could work  I'm just wondering though whether there's a better
 approach than to continuously blacklist ancestors as we come across these
 樂

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a385f7189-4bb7f6d8-9b86-4a72-a313-61d625ed72f8-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-08-24 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  (none)
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by David Sanders):

 Replying to [ticket:34789 devin13cox]:
 > My initial guess is that updating the query to not include the "Chosen"
 column in filter_horizontal fields would solve this issue (something like
 > {{{
 > const selectsRelated = document.querySelectorAll(`[data-model-
 ref="${modelName}"] div:not(.selector-chosen) > select:not(.admin-
 autocomplete)`);
 > }}}

 That could work  I'm just wondering though whether there's a better
 approach than to continuously blacklist ancestors as we come across these
 樂

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a2663fea0-652270de-1360-4a78-84c5-58bc138968dd-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-08-23 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  (none)
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by devin13cox):

 * owner:  nobody => (none)
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a235ec2a8-6a5f3bac-aa69-41a7-a42d-050ddb2b4ffc-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action

2023-08-21 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+
Changes (by Mariusz Felisiak):

 * cc: David Sanders, Marcelo Galigniana (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a1b53d403-ccaf5b73-2b9e-4e1b-acec-ebdc1db983dc-00%40eu-central-1.amazonses.com.


Re: [Django] #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action (was: Admin filter_horizontal shows item in "Chos

2023-08-21 Thread Django
#34789: `filter_horizontal` duplicates entries in "Chosen" column after 
instance is
added via in another field using the "plus" JS action
---+
 Reporter:  devin13cox |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a1abf6ea9-ec1b0d95-90a4-4123-867e-ac4ffd57a37c-00%40eu-central-1.amazonses.com.