Re: [Django] #34810: Calculate coverage on subprocesses such as django-admin commands
#34810: Calculate coverage on subprocesses such as django-admin commands
-+-
Reporter: Jacob Walls |Owner: Jacob
Type: | Walls
Cleanup/optimization | Status: closed
Component: Core (Other) | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1| Needs documentation: 0
Needs tests: 0| Patch needs improvement: 0
Easy pickings: 0|UI/UX: 0
-+-
Changes (by Natalia <124304+nessita@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"1ab2cf7994a6f1116a96fbaedd7cadbd4b754179" 1ab2cf79]:
{{{
#!CommitTicketReference repository=""
revision="1ab2cf7994a6f1116a96fbaedd7cadbd4b754179"
Fixed #34810 -- Measured test coverage on django-admin commands.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34810#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018a7163b018-c797b047-b524-4ec9-acdb-55bd1269cc12-00%40eu-central-1.amazonses.com.
Re: [Django] #34810: Calculate coverage on subprocesses such as django-admin commands
#34810: Calculate coverage on subprocesses such as django-admin commands -+- Reporter: Jacob Walls |Owner: Jacob Type: | Walls Cleanup/optimization | Status: assigned Component: Core (Other) | Version: dev Severity: Normal | Resolution: Keywords: | Triage Stage: Ready for | checkin Has patch: 1| Needs documentation: 0 Needs tests: 0| Patch needs improvement: 0 Easy pickings: 0|UI/UX: 0 -+- Changes (by Natalia Bidart): * stage: Accepted => Ready for checkin -- Ticket URL: <https://code.djangoproject.com/ticket/34810#comment:6> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/0107018a7159db82-2fb83fea-2269-4482-bdb0-08f6f48f9067-00%40eu-central-1.amazonses.com.
Re: [Django] #34810: Calculate coverage on subprocesses such as django-admin commands
#34810: Calculate coverage on subprocesses such as django-admin commands -+- Reporter: Jacob Walls |Owner: Jacob Type: | Walls Cleanup/optimization | Status: assigned Component: Core (Other) | Version: dev Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1| Needs documentation: 0 Needs tests: 0| Patch needs improvement: 0 Easy pickings: 0|UI/UX: 0 -+- Changes (by Jacob Walls): * needs_better_patch: 1 => 0 Comment: Thanks for the review. Left a comment with what I found about the `concurrency` option taking the place of the `parallel` option. -- Ticket URL: <https://code.djangoproject.com/ticket/34810#comment:5> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/0107018a6cc06822-e9dc4976-3bc6-4d22-a1f2-7374613d91c5-00%40eu-central-1.amazonses.com.
Re: [Django] #34810: Calculate coverage on subprocesses such as django-admin commands
#34810: Calculate coverage on subprocesses such as django-admin commands -+- Reporter: Jacob Walls |Owner: Jacob Type: | Walls Cleanup/optimization | Status: assigned Component: Core (Other) | Version: dev Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1| Needs documentation: 0 Needs tests: 0| Patch needs improvement: 1 Easy pickings: 0|UI/UX: 0 -+- Changes (by Natalia Bidart): * needs_better_patch: 0 => 1 Comment: Setting as patch needs improvement since apparently the coverage config should set `parallel` to True. -- Ticket URL: <https://code.djangoproject.com/ticket/34810#comment:4> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/0107018a6a8235ee-e57a4474-64ad-43d2-b75a-0d14f46a3818-00%40eu-central-1.amazonses.com.
Re: [Django] #34810: Calculate coverage on subprocesses such as django-admin commands
#34810: Calculate coverage on subprocesses such as django-admin commands -+- Reporter: Jacob Walls |Owner: Jacob Type: | Walls Cleanup/optimization | Status: assigned Component: Core (Other) | Version: dev Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1| Needs documentation: 0 Needs tests: 0| Patch needs improvement: 0 Easy pickings: 0|UI/UX: 0 -+- Changes (by Jacob Walls): * has_patch: 0 => 1 Comment: [https://github.com/django/django/pull/17226 PR] -- Ticket URL: <https://code.djangoproject.com/ticket/34810#comment:3> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/0107018a61104555-0159f35b-6b2b-4e6c-837d-22b2627d7efa-00%40eu-central-1.amazonses.com.
Re: [Django] #34810: Calculate coverage on subprocesses such as django-admin commands
#34810: Calculate coverage on subprocesses such as django-admin commands -+- Reporter: Jacob Walls |Owner: Jacob Type: | Walls Cleanup/optimization | Status: assigned Component: Core (Other) | Version: dev Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 0| Needs documentation: 0 Needs tests: 0| Patch needs improvement: 0 Easy pickings: 0|UI/UX: 0 -+- Changes (by Jacob Walls): * owner: nobody => Jacob Walls * status: new => assigned -- Ticket URL: <https://code.djangoproject.com/ticket/34810#comment:2> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/0107018a61030987-45020974-ea64-42bc-8662-81af78a24218-00%40eu-central-1.amazonses.com.
Re: [Django] #34810: Calculate coverage on subprocesses such as django-admin commands
#34810: Calculate coverage on subprocesses such as django-admin commands --+ Reporter: Jacob Walls |Owner: nobody Type: Cleanup/optimization | Status: new Component: Core (Other) | Version: dev Severity: Normal| Resolution: Keywords:| Triage Stage: Accepted Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 |UI/UX: 0 --+ Changes (by Mariusz Felisiak): * stage: Unreviewed => Accepted Comment: Tentatively accepted (not sure if this is doable). -- Ticket URL: <https://code.djangoproject.com/ticket/34810#comment:1> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/0107018a5fc95f5e-bffdd1cf-5c53-4aa8-9a41-fa6cc57b5bbb-00%40eu-central-1.amazonses.com.
[Django] #34810: Calculate coverage on subprocesses such as django-admin commands
#34810: Calculate coverage on subprocesses such as django-admin commands + Reporter: Jacob Walls | Owner: nobody Type: Cleanup/optimization | Status: new Component: Core (Other) |Version: dev Severity: Normal| Keywords: Triage Stage: Unreviewed| Has patch: 0 Needs documentation: 0 |Needs tests: 0 Patch needs improvement: 0 | Easy pickings: 0 UI/UX: 0 | + Noticed during #34778 that despite good coverage for the django-admin commands in `tests/admin_scripts`, the coverage report suggests only 12% coverage for `django/core/management/templates.py`. This is because using coverage.py to trace code launched by a subprocess (and not through multiprocessing) requires [https://coverage.readthedocs.io/en/stable/subprocess.html additional configuration], e.g. adding code to sitecustomize.py or creating a .pth file. Perhaps we could look into creating a tempdir with a .pth file to run the needed coverage.py configuration while running tests. -- Ticket URL: <https://code.djangoproject.com/ticket/34810> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/0107018a55ff44bc-2ea33fcf-804f-4d3b-8b83-fc17ed1c649f-00%40eu-central-1.amazonses.com.
