Re: [Django] #34834: Use `search` role for the admin changelist search form

[Django]

#34834: Use `search` role for the admin changelist search form
-+-
 Reporter:  Thibaud Colas|Owner:  Lemuel
 Type:   |  Sta Ana
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  accessibility,   | Triage Stage:  Ready for
  screen reader, landmarks   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"969ecb8236f033d183108fb28849974da188da50" 969ecb82]:
 {{{
 #!CommitTicketReference repository=""
 revision="969ecb8236f033d183108fb28849974da188da50"
 Fixed #34834 -- Added role="search" to the admin changelist search form.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a951ea844-6db5c87e-fd59-4357-b7c8-8bf303ec96cf-00%40eu-central-1.amazonses.com.

Re: [Django] #34834: Use `search` role for the admin changelist search form

[Django]

#34834: Use `search` role for the admin changelist search form
-+-
 Reporter:  Thibaud Colas|Owner:  Lemuel
 Type:   |  Sta Ana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Ready for
  screen reader, landmarks   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a94fd2e1e-8fa9a092-870f-4764-a283-24995512d823-00%40eu-central-1.amazonses.com.

Re: [Django] #34834: Use `search` role for the admin changelist search form

[Django]

#34834: Use `search` role for the admin changelist search form
-+-
 Reporter:  Thibaud Colas|Owner:  Lemuel
 Type:   |  Sta Ana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  screen reader, landmarks   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Lemuel Sta Ana):

 Regression test added as per
 
[https://github.com/django/django/pull/17261/commits/393b524e0ddb974995cc1c3f5ab9851cf44f958d
 commit]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a947307a1-f849f1a9-9899-4867-857c-5b9407c74a8f-00%40eu-central-1.amazonses.com.

Re: [Django] #34834: Use `search` role for the admin changelist search form

[Django]

#34834: Use `search` role for the admin changelist search form
-+-
 Reporter:  Thibaud Colas|Owner:  Lemuel
 Type:   |  Sta Ana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  screen reader, landmarks   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a92ead212-6260a2c5-eaf0-4f56-8818-abed48597870-00%40eu-central-1.amazonses.com.

Re: [Django] #34834: Use `search` role for the admin changelist search form

[Django]

#34834: Use `search` role for the admin changelist search form
-+-
 Reporter:  Thibaud Colas|Owner:  Lemuel
 Type:   |  Sta Ana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  screen reader, landmarks   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Lemuel Sta Ana):

 * has_patch:  0 => 1


Comment:

 **PR**[https://github.com/django/django/pull/17261]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a91940d62-a31a186f-7a14-41fd-866f-6bc092f7a909-00%40eu-central-1.amazonses.com.

Re: [Django] #34834: Use `search` role for the admin changelist search form

[Django]

#34834: Use `search` role for the admin changelist search form
-+-
 Reporter:  Thibaud Colas|Owner:  Lemuel
 Type:   |  Sta Ana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  screen reader, landmarks   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Lemuel Sta Ana):

 * owner:  nobody => Lemuel Sta Ana
 * status:  new => assigned


Comment:

 Claiming ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a91797e49-a62b2afa-ab13-4b9c-92a3-81f364ca8760-00%40eu-central-1.amazonses.com.

Re: [Django] #34834: Use `search` role for the admin changelist search form

[Django]

#34834: Use `search` role for the admin changelist search form
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  screen reader, landmarks   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 faizan2700, you can assign yourself a ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a8d56fbf2-a7e047c2-a0ac-45c7-a4b5-db1ebec3c831-00%40eu-central-1.amazonses.com.

Re: [Django] #34834: Use `search` role for the admin changelist search form

[Django]

#34834: Use `search` role for the admin changelist search form
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:
  screen reader, landmarks   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by faizan2700):

 Please assign me this ticket. I understand what needs to be done.
 My Introduction:
 I have graduated from IIIT Pune in 2021. I am doing freelancing since
 college only, I have worked in ServiceNow and CleverTaps before currently
 I am working on my startup.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a8d4fd306-399f1a07-aa55-434f-92ab-8470b1eea5bf-00%40eu-central-1.amazonses.com.

[Django] #34834: Use `search` role for the admin changelist search form

[Django]

#34834: Use `search` role for the admin changelist search form
-+-
   Reporter:  Thibaud|  Owner:  nobody
  Colas  |
   Type: | Status:  new
  Cleanup/optimization   |
  Component: |Version:  4.2
  contrib.admin  |   Keywords:  accessibility,
   Severity:  Normal |  screen reader, landmarks
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Related: [https://code.djangoproject.com/ticket/34832 #34832],
 [https://code.djangoproject.com/ticket/34833 #34833]. Django’s
 ChangeListSearchForm and its
 
[https://github.com/django/django/blob/main/django/contrib/admin/templates/admin/search_form.html
 search_form.html] currently use `` markup for the form. It would be nice
 for screen reader users to use a `role="search"` on the form, so it’s
 explicitly identified as a search form when navigating the page by region.

 In the future it would be even better to convert the wrapping toolbar div
 to use the [https://developer.mozilla.org/en-
 US/docs/Web/HTML/Element/search search] HTML element, but browser support
 isn’t there yet.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018a8d3a95c6-d1243546-ef2a-4a71-9259-b8e307b1116a-00%40eu-central-1.amazonses.com.