Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:11 Carlton Gibson]:
 > Thanks for the ping. Yes, with the change to asgiref, it seems
 reasonable to drop the warnings. (I didn't check the internal Python
 frames again, but they're future related, and don't feature sensitive
 Django-related variables…)

 [https://github.com/django/django/pull/17484 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bdcd6fe41-b4294e1e-12e9-4355-b531-01e791612df3-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Thanks for the ping. Yes, with the change to asgiref, it seems reasonable
 to drop the warnings. (I didn't check the internal Python frames again,
 but they're future related, and don't feature sensitive Django-related
 variables…)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bd8079c4a-7219a4ca-e099-444d-929b-bab0537e8adf-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Carlton Gibson (added)


Comment:

 It was added in b00046d2c25771bed2242680b08b524a44aa9798.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bd713cf27-fbaf0bae-675d-4ba1-9f77-b5e09862fd21-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jon Janzen):

 > Django 5.0+ required asgiref 3.7+. Do you think it's time to remove this
 warning?

 Yeah that's probably a good idea, I completely missed that you added this
 warning

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bd6856783-fac3aa26-5ff1-4c72-a11d-84e30973f227-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:7 Jon Janzen]:
 > > Also, be aware that sync_to_async() and async_to_sync() are not
 compatible with @sensitive_variables (as ​documented).
 >
 > We might want to update those docs, as recent versions (>= 3.7.0) will
 hide variables from the internals of asgiref:
 https://github.com/django/asgiref/pull/383
 >
 > Changelog note for asgiref:
 https://github.com/django/asgiref/blob/main/CHANGELOG.txt#L25

 Django 5.0+ required asgiref 3.7+. Do you think it's time to remove this
 warning?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bd682bf2e-158a7a64-c784-4093-af65-835a91108808-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jon Janzen):

 > Also, be aware that sync_to_async() and async_to_sync() are not
 compatible with @sensitive_variables (as ​documented).

 We might want to update those docs, as recent versions (>= 3.7.0) will
 hide variables from the internals of asgiref:
 https://github.com/django/asgiref/pull/383

 Changelog note for asgiref:
 https://github.com/django/asgiref/blob/main/CHANGELOG.txt#L25

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bd6475bb1-cd374684-990a-4bc1-83c2-3928fd6a7510-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => needsinfo


Comment:

 Thanks for the report, I don't think you've explained the issue in enough
 detail to confirm a bug in Django. Please reopen the ticket if you can
 debug your issue and provide a sample project that reproduces the issue.
 Also, be aware that `sync_to_async()` and `async_to_sync()` are not
 compatible with `@sensitive_variables` (as
 [https://docs.djangoproject.com/en/5.0/howto/error-
 reporting/#django.views.decorators.debug.sensitive_variables documented]).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bd20aedbc-9ed1c682-b54e-4af2-9692-f482d3549a91-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Jon Janzen (added)
 * needs_better_patch:  1 => 0
 * component:  Uncategorized => Core (Other)


Comment:

 #31949

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc7ca81d6-5ff1b231-e062-4fed-8143-46d2eb6a9690-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  vagi8|Owner:  vageeshan
 Type:  Bug  |   Status:  assigned
Component:  Uncategorized|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by vagi8):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc309aeb9-b2b01996-5405-41c5-946e-7fcd1c49d4ba-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  Vageeshan Mankala|Owner:  vageeshan
 Type:  Bug  |   Status:  assigned
Component:  Uncategorized|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Vageeshan Mankala):

 * cc: Vageeshan Mankala (removed)
 * type:  Uncategorized => Bug


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc307f180-ee0763ac-110a-4e27-8c80-6a112a38e3d8-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  vagi8|Owner:  vageeshan
 Type:  Uncategorized|   Status:  assigned
Component:  Uncategorized|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by vagi8):

 * cc: vagi8 (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc3068049-02412f52-958d-4c4e-91f9-f713fc7f8648-00%40eu-central-1.amazonses.com.

Re: [Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
 Reporter:  vagi8|Owner:  vageeshan
 Type:  Uncategorized|   Status:  assigned
Component:  Uncategorized|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  @sensitive_variables,  |  Unreviewed
  @sensitive_post_parameters |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by vagi8):

 * owner:  nobody => vageeshan
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc3065ba1-a4e452c4-8a9f-4a8b-9167-ddd250d896ac-00%40eu-central-1.amazonses.com.

[Django] #34965: @sensitive_variables for coroutine func are not recursive

[Django]

#34965: @sensitive_variables for coroutine func are not recursive
-+-
   Reporter:  vagi8  |  Owner:  nobody
   Type: | Status:  new
  Uncategorized  |
  Component: |Version:  5.0
  Uncategorized  |   Keywords:
   Severity:  Normal |  @sensitive_variables,
   Triage Stage: |  @sensitive_post_parameters
  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 There is a difference in functionality of how
 @sensitive_variables/sensitive_post_parameters work for synchronous
 functions and asynchronous functions.

 Sync funcs. - It recursively hides the variables from all frames in the
 stack until new sensitive variables are defined for a frame. Example,
 Wrappers to nested function calls, variables are hidden.
 Async funcs. - It only hides the variables in the top most frame of the
 stack. Example, If there is view func with sensitive variables, and it
 also has a decorator, it hides only in the wrapper and not in the actual
 view.

 I would expect both to work in similar way. I am also deeply invested in
 the idea so I willing to contribute a PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc2fdc327-7b371f16-7924-4cef-b78f-f27b7527cd6d-00%40eu-central-1.amazonses.com.