Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
-+-
 Reporter:  Mike Lissner |Owner:  Dingning
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  async, decorator | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"549320946dfdaac6ccb6c0d3150c46db92637187" 5493209]:
 {{{#!CommitTicketReference repository=""
 revision="549320946dfdaac6ccb6c0d3150c46db92637187"
 Fixed #35030 -- Made django.contrib.auth decorators to work with async
 functions.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e184d3c49-3375ad4e-bddd-4b7e-9b26-a7e4baf3f49b-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
-+-
 Reporter:  Mike Lissner |Owner:  Dingning
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  async, decorator | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e182281a7-7597081e-476a-4ba7-a04a-47f3f35355ca-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Comment (by GitHub ):

 In [changeset:"c4df2a77761a1ae392eb5c4803b5712803d5239f" c4df2a77]:
 {{{#!CommitTicketReference repository=""
 revision="c4df2a77761a1ae392eb5c4803b5712803d5239f"
 Refs #35030 -- Added more tests for @user_passes_test decorator.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e13bcb58b-196d7b58-2a51-42e9-8820-b729c2581219-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e0086fa95-f78641be-6bef-4b23-84e8-b150460af127-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Comment (by Dingning):

 Hello, dear reviewers. I have updated my commit. Could you please review
 the pull request?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018deef95368-308188cb-e5a7-4b23-85ed-d2e955b0ac90-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Dingning):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018de0141a20-74a29717-21cc-4562-8056-acf1aae8c0c2-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d68d21b81-a55fae68-dda5-438a-9c84-e913681de9c0-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Dingning):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d67b0d091-b9151ea0-76a5-47e3-ba5b-d7d622b4403f-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Dingning):

 Hi guys, I created a topic to discuss, welcome to chat
 here(https://forum.djangoproject.com/t/about-async-version-of-the-login-
 required-decorator/27077)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d1c9c2428-05ec560f-7c6c-4a0c-979e-9d824c5ef186-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c7d2d40d0-1e2ab815-126c-4b99-87b0-56d563d74391-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Dingning):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c7cf52964-6be7c667-e9fe-44b5-8cfa-749524379ab9-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Natalia Bidart):

 Hello Dingning, thanks for your work on this ticket. Once your PR is ready
 for review, please unset the flags "Patch needs improvement" and "Needs
 documentation" so it appears in the review queue
 ([https://docs.djangoproject.com/en/dev/internals/contributing/writing-
 code/submitting-patches/#patch-style docs about this]).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c7cd96b0c-90f8d160-c495-4c17-9dc6-514ad5a32cb3-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Dingning):

 * needs_better_patch:  0 => 1


Comment:

 Here is my PR.
 https://github.com/django/django/pull/17621

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c7b52a61b-e4bd81cb-6d56-4177-b955-8d1f8237d380-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Dingning):

 * needs_docs:  0 => 1
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c7b5080ea-ae0398f4-180a-421e-804d-0f11184c4322-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions.

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  Dingning
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Dingning):

 * owner:  nobody => Dingning
 * status:  new => assigned


Comment:

 OK, I have achieved a simple demo, I think I can work on this ticket. I'll
 I will improve my code further, then submit a PR as soon as possible.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c5e6ad22f-c22ea97e-a0f9-4f0e-a615-0be61426785d-00%40eu-central-1.amazonses.com.

Re: [Django] #35030: Make django.contrib.auth decorators work with async functions. (was: Make django.contrib.auth decoratos to work with async functions.)

[Django]

#35030: Make django.contrib.auth decorators work with async functions.
--+
 Reporter:  Mike Lissner  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async, decorator  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018c5e1f9176-a9c441da-13fc-4788-9d17-612848953c29-00%40eu-central-1.amazonses.com.