Re: [Django] #35073: models.SET's callable is called when there are no objects to update.

2024-02-08 Thread Django 
#35073: models.SET's callable is called when there are no objects to update.
-+-
 Reporter:  Fabio Sangiovanni|Owner:  bcail
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed

Comment:

 In [changeset:"9c5e382b981608a26f2c55f1259d9e823fee5f15" 9c5e382b]:
 {{{#!CommitTicketReference repository=""
 revision="9c5e382b981608a26f2c55f1259d9e823fee5f15"
 Fixed #35073 -- Avoided unnecessary calling of callables used by
 SET/SET_DEFAULT in Collector.collect().
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d89cf8ef0-7293fe3f-d7da-4835-905d-a7f5f24d62a7-00%40eu-central-1.amazonses.com.

Re: [Django] #35073: models.SET's callable is called when there are no objects to update.

2024-02-08 Thread Django 
#35073: models.SET's callable is called when there are no objects to update.
-+-
 Reporter:  Fabio Sangiovanni|Owner:  bcail
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  O'ktamjon => bcail
 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d89cf14f9-6f49557a-dafe-4082-bb0d-e23d278d4843-00%40eu-central-1.amazonses.com.

Re: [Django] #35073: models.SET's callable is called when there are no objects to update.

2024-02-08 Thread Django 
#35073: models.SET's callable is called when there are no objects to update.
-+-
 Reporter:  Fabio Sangiovanni|Owner:  O'ktamjon
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bcail):

 * needs_better_patch:  1 => 0

Comment:

 I updated the PR.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d891cfbdc-1f1e511d-6005-4eae-b79c-217a517c51d3-00%40eu-central-1.amazonses.com.

Re: [Django] #35073: models.SET's callable is called when there are no objects to update.

2024-02-07 Thread Django 
#35073: models.SET's callable is called when there are no objects to update.
-+-
 Reporter:  Fabio Sangiovanni|Owner:  O'ktamjon
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d87b2a2ad-1b52c4f8-d837-4373-bd15-d261a572f39b-00%40eu-central-1.amazonses.com.

Re: [Django] #35073: models.SET's callable is called when there are no objects to update.

2024-02-05 Thread Django 
#35073: models.SET's callable is called when there are no objects to update.
-+-
 Reporter:  Fabio Sangiovanni|Owner:  O'ktamjon
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bcail):

 * has_patch:  0 => 1

Comment:

 I updated the PR.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d79ab0d33-9253b29a-dfcc-4bc0-b31d-c3eafde982c1-00%40eu-central-1.amazonses.com.

Re: [Django] #35073: models.SET's callable is called when there are no objects to update.

2024-02-02 Thread Django 
#35073: models.SET's callable is called when there are no objects to update.
-+-
 Reporter:  Fabio Sangiovanni|Owner:  O'ktamjon
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by bcail):

 I opened an [https://github.com/django/django/pull/17812 in-progress PR]
 with two unit tests, for SET and SET_DEFAULT.

 I pinged Simon on the PR, because I haven't figured out how to fix
 SET_DEFAULT yet.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d6aacfeb2-bd73453b-08f2-49e1-b264-59819bfaa48c-00%40eu-central-1.amazonses.com.

Re: [Django] #35073: models.SET's callable is called when there are no objects to update.

2024-01-01 Thread Django 
#35073: models.SET's callable is called when there are no objects to update.
-+-
 Reporter:  Fabio Sangiovanni|Owner:  O'ktamjon
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * stage:  Unreviewed => Accepted


Comment:

 We should fix that.

 I think the most straightforward solution is to only set `lazy_sub_objs =
 True` on the function returned by `SET` if the value is not a callable.
 The same problem exists for `SET_DEFAULT` when the default is callable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cc5edfa69-3707c88a-4a75-42d9-863d-b7f76052fc7b-00%40eu-central-1.amazonses.com.

Re: [Django] #35073: models.SET's callable is called when there are no objects to update. (was: New behavior of ForeignKey with on_delete=models.SET (Django 4.2 and 5.0))

2024-01-01 Thread Django 
#35073: models.SET's callable is called when there are no objects to update.
-+-
 Reporter:  Fabio Sangiovanni|Owner:  O'ktamjon
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Simon Charette (added)
 * type:  Uncategorized => Bug


Comment:

 Thanks for the report. Regression in
 0701bb8e1f1771b36cdde45602ad377007e372b3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cc51d9ced-0c11cbc5-daa8-4a7f-a8c6-f42fcaab9526-00%40eu-central-1.amazonses.com.