Re: [Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
-+-
 Reporter:  minusf   |Owner:  Can Huynh
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"ef23305a19c39b26bc25e2df68355743652e77ab" ef23305]:
 {{{#!CommitTicketReference repository=""
 revision="ef23305a19c39b26bc25e2df68355743652e77ab"
 [5.0.x] Fixed #35280 -- Improved iriencode filter example in docs.

 Backport of a7baa874d8452859060ecd28c83cecd566f756e3 from main
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e297cbdca-23eb9f18-56cc-4ded-8f53-9c0f84b45669-00%40eu-central-1.amazonses.com.

Re: [Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
-+-
 Reporter:  minusf   |Owner:  Can Huynh
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"a7baa874d8452859060ecd28c83cecd566f756e3" a7baa87]:
 {{{#!CommitTicketReference repository=""
 revision="a7baa874d8452859060ecd28c83cecd566f756e3"
 Fixed #35280 -- Improved iriencode filter example in docs.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e297c76f1-f495b437-cf9c-49c2-84c8-84663ef66fa0-00%40eu-central-1.amazonses.com.

Re: [Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
-+-
 Reporter:  minusf   |Owner:  Can Huynh
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e28a8b746-06695500-cee7-432a-a421-636112fc86c7-00%40eu-central-1.amazonses.com.

Re: [Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
---+-
 Reporter:  minusf |Owner:  Can Huynh
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1
 * needs_better_patch:  0 => 1

Comment:

 [https://github.com/django/django/pull/17959 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e238f3a33-69b917ab-1407-4d74-88d5-0b4e85030626-00%40eu-central-1.amazonses.com.

Re: [Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
---+-
 Reporter:  minusf |Owner:  Can Huynh
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+-
Comment (by Can Huynh):

 Thank you! Preparing the patch now.

 Replying to [comment:3 minusf]:
 > there is no monopoly on pull requests, go ahead Can :D
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e21b6d529-809d5e2e-5499-4211-a9c9-70a54e972993-00%40eu-central-1.amazonses.com.

Re: [Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
---+-
 Reporter:  minusf |Owner:  Can Huynh
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by Can Huynh):

 * owner:  nobody => Can Huynh
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e2126bbb4-119a4dbb-52dc-4a2c-ab35-2b6299fc2876-00%40eu-central-1.amazonses.com.

Re: [Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
---+
 Reporter:  minusf |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Comment (by minusf):

 there is no monopoly on pull requests, go ahead Can :D
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e1d47f965-e323c13b-5f7a-47f9-9572-190c14bab656-00%40eu-central-1.amazonses.com.

Re: [Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
---+
 Reporter:  minusf |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Comment (by Can Huynh):

 I would love to help if @minusf couldn't allocate the time. Lmk!
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e1cb7d704-f37e35b0-31b2-4ddd-9df9-1a98addb0e73-00%40eu-central-1.amazonses.com.

Re: [Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
---+
 Reporter:  minusf |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted

Comment:

 Good catch, we could use an example from the docstring, `'/I ♥ Django/`.
 Would you like to prepare a patch?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e18ecf551-bc9a1363-93c4-4a02-a108-bbfeff5079d5-00%40eu-central-1.amazonses.com.

[Django] #35280: iriencode example incorrect

[Django]

#35280: iriencode example incorrect
-+
   Reporter:  minusf |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Documentation  |Version:  5.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 https://docs.djangoproject.com/en/5.0/ref/templates/builtins/#iriencode

   If value is "?test=1=2", the output will be "?test=1me=2".

 This is not the case as by default "&" is a safe character for iriencode:
 https://github.com/django/django/blob/main/django/utils/encoding.py#L135.

 It is urlencode that does that conversion. iriencode is more for non-ascii
 characters in my understanding, and using both at the same time is
 supported:
 {{{
 value|urlencode|iriencode
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e18cf8729-8e50d4e9-6f58-4ac1-9daf-d270ba485d42-00%40eu-central-1.amazonses.com.