Re: [Django] #35354: Simplify ASGIRequest path handling.

[Django]

#35354: Simplify ASGIRequest path handling.
-+-
 Reporter:  Carlton Gibson   |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  closed
Component:  HTTP handling|  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  asgi | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Natalia <124304+nessita@…>):

 In [changeset:"58061fd2b4c4b66c0fd3db8026c8b5e369ed9ec3" 58061fd2]:
 {{{#!CommitTicketReference repository=""
 revision="58061fd2b4c4b66c0fd3db8026c8b5e369ed9ec3"
 [5.0.x] Refs #35354 -- Clarified FORCE_SCRIPT_NAME docs.

 Backport of ca5cd3e3e8e53f15e68ccd727ec8fe719cc48099 from main
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eafbeb57a-f9ed113e-01d9-4f09-9611-e46971340956-00%40eu-central-1.amazonses.com.

Re: [Django] #35354: Simplify ASGIRequest path handling.

[Django]

#35354: Simplify ASGIRequest path handling.
-+-
 Reporter:  Carlton Gibson   |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  closed
Component:  HTTP handling|  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  asgi | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson ):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"bcd255cd5ca0a1e686d276cca71f45ec400d84a2" bcd255cd]:
 {{{#!CommitTicketReference repository=""
 revision="bcd255cd5ca0a1e686d276cca71f45ec400d84a2"
 Fixed #35354 -- Simplified ASGIRequest path handling.

 Following the ASGI HTTP Connection Scope docs[0], the provided `path`
 is already the correct value that Django requires.

 In combination with `root_path`, from which `script_name` is derived,
 the `path_info` variable is set. It's then redundant to
 re-calculate `path` from `script_name` and `path_info`.

 See also, a clarifying discussion on the ASGIref repo[1].

 [0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-connection-
 scope
 [1]: https://github.com/django/asgiref/issues/424
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eafbdfa85-451e10fe-2f76-42d5-9a28-9ee6da1c68d9-00%40eu-central-1.amazonses.com.

Re: [Django] #35354: Simplify ASGIRequest path handling.

[Django]

#35354: Simplify ASGIRequest path handling.
-+-
 Reporter:  Carlton Gibson   |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  closed
Component:  HTTP handling|  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  asgi | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Carlton Gibson ):

 In [changeset:"ca5cd3e3e8e53f15e68ccd727ec8fe719cc48099" ca5cd3e3]:
 {{{#!CommitTicketReference repository=""
 revision="ca5cd3e3e8e53f15e68ccd727ec8fe719cc48099"
 Refs #35354 -- Clarified FORCE_SCRIPT_NAME docs.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eafbdfaad-d163fbe3-ca79-4887-90b6-5be67a1ce447-00%40eu-central-1.amazonses.com.

Re: [Django] #35354: Simplify ASGIRequest path handling.

[Django]

#35354: Simplify ASGIRequest path handling.
-+-
 Reporter:  Carlton Gibson   |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  asgi | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eafa3443b-4187b8f1-741b-4202-82da-edfcd899d118-00%40eu-central-1.amazonses.com.

Re: [Django] #35354: Simplify ASGIRequest path handling.

[Django]

#35354: Simplify ASGIRequest path handling.
-+-
 Reporter:  Carlton Gibson   |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  asgi | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Smith):

 * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ead929b64-d2e41150-abe0-470f-a94b-28afc884c82a-00%40eu-central-1.amazonses.com.

Re: [Django] #35354: Simplify ASGIRequest path handling.

[Django]

#35354: Simplify ASGIRequest path handling.
-+-
 Reporter:  Carlton Gibson   |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  asgi | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Carlton Gibson:

Old description:

> Following the ASGI HTTP Connection Scope docs[0], the provided `path` is
> already the correct value that Django requires.
>
> In combination with `root_path`, from which `script_name` is derived, the
> `path_info` variable can is set.
> It's then redundant to re-calculate `path` from `script_name` and
> `path_info`.
>
> See also, a clarifying discussion on the ASGIref repo[1].
>
> [0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-
> connection-scope
> [1]: https://github.com/django/asgiref/issues/424

New description:

 Following the ASGI HTTP Connection Scope docs[0], the provided `path` is
 already the correct value that Django requires.

 In combination with `root_path`, from which `script_name` is derived, the
 `path_info` variable is set.
 It's then redundant to re-calculate `path` from `script_name` and
 `path_info`.

 See also, a clarifying discussion on the ASGIref repo[1].

 [0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-connection-
 scope
 [1]: https://github.com/django/asgiref/issues/424

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ead6a2032-3fff5387-c674-44a5-86da-8550418296c4-00%40eu-central-1.amazonses.com.

Re: [Django] #35354: Simplify ASGIRequest path handling.

[Django]

#35354: Simplify ASGIRequest path handling.
-+-
 Reporter:  Carlton Gibson   |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  asgi | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * cc: Andrew Godwin (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ead5dfb7d-00aea3b0-2feb-42c6-ae9c-a11c351d0d0b-00%40eu-central-1.amazonses.com.

Re: [Django] #35354: Simplify ASGIRequest path handling.

[Django]

#35354: Simplify ASGIRequest path handling.
-+-
 Reporter:  Carlton Gibson   |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  asgi | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * owner:  nobody => Carlton Gibson

Comment:

 [https://github.com/django/django/pull/18050 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ead5d70ba-66190fa2-308d-4b71-bb7a-2b880ddbb970-00%40eu-central-1.amazonses.com.

[Django] #35354: Simplify ASGIRequest path handling.

[Django]

#35354: Simplify ASGIRequest path handling.
+--
   Reporter:  Carlton Gibson|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  assigned
  Component:  HTTP handling |Version:  5.0
   Severity:  Normal|   Keywords:  asgi
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+--
 Following the ASGI HTTP Connection Scope docs[0], the provided `path` is
 already the correct value that Django requires.

 In combination with `root_path`, from which `script_name` is derived, the
 `path_info` variable can is set.
 It's then redundant to re-calculate `path` from `script_name` and
 `path_info`.

 See also, a clarifying discussion on the ASGIref repo[1].

 [0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-connection-
 scope
 [1]: https://github.com/django/asgiref/issues/424
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ead5be9d3-da848f7b-e687-4783-8801-33653c016557-00%40eu-central-1.amazonses.com.