Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  Joshua van Besouw|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Simon Charette):

 It will not be backported to 4.2 as it's long term support at this point
 and only receive security and data loss fixing patches at this point.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018fed6d9482-32117f0e-27fd-4c67-8795-aec546d7addd-00%40eu-central-1.amazonses.com.

Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  Joshua van Besouw|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Joshua van Besouw):

 Will this fix be released on the version 4.2 series? Or should I expect to
 only see it getting applied to version 5.0+ ?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018fed2667b2-7f335f9e-f36a-40cc-b0cb-58786ff8f1d3-00%40eu-central-1.amazonses.com.

Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  Joshua van Besouw|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by nessita <124304+nessita@…>):

 In [changeset:"195d885ca01b14e3ce9a1881c3b8f7074f953736" 195d885]:
 {{{#!CommitTicketReference repository=""
 revision="195d885ca01b14e3ce9a1881c3b8f7074f953736"
 Refs #35356 -- Clarified select related with masked field logic.

 By always including related objects in the select mask via adjusting the
 defer logic (_get_defer_select_mask()), it becomes possible for
 select_related_descend() to treat forward and reverse relationships
 indistinctively.

 This work also simplifies and adds comments to
 select_related_descend() to make it easier to understand.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f0bbf6376-39fecda8-9cd8-45dd-b34e-9dcdf0d94ee2-00%40eu-central-1.amazonses.com.

Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  Joshua van Besouw|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by nessita <124304+nessita@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"83f5478225588f31e7cbbfed63a4a2b936abc03f" 83f54782]:
 {{{#!CommitTicketReference repository=""
 revision="83f5478225588f31e7cbbfed63a4a2b936abc03f"
 Fixed #35356 -- Deferred self-referential foreign key fields adequately.

 While refs #34612 surfaced issues with reverse one-to-one fields
 deferrals, it missed that switching to storing remote fields would break
 self-referential relationships.

 This change switches to storing related objects in the select mask
 instead of remote fields to prevent collisions when dealing with
 self-referential relationships that might have a different directional
 mask.

 Despite fixing #21204 introduced a crash under some self-referential
 deferral conditions, it was simply not working even before that as it
 aggregated the sets of deferred fields by model.

 Thanks Joshua van Besouw for the report and Mariusz Felisiak for the
 review.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f0bbf6360-34612929-40b9-45e0-9726-817f78d93db4-00%40eu-central-1.amazonses.com.

Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  Joshua van Besouw|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Simon Charette
 * stage:  Accepted => Ready for checkin
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ed7ccf4af-a4296a38-5279-40b5-8bfb-25a9dd1358ee-00%40eu-central-1.amazonses.com.

Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  Joshua van Besouw|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Joshua van Besouw):

 Thanks for the quick patch on this!

 I can confirm, form my end, that this patch fixes the issue I was
 encountering. The `FieldError` was not raised and the following SQL was
 used in the resulting query:

 {{{
 SELECT
 "test_project_example"."id",
 "test_project_example"."name",
 "test_project_example"."source_id",
 T2."id",
 T2."name",
 T3."id",
 T3."name"
 FROM
 "test_project_example"
 LEFT OUTER JOIN "test_project_example" T2 ON (
 "test_project_example"."source_id" = T2."id"
 )
 LEFT OUTER JOIN "test_project_example" T3 ON (
 "test_project_example"."id" = T3."source_id"
 )
 ORDER BY
 "test_project_example"."id" ASC
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ebd6ec457-11c3a3d0-0a88-4757-957d-22147fcffc12-00%40eu-central-1.amazonses.com.

Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  Joshua van Besouw|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eb16f437e-54a7db2e-4cf6-4927-9f4b-c718ff3259a0-00%40eu-central-1.amazonses.com.

Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  Joshua van Besouw|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Simon Charette):

 #34612 could have fixed it but it took a different approach.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eb1178b19-466db6f6-fbe6-4233-98de-832ef701817b-00%40eu-central-1.amazonses.com.

Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  Joshua van Besouw|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * stage:  Unreviewed => Accepted

Comment:

 {{{!diff
 diff --git a/tests/defer_regress/models.py b/tests/defer_regress/models.py
 index dd492993b7..38ba4a622f 100644
 --- a/tests/defer_regress/models.py
 +++ b/tests/defer_regress/models.py
 @@ -10,6 +10,12 @@ class Item(models.Model):
  text = models.TextField(default="xyzzy")
  value = models.IntegerField()
  other_value = models.IntegerField(default=0)
 +source = models.OneToOneField(
 +"self",
 +related_name="destination",
 +on_delete=models.CASCADE,
 +null=True,
 +)


  class RelatedItem(models.Model):
 diff --git a/tests/defer_regress/tests.py b/tests/defer_regress/tests.py
 index 10100e348d..d8b2186f0a 100644
 --- a/tests/defer_regress/tests.py
 +++ b/tests/defer_regress/tests.py
 @@ -309,6 +309,21 @@ def test_only_reverse_many_to_many_ignored(self):
  with self.assertNumQueries(1):
  self.assertEqual(Item.objects.only("request").get(), item)

 +def test_self_referential(self):
 +first = Item.objects.create(name="first", value=1)
 +second = Item.objects.create(name="second", value=2,
 source=first)
 +with self.assertNumQueries(1):
 +deferred_first, deferred_second = (
 +Item.objects.select_related("source", "destination")
 +.only("name", "source__name", "destination__value")
 +.order_by("pk")
 +)
 +with self.assertNumQueries(0):
 +self.assertEqual(deferred_first.name, first.name)
 +self.assertEqual(deferred_second.name, second.name)
 +self.assertEqual(deferred_second.source.name, first.name)
 +self.assertEqual(deferred_first.destination.name,
 second.name)
 +

  class DeferDeletionSignalsTests(TestCase):
  senders = [Item, Proxy]
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eb1049105-540492a3-8c8b-4fe9-9fff-62469b39c21f-00%40eu-central-1.amazonses.com.

Re: [Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
 Reporter:  OdinsPlasmaRifle |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Simon Charette):

 Likely related to #21204 (b3db6c8dcb5145f7d45eff517bcd96460475c879) which
 was merged in 4.2.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eb03c332d-2a5a5d96-b67c-44f3-ad20-63af84e84a5a-00%40eu-central-1.amazonses.com.

[Django] #35356: Issue with OneToOneField and recursive relationships in select_related() and only().

[Django]

#35356: Issue with OneToOneField and recursive relationships in select_related()
and only().
-+-
   Reporter:  Joshua |  Owner:  nobody
  van Besouw |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  4.2
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 In Django a 4.2 project, if you have a model with a recursive relationship
 `OneToOneField` like this:

 {{{
 class Example(models.Model):
 name = models.CharField(max_length=32)
 source = models.OneToOneField(
 'self', related_name='destination', on_delete=models.CASCADE
 )
 }}}

 And then query this model using:

 {{{
 Example.objects.select_related(
 "source",
 "destination",
 ).only(
 "name",
 "source__name",
 "destination__name",
 ).all()
 }}}

 It throws the following error:

 {{{
 django.core.exceptions.FieldError: Field Example.source cannot be both
 deferred and traversed using select_related at the same time.
 }}}

 **Expected behavior:**

 The queryset should apply the `select_related()` and `only()` without an
 exception occurring as the `only()` is specifying sub fields of the fields
 in the `select_related()`. Or at least this is how it used to behave.

 Interestingly, if you change the queryset to the following, it works
 without any issues:

 {{{
 Example.objects.select_related("source").only("name",
 "source__name").all()
 }}}

 And vice versa also works:

 {{{
 Example.objects.select_related("destination").only("name",
 "destination__name").all()
 }}}

 **Effected versions:**

 This error occurs in version 4.2+ of Django.

 This worked as expected in all versions of Django 4.1.

 As far as I can tell, this is a regression as a brief search doesn't
 indicate this functionality was explicitly changed at any point. I have
 not tested whether this is only an issue with recursive relationships or a
 general issues with reverse relationships.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eafeb8a9f-3633728c-5354-4060-b9fc-950df6b73653-00%40eu-central-1.amazonses.com.