Re: [Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
 Reporter:  john-parton  |Owner:  Jonny
 |  Park
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"c0b0ce85ede1f1baf8826fb6c10c23f9adcbcca3" c0b0ce8]:
 {{{#!CommitTicketReference repository=""
 revision="c0b0ce85ede1f1baf8826fb6c10c23f9adcbcca3"
 Fixed #35384 -- Raised FieldError when saving a file without a name to
 FileField.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f7bb46837-bc603893-61fc-4851-9d8e-4133207a14fd-00%40eu-central-1.amazonses.com.

Re: [Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
 Reporter:  john-parton  |Owner:  Jonny
 |  Park
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f70aa2b91-fc66c468-f6fe-4809-a9d5-77e2f113fbc1-00%40eu-central-1.amazonses.com.

Re: [Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
 Reporter:  john-parton  |Owner:  Jonny
 |  Park
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f62a0a87e-33e10957-b0a8-4b5d-824c-9333ab411757-00%40eu-central-1.amazonses.com.

Re: [Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
 Reporter:  john-parton  |Owner:  Jonny
 |  Park
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f389495b7-ccebb078-c598-4d80-9743-b7335e594ade-00%40eu-central-1.amazonses.com.

Re: [Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
 Reporter:  john-parton  |Owner:  Jonny
 |  Park
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Jonny Park):

 The patch will still not pass `test_can_reread_content_file` at
 https://github.com/john-parton/django-file-field-no-
 name/blob/dc557c641552b02623f50ef044d73435b9e97ead/test_app/tests.py#L74-L83
 I think it deserves it's own ticket and disccusion.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f22ac5e18-246d7b2b-67ba-4d27-8aeb-dd9621ac35b3-00%40eu-central-1.amazonses.com.

Re: [Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
 Reporter:  john-parton  |Owner:  Jonny
 |  Park
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jonny Park):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f22941d76-13f6aa88-88d4-47d7-b9b1-77e0d82b529e-00%40eu-central-1.amazonses.com.

Re: [Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
 Reporter:  john-parton  |Owner:  Jonny
 |  Park
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jonny Park):

 * owner:  nobody => Jonny Park
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f1304ee3a-8ec09105-1206-429f-a424-5b00499f2a0d-00%40eu-central-1.amazonses.com.

Re: [Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
 Reporter:  john-parton  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Lily Foote):

 * cc: Lily Foote (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ef08b9701-196bc228-aaf1-4104-b27b-a5473e0f8d23-00%40eu-central-1.amazonses.com.

Re: [Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
 Reporter:  john-parton  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * stage:  Unreviewed => Accepted

Comment:

 Thank you for the analysis and discussions 
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eefd9a6c1-4f48846a-31cf-4ed6-890a-baf439afcbd1-00%40eu-central-1.amazonses.com.

[Django] #35384: Assigning a file without a name property to a FileField results in file getting discarded silently

[Django]

#35384: Assigning a file without a name property to a FileField results in file
getting discarded silently
-+-
   Reporter:  john-  |  Owner:  nobody
  parton |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  5.0
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 If you assign a File object without a name (A ContentFile or otherwise) to
 an instance and then save it, the storage backend is not invoked, the data
 isn't persisted, and the column isn't updated. All without raising an
 error or even a logger message.

 We've isolated the behavior here: https://github.com/john-parton/django-
 file-field-no-
 name/blob/dc557c641552b02623f50ef044d73435b9e97ead/test_app/tests.py#L28-L41

 There's some discussion here: https://forum.djangoproject.com/t/setting-
 filefield-imagefield-where-file-has-no-name/30192/24
 The general consensus is that some error should be raised.

 I'll see if I can submit a patch. I flagged this as Database layer,
 because the patch will likely be in models.files, not the storage backend.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018eedfdf96b-3b339c3a-2f57-4e27-82a3-2d21c7b3a706-00%40eu-central-1.amazonses.com.