Re: [Django] #35401: Document the `conditional_page` decorator

[Django]

#35401: Document the `conditional_page` decorator
-+-
 Reporter:  Keryn Knight |Owner:  Lufafa
 Type:   |  Joshua
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"e2428292abaca4758a7508175d31667fe2dff57c" e2428292]:
 {{{#!CommitTicketReference repository=""
 revision="e2428292abaca4758a7508175d31667fe2dff57c"
 Fixed #35401 -- Documented the conditional_page() decorator.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701900c2561c7-fc87fa9b-d435-4934-8d80-2f13e376cd27-00%40eu-central-1.amazonses.com.

Re: [Django] #35401: Document the `conditional_page` decorator

[Django]

#35401: Document the `conditional_page` decorator
-+-
 Reporter:  Keryn Knight |Owner:  Lufafa
 Type:   |  Joshua
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

 In [changeset:"708b01c79501eb9fd73cc5f01a724205d70a6d30" 708b01c7]:
 {{{#!CommitTicketReference repository=""
 revision="708b01c79501eb9fd73cc5f01a724205d70a6d30"
 Refs #35401 -- Linked the CsrfViewMiddleware docs to the csrf_protect()
 decorator.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701900c256198-d9079ed3-8c6f-4e74-8ed3-487551aeefba-00%40eu-central-1.amazonses.com.

Re: [Django] #35401: Document the `conditional_page` decorator

[Django]

#35401: Document the `conditional_page` decorator
-+-
 Reporter:  Keryn Knight |Owner:  Lufafa
 Type:   |  Joshua
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701900c023212-4eb119d3-384b-43e3-9681-cfcac29b19f7-00%40eu-central-1.amazonses.com.

Re: [Django] #35401: Document the `conditional_page` decorator

[Django]

#35401: Document the `conditional_page` decorator
-+-
 Reporter:  Keryn Knight |Owner:  Lufafa
 Type:   |  Joshua
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Lufafa Joshua):

 * needs_better_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018fdd2f4815-bd5be15c-9d3d-4bb9-9ff5-6976431effd0-00%40eu-central-1.amazonses.com.

Re: [Django] #35401: Document the `conditional_page` decorator

[Django]

#35401: Document the `conditional_page` decorator
-+-
 Reporter:  Keryn Knight |Owner:  Lufafa
 Type:   |  Joshua
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f62f721c1-da170daa-c4bb-4098-988e-af1785b71b45-00%40eu-central-1.amazonses.com.

Re: [Django] #35401: Document the `conditional_page` decorator

[Django]

#35401: Document the `conditional_page` decorator
-+-
 Reporter:  Keryn Knight |Owner:  Lufafa
 Type:   |  Joshua
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Lufafa Joshua):

 * has_patch:  0 => 1

Comment:

 [https://github.com/django/django/pull/18150 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f5cb5d6a5-579d7da6-4cd4-4036-81b4-fbab46819a7f-00%40eu-central-1.amazonses.com.

Re: [Django] #35401: Document the `conditional_page` decorator

[Django]

#35401: Document the `conditional_page` decorator
-+-
 Reporter:  Keryn Knight |Owner:  Lufafa
 Type:   |  Joshua
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Lufafa Joshua):

 * owner:  nobody => Lufafa Joshua
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f249227be-6de746c1-7d04-402c-bf12-838463e59ca1-00%40eu-central-1.amazonses.com.

Re: [Django] #35401: Document the `conditional_page` decorator

[Django]

#35401: Document the `conditional_page` decorator
--+
 Reporter:  Keryn Knight  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Sarah Boyce):

 * stage:  Unreviewed => Accepted
 * type:  Uncategorized => Cleanup/optimization

Comment:

 Good find, thank you!
 It might also make sense for the
 ​[https://docs.djangoproject.com/en/dev/ref/middleware/#csrf-protection-
 middleware CsrfViewMiddleware] to similarly mention
 
[https://docs.djangoproject.com/en/5.0/ref/csrf/#django.views.decorators.csrf.csrf_protect
 csrf_protect].
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f10c87773-d12a9b54-139f-4f91-a0c1-d7b2c31184cc-00%40eu-central-1.amazonses.com.

[Django] #35401: Document the `conditional_page` decorator

[Django]

#35401: Document the `conditional_page` decorator
-+
   Reporter:  Keryn Knight   |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  dev
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 The [https://docs.djangoproject.com/en/dev/ref/middleware/#module-
 django.middleware.gzip GZip Middleware documentation] makes mention of the
 
[https://docs.djangoproject.com/en/dev/topics/http/decorators/#django.views.decorators.gzip.gzip_page
 gzip_page decorator], but the
 [https://docs.djangoproject.com/en/dev/ref/middleware/#module-
 django.middleware.http Conditional GET middleware] doesn't mention there's
 an equivalent `conditional_page` decorator, likely ecause there's no
 mention of that in the
 [https://docs.djangoproject.com/en/dev/topics/http/decorators/ HTTP
 decorators] or in the [https://docs.djangoproject.com/en/dev/topics
 /conditional-view-processing/ Conditional View Processing] topics.

 As far as I can tell, the named decorator has been around since
 
[https://github.com/django/django/blob/stable/0.90.x/django/views/decorators/http.py#L9
 0.9x] and it's probably just accidentally not described anywhere, when
 everything else in that module is.

 See also: #6181 and [https://www.b-list.org/weblog/2007/dec/11/http/ this
 blog post describing the intent, from James Bennett back in 2007] (yay for
 cool URIs which haven't suffered link rot!)
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f1024518f-6b45fd94-35ea-495c-b8d7-cbd2a309763a-00%40eu-central-1.amazonses.com.