Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
 Reporter:  oBeattie (oliver@…   |Owner:  dlanger
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  nan, infinity,   |  Needs documentation:  0
  mysql, float   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-

Comment (by dlanger):

 https://github.com/django/django/pull/1559 passes on 2.7 with sqlite and
 MySQL.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/088.c74bb62d230a117b75b9a7edebbca332%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
 Reporter:  oBeattie (oliver@…   |Owner:  dlanger
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  nan, infinity,   |  Needs documentation:  0
  mysql, float   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"cc957cb16cfdad7e6c9e97dc885fc415abbf5eaa"]:
 {{{
 #!CommitTicketReference repository=""
 revision="cc957cb16cfdad7e6c9e97dc885fc415abbf5eaa"
 Fixed #4287 -- Fixed NaN and +/- Infinity handling in FloatField

 NaN, +Inf, and -Inf are no longer valid values for FloatFields.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/088.f37ed09aea7c740e31369a6a77e78709%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
 Reporter:  oBeattie (oliver@…   |Owner:  dlanger
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  nan, infinity,   |  Needs documentation:  0
  mysql, float   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by dlanger):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/088.9ea6f8c1156ec0c26f2e2d8c708869b6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
 Reporter:  oBeattie (oliver@…   |Owner:  dlanger
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  nan, infinity,   |  Needs documentation:  0
  mysql, float   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by dlanger):

 * status:  new => assigned
 * owner:  nobody => dlanger


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/088.1239ab969cbb47d39b75a2eccdb820e5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
 Reporter:  oBeattie (oliver@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  nan, infinity,   |  Needs documentation:  0
  mysql, float   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by maxime.bargiel@…):

 * keywords:  infinity, mysql, float => nan, infinity, mysql, float
 * cc: maxime.bargiel@… (added)


Comment:

 There was a similar issue with DecimalField validation (see
 https://code.djangoproject.com/ticket/) that has been fixed by simply
 rejecting float('inf') and float('nan') values during validation.

 In Django 1.4.2, custom validation needs to be implemented by the
 developers to exclude NaN and Inf, otherwise the error described in this
 ticket will occur. Nothing leads me to believe it's different in Django
 1.5. Is there a reason why FloatFields should behave differently than
 DecimalFields with regards to NaN/Inf? While I understand that it might be
 interesting to have support for NaN/Inf saved in the DB, I think it's more
 important to have a robust system until this feature is supported.

 If necessary, I'll open a new ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
 Reporter:  oBeattie (oliver@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  SVN
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  infinity, mysql, |  Needs documentation:  0
  float  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-

Comment (by adamnelson):

 As of !MySQL 5.1.24, infinite values
 [http://dev.mysql.com/doc/refman/5.1/en/out-of-range-and-overflow.html
 produces a NULL result instead of +/-inf]. I'm not sure if this changes
 the test at all and I'm presuming !MySQL < 5.1.24 isn't much supported
 anyway - which would be consistent with !Postgres 8.1 no longer being
 supported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
   Reporter:  oBeattie   |  Owner:  nobody
  (oliver@…  | Status:  new
   Type:  Bug|  Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:  infinity, mysql,
   Triage Stage:  Accepted   |  float
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  1
  UI/UX:  0  |  Easy pickings:  0
-+-
Changes (by calmez):

 * cc: calmez (added)
 * ui_ux:   => 0


Comment:

 I did another patch that adds the feature to enable saving infinity values
 on !FloatFields. After enabling this a check happens if the used database
 is supporting this. By default this support is disabled. I enabled it for
 the sqlite backend since it can store infinity values in float columns.
 Now the user can decide to be able to store infinity. If the user's setup
 does not allow storing infinity the reaction to that will be more
 appropriate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
   Reporter:  oBeattie   |  Owner:  nobody
  (oliver@…  | Status:  new
   Type:  Bug|  Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN|   Severity:  Normal
 Resolution: |   Keywords:  infinity, mysql,
   Triage Stage:  Accepted   |  float
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  1
 |  Easy pickings:  0
-+-
Changes (by lukeplant):

 * needs_tests:  0 => 1
 * easy:   => 0


Comment:

 As discussed on django-devs, the approach in this patch is certainly not
 one we would consider. We will not work around lack of support for this
 feature in the database backend, and certainly not with magic values.

 So, given that the original bug is basically fixed for DBs that support
 it, the only thing left to do for this ticket, as Malcolm said, is to add
 tests for the DBs that do support it.

 So I'm marking as 'needs tests' for that reason, and so that this ticket
 does not appear on the 'patches needing review' report - but not to say
 that the current patch would be appropriate and just needs tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
   Reporter:  oBeattie   |Owner:  nobody
  (oliver@…  |   Status:  new
   Type:  Bug|Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:  infinity, mysql,
   Triage Stage:  Accepted   |  float
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  0  |  Needs tests:  0
-+-
Changes (by calmez):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4287: FloatField will not handle infinity values

[Django]

#4287: FloatField will not handle infinity values
-+-
   Reporter:  oBeattie   |Owner:  nobody
  (oliver@…  |   Status:  new
   Type:  Bug|Component:  Database layer
  Milestone: |  (models, ORM)
Version:  SVN| Severity:  Normal
 Resolution: | Keywords:  infinity, mysql,
   Triage Stage:  Accepted   |  float
Needs documentation:  0  |Has patch:  0
Patch needs improvement:  0  |  Needs tests:  0
-+-

Comment (by calmez):

 I looked at this with django from trunk and could reproduce the bug
 (working in sqlite3, not working in mysql).[[BR]]
 I had a look at mysql an found out that it is not possible to store
 infinity values in DOUBLE columns because "Standard SQL's FLOAT (not just
 MySQL's) is *not* an IEEE754 float" [#ref1 (1)].[[BR]]
 I patched it by using the smallest (-2147483648) and the biggest
 (2147483647) float value as -inf and inf.

 Would it be okay to fix that bug that way?

 
 [=#ref1 (1)] http://forums.mysql.com/read.php?39,220571,220573#msg-220573

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.