Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
-+-
 Reporter:  Scott Sinclair   |Owner:  bmispelon
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Forms|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  feature  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Tim Graham ):

 In [changeset:"797d742662a47417ab875b7a1f5d7919caf5363f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="797d742662a47417ab875b7a1f5d7919caf5363f"
 Removed django.forms.widgets.RadioInput per deprecation timeline.

 refs #4592.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bec6ce970aa7ca28d18db3dfee565437%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
-+-
 Reporter:  Scott Sinclair   |Owner:  bmispelon
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Forms|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  feature  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Claude Paroz ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9ac4dbd7b53d187ca54f28e247d3a120660938ca"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9ac4dbd7b53d187ca54f28e247d3a120660938ca"
 Fixed #4592: Made CheckboxSelectMultiple more like RadioSelect

 I refactored RadioSelect and CheckboxSelectMultiple to
 make them inherit from a base class, allowing them to share
 the behavior of being able to iterate over their subwidgets.

 Thanks to Matt McClanahan for the initial patch and to
 Claude Paroz for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
-+-
 Reporter:  Scott Sinclair   |Owner:  bmispelon
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Forms|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  feature  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by claudep):

 Replying to [comment:16 bmispelon]:
 > One thing to note is the disappearance of
 `django.forms.widgets.RadioInput` which was not part of the public API
 (it's not in `__all__` and was not documented anywhere).
 > If needed, it would be possible to re-introduce it as an alias of the
 new `RadioChoiceInput` with a deprecationwarning.

 Yes, I think that adding a deprecation shim for `RadioInput` would be a
 good thing, as it does not cost us much. See
 http://djangosnippets.org/snippets/2159/ for an example of a `RadioInput`
 usage. Apart from that, the patch is RFC.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
-+-
 Reporter:  Scott Sinclair   |Owner:  bmispelon
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Forms|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  feature  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by bmispelon):

 Here's the link to the pull request:
 https://github.com/django/django/pull/1011/files

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
-+-
 Reporter:  Scott Sinclair   |Owner:  bmispelon
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Forms|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  feature  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by bmispelon):

 * cc: bmispelon@… (added)
 * owner:  nobody => bmispelon
 * status:  new => assigned
 * needs_better_patch:  1 => 0


Comment:

 I've brought  Matt McClanahan's old patch up to date and added some
 documentation [1]

 The tests pass without modification so this change should be completely
 backwards-compatible (I was actually surprised at how well it worked).

 One thing to note is the disappearance of
 `django.forms.widgets.RadioInput` which was not part of the public API
 (it's not in `__all__` and was not documented anywhere).
 If needed, it would be possible to re-introduce it as an alias of the new
 `RadioChoiceInput` with a deprecationwarning.

 In my branch, the commit for this ticket depends on two other ones: #4117
 and #19874 which are somewhat related.

 [1] https://github.com/bmispelon/django/compare/ticket-4592

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
+-
   Reporter:  Scott Sinclair|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Milestone:|  Component:  Forms
Version:  SVN   |   Severity:  Normal
 Resolution:|   Keywords:  feature
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  1 |  Easy pickings:  0
+-
Changes (by lupino):

 * easy:   => 0


Comment:

 Furthermore, I'd like to add that the current hard-coded output is not
 consistent with the output of someform.as_ul, which renders checkboxes
 like

 {{{
 Blubb: 
 }}}
 whereas the format of the list elements in CheckboxSelectMultiple is
 {{{
  Blubb 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
-+--
  Reporter:  Scott Sinclair  | Owner:  nobody 
Status:  new | Milestone: 
 Component:  Forms   |   Version:  SVN
Resolution:  |  Keywords:  feature
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  1   |  
-+--
Changes (by adamnelson):

  * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
-+--
  Reporter:  Scott Sinclair  | Owner:  nobody 
Status:  new | Milestone: 
 Component:  Forms   |   Version:  SVN
Resolution:  |  Keywords:  feature
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by SmileyChris):

 * cc: scott-dja...@sbs.id.au, mic...@logix.cz, a...@andrewingram.net
 (added)

Comment:

 Says mr anonymous, also deleting everyone's CC.

 Bringing this up in the django dev group (at 1.3 proposals stage) would be
 the next step towards progress.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
-+--
  Reporter:  Scott Sinclair  | Owner:  nobody 
Status:  new | Milestone: 
 Component:  Forms   |   Version:  SVN
Resolution:  |  Keywords:  feature
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by anonymous):

 * cc: scott-dja...@sbs.id.au, mic...@logix.cz, a...@andrewingram.net
 (removed)

Comment:

 It Would be nice to access individual items from
 RadioSelect,CheckboxSelectMultiple.

 Anyone working on it ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4592: Make CheckboxSelectMultiple more like RadioSelect

[Django]

#4592: Make CheckboxSelectMultiple more like RadioSelect
-+--
  Reporter:  Scott Sinclair  | Owner:  nobody 
Status:  new | Milestone: 
 Component:  Forms   |   Version:  SVN
Resolution:  |  Keywords:  feature
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by AndrewIngram):

 * cc: a...@andrewingram.net (added)

Comment:

 This ticket looks like it's in limbo but it's something which I am keen to
 see progress. I've recently run into the need to override the way
 CheckboxSelectMultiple renders and my solution was pretty hacky. What
 needs to be done to get this going again? I'd be interested in getting
 involved, but I'm not sure whether to continue down the route of the
 existing patches or to look for different solutions (is this part of a
 bigger problem for allowing easy overrides of how ''any'' widget is
 rendered?).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.