Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+-
 Reporter:  anonymous|Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Core (Cache system)  |  Version:  SVN
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by guettli):

 * cc: hv@… (removed)
 * ui_ux:   => 0
 * type:   => Uncategorized
 * severity:   => Normal
 * easy:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
+---
  Reporter:  anonymous  | Owner:  nobody
Status:  reopened   | Milestone:
 Component:  Cache system   |   Version:  SVN   
Resolution: |  Keywords:
 Stage:  Ready for checkin  | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by jezdez):

  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
---+
  Reporter:  anonymous | Owner:  nobody
Status:  reopened  | Milestone:
 Component:  Cache system  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by elpaso66):

 * cc: apaso...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
---+
  Reporter:  anonymous | Owner:  nobody
Status:  reopened  | Milestone:
 Component:  Cache system  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by guettli):

 * cc: h...@tbz-pariv.de (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody
Status:  reopened| Milestone:
 Component:  Cache system|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by miracle2k):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Sorry. This has happened to me before. Is it a bug in Trac?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody
Status:  closed  | Milestone:
 Component:  Cache system|   Version:  SVN   
Resolution:  fixed   |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by miracle2k):

 * cc: miracle2k (added)
  * status:  reopened => closed
  * resolution:  => fixed

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody
Status:  reopened| Milestone:
 Component:  Cache system|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by anonymous):

 * cc: ta...@taijala.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody
Status:  reopened| Milestone:
 Component:  Cache system|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by kmike):

 I've implemented something like Daniel Pope 's suggestion and opened
 separate ticket for that: #11269.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody  
Status:  reopened| Milestone:  post-1.0
 Component:  Cache system|   Version:  SVN 
Resolution:  |  Keywords:  
 Stage:  Design decision needed  | Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Changes (by sylvain):

 * cc: sylvain.pas...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody  
Status:  reopened| Milestone:  post-1.0
 Component:  Cache system|   Version:  SVN 
Resolution:  |  Keywords:  
 Stage:  Design decision needed  | Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Changes (by springmeyer):

 * cc: dane.springme...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody  
Status:  reopened| Milestone:  post-1.0
 Component:  Cache system|   Version:  SVN 
Resolution:  |  Keywords:  
 Stage:  Design decision needed  | Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Changes (by garrison):

 * cc: j...@garrison.cc (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody  
Status:  reopened| Milestone:  post-1.0
 Component:  Cache system|   Version:  SVN 
Resolution:  |  Keywords:  
 Stage:  Design decision needed  | Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Changes (by PeterKz):

  * has_patch:  0 => 1

Comment:

 Uploaded patch for the current trunk.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody  
Status:  reopened| Milestone:  post-1.0
 Component:  Cache system|   Version:  SVN 
Resolution:  |  Keywords:  
 Stage:  Design decision needed  | Has_patch:  0   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Comment (by PeterKz):

 get_full_path() seems to be the way to go. It returns the path and query,
 but ignores the fragment identifier. So, this would be a minor patch that
 improves performance for many sites.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody  
Status:  reopened| Milestone:  post-1.0
 Component:  Cache system|   Version:  SVN 
Resolution:  |  Keywords:  
 Stage:  Design decision needed  | Has_patch:  0   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Comment (by Daniel Pope <[EMAIL PROTECTED]>):

 Restricting this to a subset of the GET parameters would only reduce the
 number of duplicate copies in the cache. As such I think it's more
 beneficial to provide transparent caching with a simple decorator API. The
 reason we need to use {{{request.get_full_path()}}} is that the current
 behaviour allows Django to serve the wrong page for requests with a query
 string. Trying to reduce the number of duplicate entries in the cache to
 the bare minimum is more of a wishlist item.

 Rather than building all of the possible ways you could generate cache
 keys into decorators, why not just allow {{{cache_page}}} to take a
 callable?

 eg.

 {{{
 @cache_page(key=lambda request: request.path)
 def slashdot_this(request):
   ...
 }}}

 This should still default to {{{request.get_full_path()}}} so that the
 default behaviour works for all views.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody  
Status:  reopened| Milestone:  post-1.0
 Component:  Cache system|   Version:  SVN 
Resolution:  |  Keywords:  
 Stage:  Design decision needed  | Has_patch:  0   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Comment (by PeterKz):

 Design-wise it would be great if the developer could be in control of
 which parameters that require a new cache item. After all, it is the
 developer who knows which parameters are likely to influence the result
 returned to the client. The currenct view cache decorator could be
 complemented like this:

 Vary by the entire URL (should be default behaviour):

 {{{
 @cache_page(60 * 15)
 @vary_by_param("*")
 def slashdot_this(request):
 ...
 }}}


 Only vary by values for parameter a and b (ignore everything else):

 {{{
 @cache_page(60 * 15)
 @vary_by_param(["a","b"])
 def slashdot_this(request):
 ...
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #4992: Alter cache key based on GET parameters

[Django]

#4992: Alter cache key based on GET parameters
-+--
  Reporter:  anonymous   | Owner:  nobody  
Status:  reopened| Milestone:  post-1.0
 Component:  Cache system|   Version:  SVN 
Resolution:  |  Keywords:  
 Stage:  Design decision needed  | Has_patch:  0   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  0   |  
-+--
Comment (by PeterKz):

 If I understand http://www.w3.org/DesignIssues/Axioms.html correctly you
 should treat URL:s as opaque and get three different cache objects for:

  * example.com/list/
  * example.com/list/?a=1=2
  * example.com/list/?b=2=1

 It is likely that there won't be many permutations for multiple URL
 parameters as they are typically constructed in a form controlled by the
 application developer.

 Implementing this would likely give a decent performance boost for Django
 apps that filter large lists based on query parameters.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---