Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+-
 Reporter:  aaloy@…  |Owner:  aaloy
 Type:   |   Status:  closed
Component:  Core (Cache system)  |  Version:  master
 Severity:   |   Resolution:  fixed
 Keywords:  cache i18n jgd-  | Triage Stage:  Accepted
  blackboard |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * ui_ux:   => 0
 * easy:   => 0


Comment:

 In [changeset:"258c88a913fe1e7704cdb6f61c6ceb7493f6092a" 258c88a]:
 {{{
 #!CommitTicketReference repository=""
 revision="258c88a913fe1e7704cdb6f61c6ceb7493f6092a"
 Refs #5691 -- Made cache keys independent of USE_L10N.

 This mostly reverts af1893c4ff8fdbf227a43a559d90bb1c1238b01a.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.50d0be9d0335660b2bc5ca9817aa9d78%40djangoproject.com.

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+-
   Reporter:  aaloy@…|Owner:  aaloy
   Type: |   Status:  closed
  Component:  Core (Cache system)|  Version:  SVN
   Severity: |   Resolution:  fixed
   Keywords:  cache i18n jgd-| Triage Stage:  Accepted
  blackboard |  Needs documentation:  0
  Has patch:  1  |  Patch needs improvement:  0
Needs tests:  0  |
-+-

Comment (by aaugustin):

 In [17061]:
 {{{
 #!CommitTicketReference repository="" revision="17061"
 Made the cache locale-dependant when USE_L10N is True, even if USE_I18N is
 False. Refs #5691.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  closed  | Milestone:  1.2  
 Component:  Cache system|   Version:  SVN  
Resolution:  fixed   |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  1   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Changes (by aaloy):

  * status:  assigned => closed
  * resolution:  => fixed

Comment:

 jezdez in my oppinion this is not a new feature, is just a bug correction,
 as one may expect that on a multilingual content page the cache should
 depend also on the language. Anyway I would be glad to document it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  reopened| Milestone:  1.2  
 Component:  Cache system|   Version:  SVN  
Resolution:  |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  1   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Changes (by jezdez):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Please don't close the ticket if there wasn't an actual commit.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  reopened| Milestone:  1.2  
 Component:  Cache system|   Version:  SVN  
Resolution:  |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  0   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Changes (by aaloy):

  * needs_docs:  1 => 0

Comment:

 Added an updated patch with documentation warning about the new cache key
 generation. As is an internal feature I'm not really sure about if it has
 to be documented or not.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  reopened| Milestone:  1.2  
 Component:  Cache system|   Version:  SVN  
Resolution:  |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  1   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Comment (by aaloy):

 Opps. Sorry it was not my intention :(

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  assigned| Milestone:  1.2  
 Component:  Cache system|   Version:  SVN  
Resolution:  |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  1   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Changes (by jezdez):

  * needs_docs:  0 => 1

Comment:

 I'm not sure if we break a promise changing the cache key in 1.2 or if
 it's ok since _generate_cache_header_key is undocumented API anyway.

 Anyway, a change needs to be documented.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  assigned| Milestone:  1.2  
 Component:  Cache system|   Version:  SVN  
Resolution:  |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  0   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Changes (by jezdez):

  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  assigned| Milestone:   
 Component:  Cache system|   Version:  SVN  
Resolution:  |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  0   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Comment (by floledermann):

 Any progress on checking this in? This is looking good, isn't it?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  assigned| Milestone:   
 Component:  Cache system|   Version:  SVN  
Resolution:  |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  0   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Comment (by ramiro):

 I've updated Antoni Aloy's patch to apply cleanly after r10335 and
 simplified tests to only include what's needed to run them as part of the
 Django test suite, also fixed them so they don't break other tests leaving
 test environment umodified.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  assigned| Milestone:   
 Component:  Cache system|   Version:  SVN  
Resolution:  |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  0   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Comment (by mrts):

 /me wonders how the heck did my totally unrelated comments end up in this
 ticket!? My guess: nazi transgender aliens did it (it's still April 1 in
 my timezone, so don't you dare to disagree!).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  aa...@apsl.net  | Owner:  aaloy
Status:  assigned| Milestone:   
 Component:  Cache system|   Version:  SVN  
Resolution:  |  Keywords:  cache i18n jgd-blackboard
 Stage:  Accepted| Has_patch:  1
Needs_docs:  0   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Changes (by jdunck):

  * keywords:  cache i18n => cache i18n jgd-blackboard

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  [EMAIL PROTECTED]  | Owner:  aaloy 
Status:  assigned| Milestone:
 Component:  Cache system|   Version:  SVN   
Resolution:  |  Keywords:  cache i18n
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  1   |  
-+--
Changes (by aaloy):

  * needs_docs:  1 => 0
  * needs_tests:  1 => 0

Comment:

 Added the patch an the tests to check that we generate the right keys and
 that middleware recovers different content depending on the language.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  [EMAIL PROTECTED]  | Owner:  aaloy 
Status:  assigned| Milestone:
 Component:  Cache system|   Version:  SVN   
Resolution:  |  Keywords:  cache i18n
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  1 
Needs_better_patch:  1   |  
-+--
Changes (by aaloy):

  * owner:  nobody => aaloy
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5691: Add the active language to generate the cache key

[Django]

#5691: Add the active language to generate the cache key
-+--
  Reporter:  [EMAIL PROTECTED]  | Owner:  nobody
Status:  new | Milestone:
 Component:  Cache system|   Version:  SVN   
Resolution:  |  Keywords:  cache i18n
 Stage:  Accepted| Has_patch:  1 
Needs_docs:  1   |   Needs_tests:  1 
Needs_better_patch:  1   |  
-+--
Comment (by aaloy):

 I'm working on a patch which could work as:

 {{{
 cache_key = 'views.decorators.cache.cache_header.%s.%s' % (
   key_prefix, iri_to_uri(request.path))
 if settings.USE_I18N:
cache_key += ".%s" % translation.get_language()
 }}}

 I have tested using other ways of string concatenations and this one is
 the fast way (0.6 s for 10^6 interactions) for the kind of keys we're
 generating.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---