Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+-
 Reporter:  Gary Wilson  |Owner:  Alexander
 |  Lazarević
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  1 => 0


Comment:

 There is nothing to review, at least for now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d219ea93f-e3bbc7af-ee76-43c9-8996-d8438760e22c-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+-
 Reporter:  Gary Wilson  |Owner:  Alexander
 |  Lazarević
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Alexander Lazarević):

 After the discussion in https://forum.djangoproject.com/t/cycle-template-
 tag-should-accept-a-single-argument/27010/3 I'm withdrawing the PR.

 My implementation would have introduced an ambiguity that would have had
 it made it harder for users to use the `cycle` tag.

 In the discussion @carlton mentioned that it could be worth "... to
 investigate [is] whether we could add * and ** list and dictionary
 expansion to the DTL. cycle could benefit from list expansion.".

 So I'm trying to come up with something in that direction instead.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d17441f68-c9369ff0-abff-4f0f-9366-344052834df0-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+-
 Reporter:  Gary Wilson  |Owner:  Alexander
 |  Lazarević
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Natalia Bidart):

 Replying to [comment:22 Alexander Lazarević]:
 > I just put something together at https://sandbox.e11bits.com/ to
 showcase the feature more broadly. Maybe people can judge by that, if the
 feature is desirable and help with the code review? It's just a quick
 hack, so don't expect too much. The examples are more or less the ones
 found as testcases in the PR. (crossposted to discord)

 Thank you Alexander for your work on this. In order to unify the
 conversation in a single place, I will reply to the forum thread with my
 view, hopefully we can agree on an implementation design there and then
 come back to the ticket.

 As a reference, [https://forum.djangoproject.com/t/cycle-template-tag-
 should-accept-a-single-argument/27010 this is the forum post].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d1328e4dd-e67291e1-db86-4d07-b01b-70a8e7cea338-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+-
 Reporter:  Gary Wilson  |Owner:  Alexander
 |  Lazarević
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Alexander Lazarević):

 I just put something together at https://sandbox.e11bits.com/ to showcase
 the feature more broadly. Maybe people can judge by that, if the feature
 is desirable and help with the code review? It's just a quick hack, so
 don't expect too much. The examples are more or less the ones found as
 testcases in the PR. (crossposted to discord)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d127f9a40-e23c5a4a-8c18-43d0-ac88-e82bcc73403d-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+-
 Reporter:  Gary Wilson  |Owner:  Alexander
 |  Lazarević
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Alexander Lazarević):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0
 * needs_docs:  1 => 0


Comment:

 For the new PR I'm going to remove "Needs documentation", "Needs tests"
 and "Patch needs improvement". Please set these flags again if required
 (or I should have left them set in the first place).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf272c309-20ddb240-045f-4e9f-b66b-58a16bcfa412-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+-
 Reporter:  Gary Wilson  |Owner:  Alexander
 |  Lazarević
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Alexander Lazarević):

 I created a PR https://github.com/django/django/pull/17716

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf1b2991a-81d896d9-1d98-4692-8986-3b0f40b67e50-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+-
 Reporter:  Gary Wilson  |Owner:  Alexander
 |  Lazarević
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Alexander Lazarević):

 * owner:  munhitsu => Alexander Lazarević
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf1235385-6d1a7d98-6f90-40c0-bb8a-563576fca66e-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+
 Reporter:  Gary Wilson  |Owner:  munhitsu
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by Mariusz Felisiak):

 Replying to [comment:17 Alexander Lazarević]:
 > Is this still considered a desirable feature?

 Yes, IMO nothing has changed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ced3d80f6-c2c51b81-9c7a-431f-a895-77965598cb81-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+
 Reporter:  Gary Wilson  |Owner:  munhitsu
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by Alexander Lazarević):

 Is this still considered a desirable feature?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ced374075-d2d9bec9-e902-4d20-8b00-12f91f23fb53-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
---+-
   Reporter:  gwilson  |  Owner:  munhitsu
   Type:  New feature  | Status:  reopened
  Milestone:   |  Component:  Template system
Version:  SVN  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  1|Needs tests:  1
Patch needs improvement:  1|  Easy pickings:  0
  UI/UX:  0|
---+-
Changes (by ptone):

 * needs_docs:  0 => 1
 * needs_tests:  0 => 1
 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
---+-
   Reporter:  gwilson  |  Owner:  munhitsu
   Type:  New feature  | Status:  reopened
  Milestone:   |  Component:  Template system
Version:  SVN  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+-
Changes (by Alex):

 * ui_ux:   => 0
 * stage:  Design decision needed => Accepted


Comment:

 Discussion with Carl: this new syntax would be ambiguous with the current
 syntax, however this is a good feature, and the current API is kind of
 silly.  This is accepted, provisional on creating a new, more sane and
 consistent syntax, to be placed in the future module.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+-
   Reporter:  gwilson|  Owner:  munhitsu
   Type:  New| Status:  reopened
  feature|  Component:  Template system
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Design |Needs tests:  0
  decision needed|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by julien):

 * easy:   => 0
 * stage:  Accepted => Design decision needed


Comment:

 A design decision hasn't been reached yet.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.