Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
--+
 Reporter:  korpios   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  reopened
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  nfa-someday   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by lrekucki):

 * needs_better_patch:  0 => 1


Comment:

 Needs a rebase to master.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
--+
 Reporter:  korpios   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  reopened
Component:  contrib.admin |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:  nfa-someday   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by kmike):

 * cc: kmike84@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
-+-
   Reporter:  korpios|  Owner:  nobody
   Type: | Status:  reopened
  Cleanup/optimization   |  Component:  contrib.admin
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  nfa-someday
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by Alex):

 * ui_ux:   => 0
 * easy:   => 0
 * stage:  Design decision needed => Accepted


Comment:

 I think the situation has improved recently, much code has been split off
 into utility functions, as a meta-point cleaning up code like this is
 always of value.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
-+--
  Reporter:  korpios | Owner:  nobody 
Status:  reopened| Milestone: 
 Component:  django.contrib.admin|   Version:  SVN
Resolution:  |  Keywords:  nfa-someday
 Stage:  Design decision needed  | Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by anonymous):

  * status:  closed => reopened
  * resolution:  wontfix =>

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
-+--
  Reporter:  korpios | Owner:  nobody 
Status:  closed  | Milestone: 
 Component:  django.contrib.admin|   Version:  SVN
Resolution:  wontfix |  Keywords:  nfa-someday
 Stage:  Design decision needed  | Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by anonymous):

  * status:  new => closed
  * resolution:  => wontfix

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
-+--
  Reporter:  korpios | Owner:  nobody 
Status:  new | Milestone: 
 Component:  django.contrib.admin|   Version:  SVN
Resolution:  |  Keywords:  nfa-someday
 Stage:  Design decision needed  | Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by sveri):

 Replying to [comment:20 athena_rd]:
 > Replying to [comment:19 dvine]:
 > > I absolutely support the patch by Martin Diers and would like to see
 it included. Still I also agree with korpios, that a
 [app_label]/[object_name]/template.html behaviore of all admin templates,
 thus eliminating the need for an custom template tag here, would be very
 desirable. Just wanted to bring up the topic again.
 >
 > [[BR]]
 > Seconded. I too would like to see this added as it would make adding
 items (i.e. searchbar) to custom admin views much easier.

 Yea, it definitely would. It would be great to have such a feature
 implemented. And i think it would make more sense, at least from my point
 of view.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
-+--
  Reporter:  korpios | Owner:  nobody 
Status:  new | Milestone: 
 Component:  django.contrib.admin|   Version:  SVN
Resolution:  |  Keywords:  nfa-someday
 Stage:  Design decision needed  | Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by athena_rd):

 Replying to [comment:19 dvine]:
 > I absolutely support the patch by Martin Diers and would like to see it
 included. Still I also agree with korpios, that a
 [app_label]/[object_name]/template.html behaviore of all admin templates,
 thus eliminating the need for an custom template tag here, would be very
 desirable. Just wanted to bring up the topic again.

 [[BR]]
 Seconded. I too would like to see this added as it would make adding items
 (i.e. searchbar) to custom admin views much easier.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
-+--
  Reporter:  korpios | Owner:  nobody 
Status:  new | Milestone: 
 Component:  django.contrib.admin|   Version:  SVN
Resolution:  |  Keywords:  nfa-someday
 Stage:  Design decision needed  | Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by dvine):

 I absolutely support the patch by Martin Diers and would like to see it
 included. Still I also agree with korpios, that a
 [app_label]/[object_name]/template.html behaviore of all admin templates,
 thus eliminating the need for an custom template tag here, would be very
 desirable. Just wanted to bring up the topic again.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
-+--
  Reporter:  korpios | Owner:  nobody 
Status:  new | Milestone: 
 Component:  django.contrib.admin|   Version:  SVN
Resolution:  |  Keywords:  nfa-someday
 Stage:  Design decision needed  | Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by mwdiers):

 I would argue that the template tag is not the problem. The real problem
 is that the row results themselves are not being rendered in a template at
 all - meaning that there is no way to tweak the result list row items.
 Moving the code out of the template tag, as the first patch does, does not
 solve the problem. It only moves it to a new location.

 It is easy to see why a custom tag was chosen here: Because the
 change_list template becomes especially cumbersome without it. Using the
 tag has encapsulated a chunk of code.

 By doing nothing other than moving the row rendering into the admin_list
 template tag itself, the problem is solved. It is trivial to create your
 own version of the admin_list template tag, and use it in your own
 overridden change_list template.

 This is still the ''one and only'' patch I apply to my Django
 installations. It is also backward-compatible. I hope it gets some
 attention soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6396: [newforms-admin] Customization-unfriendly admin template tags should die

[Django]

#6396: [newforms-admin] Customization-unfriendly admin template tags should die
-+--
  Reporter:  korpios | Owner:  nobody 
Status:  new | Milestone: 
 Component:  django.contrib.admin|   Version:  SVN
Resolution:  |  Keywords:  nfa-someday
 Stage:  Design decision needed  | Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by [EMAIL PROTECTED]):

 FWIW, this `result_list` templatetag is the biggest pain in
 [http://code.google.com/p/django-batchadmin/ batchadmin]'s side. These
 really do make customization more difficult.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---